Skip to content

HBASE-23971 protoc warns: "no protobuf syntax specified" - #1278

Merged
saintstack merged 5 commits into
apache:masterfrom
WenFeiYi:master
Mar 12, 2020
Merged

HBASE-23971 protoc warns: "no protobuf syntax specified"#1278
saintstack merged 5 commits into
apache:masterfrom
WenFeiYi:master

Conversation

@WenFeiYi

@WenFeiYiWenFeiYi commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Mar 12, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
-0 ⚠️patch1m 11sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hbaseprotoc0m 12shbase-endpoint in the patch failed.
-1 ❌hbaseprotoc0m 12shbase-examples in the patch failed.
-1 ❌hbaseprotoc0m 9shbase-rest in the patch failed.
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
6m 25s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1278
Optional Testsdupname asflicense cc hbaseprotoc prototool
unameLinux 5b3d356e1b14 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 20658c5
hbaseprotochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-endpoint.txt
hbaseprotochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-examples.txt
hbaseprotochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-rest.txt
Max. process+thread count62 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-endpoint hbase-examples hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 12, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall7m 11smaster passed
-0 ⚠️patch8m 30sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall6m 57sthe patch passed
_ Other Tests _
+1 💚unit0m 55shbase-protocol-shaded in the patch passed.
+1 💚unit0m 33shbase-protocol in the patch passed.
+1 💚unit3m 20shbase-endpoint in the patch passed.
+1 💚unit2m 46shbase-rest in the patch passed.
+1 💚unit1m 33shbase-examples in the patch passed.
27m 0s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1278
Optional Testsunit
unameLinux 0de3319aefb0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 20658c5
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/testReport/
Max. process+thread count3065 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-endpoint hbase-rest hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 12, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 58sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall5m 53smaster passed
-0 ⚠️patch7m 11sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 58sthe patch passed
_ Other Tests _
+1 💚unit0m 54shbase-protocol-shaded in the patch passed.
+1 💚unit0m 33shbase-protocol in the patch passed.
+1 💚unit3m 26shbase-endpoint in the patch passed.
+1 💚unit3m 55shbase-rest in the patch passed.
+1 💚unit1m 37shbase-examples in the patch passed.
27m 48s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1278
Optional Testsunit
unameLinux ee6bf5aeb88d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 20658c5
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/testReport/
Max. process+thread count2682 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-endpoint hbase-rest hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack reviewed Mar 12, 2020
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some proto files have the proto2 syntax qualifier already?

Otherwise this patch LGTM.

@WenFeiYi

WenFeiYi commented Mar 12, 2020

Copy link
Copy Markdown
ContributorAuthor

Some proto files have the proto2 syntax qualifier already?

Otherwise this patch LGTM.

yes, I browsed all, other proto files hava the 'proto2 syntax'.

@Apache-HBase

Apache-HBase commented Mar 12, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 20smaster passed
+1 💚checkstyle2m 13smaster passed
-1 ❌spotbugs1m 58shbase-server in master has 1 extant spotbugs warnings.
-0 ⚠️patch2m 44sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚checkstyle2m 11sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 9sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚hbaseprotoc3m 27sthe patch passed
+1 💚spotbugs9m 16sthe patch passed
_ Other Tests _
+1 💚asflicense1m 14sThe patch does not generate ASF License warnings.
62m 35s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1278
Optional Testsdupname asflicense cc hbaseprotoc prototool spotbugs hadoopcheck hbaseanti checkstyle
unameLinux e3d6cc965be1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 26f3702
spotbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-server hbase-endpoint hbase-rest hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 12, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 50smaster passed
+1 💚compile3m 44smaster passed
+1 💚shadedjars5m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 53smaster passed
-0 ⚠️patch8m 6sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 49sthe patch passed
+1 💚compile3m 33sthe patch passed
+1 💚javac3m 33sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 57sthe patch passed
_ Other Tests _
+1 💚unit0m 43shbase-protocol-shaded in the patch passed.
+1 💚unit0m 27shbase-protocol in the patch passed.
-1 ❌unit148m 12shbase-server in the patch failed.
+1 💚unit4m 21shbase-endpoint in the patch passed.
+1 💚unit5m 0shbase-rest in the patch passed.
+1 💚unit2m 26shbase-examples in the patch passed.
198m 41s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1278
Optional Testsunit javac javadoc shadedjars compile
unameLinux 51c2ffcd989c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 26f3702
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/testReport/
Max. process+thread count3648 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-server hbase-endpoint hbase-rest hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 12, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall7m 30smaster passed
+1 💚compile4m 39smaster passed
+1 💚shadedjars5m 46sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 21shbase-examples in master failed.
-0 ⚠️javadoc0m 25shbase-rest in master failed.
-0 ⚠️javadoc0m 43shbase-server in master failed.
-0 ⚠️patch8m 50sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall7m 4sthe patch passed
+1 💚compile4m 27sthe patch passed
+1 💚javac4m 27sthe patch passed
+1 💚shadedjars6m 22spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc1m 2shbase-server in the patch failed.
-0 ⚠️javadoc0m 37shbase-rest in the patch failed.
-0 ⚠️javadoc0m 32shbase-examples in the patch failed.
_ Other Tests _
+1 💚unit1m 18shbase-protocol-shaded in the patch passed.
+1 💚unit0m 53shbase-protocol in the patch passed.
-0 ⚠️unit153m 33shbase-server in the patch failed.
+1 💚unit3m 2shbase-endpoint in the patch passed.
+1 💚unit3m 13shbase-rest in the patch passed.
+1 💚unit1m 41shbase-examples in the patch passed.
208m 33s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1278
Optional Testsunit javac javadoc shadedjars compile
unameLinux d669637760f8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 26f3702
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/testReport/
Max. process+thread count3892 (vs. ulimit of 10000)
modulesC: hbase-protocol-shaded hbase-protocol hbase-server hbase-endpoint hbase-rest hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1278/2/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit abf0a22 into apache:masterMar 12, 2020
asfgit pushed a commit that referenced this pull request Mar 17, 2020
@saintstack
HBASE-23971protoc warns: "no protobuf syntax specified" (#1278)
9804f73
Remove overcommit in TestUsersOperationsWithSecureHadoop
(Noticed by ndimiduk)
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@WenFeiYi@thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
9077bcc
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
e98f9b9
Remove overcommit in TestUsersOperationsWithSecureHadoop
(Noticed by ndimiduk)
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@WenFeiYi@thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
aecb6f4
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack@thangTang
HBASE-23971 protoc warns: "no protobuf syntax specified" (apache#1278)
0de55e4
Remove overcommit in TestUsersOperationsWithSecureHadoop
(Noticed by ndimiduk)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WenFeiYi@Apache-HBase@saintstack