Skip to content

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d… - #1288

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-23987
Mar 14, 2020
Merged

HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…#1288
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-23987

Conversation

@Apache9

@Apache9Apache9 commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

…efault which is incorrect

@Apache9
Apache9 requested a review from saintstackMarch 14, 2020 03:56
saintstack
saintstack approved these changes Mar 14, 2020
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Apache-HBase

Apache-HBase commented Mar 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 38smaster passed
+1 💚compile0m 28smaster passed
+1 💚shadedjars4m 51sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 14sthe patch passed
+1 💚compile0m 25sthe patch passed
+1 💚javac0m 25sthe patch passed
+1 💚shadedjars4m 42spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
+1 💚unit0m 54shbase-client in the patch passed.
24m 50s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1288
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7d2969c8112d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b9e74e0
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/testReport/
Max. process+thread count602 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 34smaster passed
+1 💚compile0m 30smaster passed
+1 💚shadedjars5m 3sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 29shbase-client in master failed.
_ Patch Compile Tests _
+1 💚mvninstall6m 12sthe patch passed
+1 💚compile0m 30sthe patch passed
+1 💚javac0m 30sthe patch passed
+1 💚shadedjars4m 58spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 26shbase-client in the patch failed.
_ Other Tests _
+1 💚unit0m 59shbase-client in the patch passed.
27m 20s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1288
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8bbbc9728681 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b9e74e0
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/testReport/
Max. process+thread count451 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 35smaster passed
+1 💚checkstyle0m 32smaster passed
+1 💚spotbugs1m 4smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 8sthe patch passed
+1 💚checkstyle0m 28sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 17sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚spotbugs1m 10sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
38m 2s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1288
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 0a99b430e763 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b9e74e0
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-client U: hbase-client
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1288/1/console
versionsgit=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit ba3f026 into apache:masterMar 14, 2020
asfgit pushed a commit that referenced this pull request Mar 14, 2020
@Apache9
HBASE-23987NettyRpcClientConfigHelper will not share event loop by d…
26ab594
…efault which is incorrect (#1288)
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Apr 15, 2020
@Apache9@saintstack
HBASE-23987NettyRpcClientConfigHelper will not share event loop by d…
2d27e8d
…efault which is incorrect (#1288)
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@Apache9@thangTang
HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
6a9ce40
…efault which is incorrect (apache#1288)
Signed-off-by: stack <stack@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@Apache9@thangTang
HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
889333e
…efault which is incorrect (apache#1288)
Signed-off-by: stack <stack@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@Apache9@ddupg
HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
71bb097
…efault which is incorrect (apache#1288)
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 14, 2020
@Apache9@infraio
HBASE-23987NettyRpcClientConfigHelper will not share event loop by d…
882d2ae
…efault which is incorrect (#1288)
Signed-off-by: stack <stack@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@Apache9@infraio
HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
74096fe
…efault which is incorrect (apache#1288)
Signed-off-by: stack <stack@apache.org>
Conflicts:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@Apache9Guanghao Zhang
HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
c5a8a94
…efault which is incorrect (apache#1288)
Signed-off-by: stack <stack@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@Apache9@infraio
HBASE-23987 NettyRpcClientConfigHelper will not share event loop by d…
b36541f
…efault which is incorrect (apache#1288)
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 882d2ae)
Change-Id: I159f0d05f1a96bd8785fcc0fd7e2ca7c3936f225
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
Rushabh ShahRushabh ShahGitHub Enterprise
@W-18609130 Add metric for last marker row age for FKP migration (apa…
2f40850
…che#1288)
Co-authored-by: Rushabh Shah <rushabh.shah@MacBook-Pro.local>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@saintstack