Uh oh!
There was an error while loading. Please reload this page.
HBASE-23993 Use loopback for zk standalone server in minizkcluster - #1291
Merged
Conversation
Apache-HBase
commented
Mar 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 15, 2020
💔 -1 overall
This message was automatically generated. |
| define_test "set_peer_bandwidth: works with peer bandwidth upper limit" do | ||
| cluster_key = "localhost:2181:/hbase-test" | ||
| cluster_key = MiniZookeeperCluster::HOST + ":2181:/hbase-test" |
Contributor
There was a problem hiding this comment.
Test failure looks related to this one. Does the MiniZookeeperCluster need initialization before?
ContributorAuthor
There was a problem hiding this comment.
Thank you for taking a look @HorizonNet ... Let me see.
ContributorAuthor
There was a problem hiding this comment.
s/MiniZookeeperCluster::HOST/MiniZooKeeperCluster::HOST/
... the 'k' capitialization. Joy!
Apache-HBase
commented
Mar 15, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 15, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 15, 2020
🎊 +1 overall
This message was automatically generated. |
HorizonNet
commented
Mar 16, 2020
Contributor
Is the build still running or is it just dead? |
ContributorAuthor
@HorizonNet Looks sick. I see this: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting to resume part of HBase-PreCommit-GitHub-PR » PR-1291 #2: Waiting for next available executor on ‘H5’ Let me retry. I killed it and restarted the build. Will probably get same thing. Will keep an eye on it. On the failed TestAsyncTableGetMultiThreaded, there seems to be a general issue around cluster shutdown in teardown. I'll work on that next. Unrelated to this patch it seems (just tried locally with and w/o the patch) |
saintstack
commented
Mar 16, 2020
ContributorAuthor
Now I see this... .... Will wait a while. |
Apache-HBase
commented
Mar 16, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 16, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 16, 2020
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Mar 17, 2020
Contributor
IIRC, some secure related tests will fail on some platform if we use 127.0.0.1 instead of localhost... |
saintstack
commented
Mar 17, 2020
ContributorAuthor
@Apache9 You know which? I want to push this because it 'fixes' a general issue where standalone zk cluster won't come up because client and server can't find each other. |
Apache9
commented
Mar 17, 2020
Contributor
Never mind, only a small part of the UTs are secure and it only fails on a specific platform. If someone hit it let's try to fix it then. |
Apache9
commented
Mar 17, 2020
Contributor
The hbase-shell failure related? |
Apache-HBase
commented
Mar 17, 2020
🎊 +1 overall
This message was automatically generated. |
saintstack
commented
Mar 17, 2020
ContributorAuthor
Did a new push w/ checkstyle fix. Checked shell test locally and seems fine. Lets see. |
Apache-HBase
commented
Mar 17, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 17, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 17, 2020
💔 -1 overall
This message was automatically generated. |
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost'
saintstack
commented
Mar 17, 2020
ContributorAuthor
The shell failures were legit. For the other tests that are failing, OOME. |
Apache-HBase
commented
Mar 18, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 18, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 18, 2020
💔 -1 overall
This message was automatically generated. |
saintstack
commented
Mar 18, 2020
ContributorAuthor
Shell tests pass now. The remaining timeout seems unrelated and I'm working on these tests that don't complete in a follow-up. Merging. |
asfgit pushed a commit
that referenced
this pull request
Mar 18, 2020
…1291) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost' Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…pache#1291) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost' Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
thangTang pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…pache#1291) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java Have client and server use loopback instead of 'localhost' Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
Have client and server use loopback instead of 'localhost'