Skip to content

HBASE-22193 Add backoff when region failed open too many times - #133

Merged
infraio merged 1 commit into
apache:masterfrom
infraio:retry-backoff
Apr 13, 2019
Merged

HBASE-22193 Add backoff when region failed open too many times#133
infraio merged 1 commit into
apache:masterfrom
infraio:retry-backoff

Conversation

@infraio

@infraioinfraio commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Apr 9, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec43Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall254master passed
+1compile52master passed
+1checkstyle65master passed
+1shadedjars257branch has no errors when building our shaded downstream artifacts.
+1findbugs159master passed
+1javadoc33master passed
_ Patch Compile Tests _
+1mvninstall259the patch passed
+1compile53the patch passed
+1javac53the patch passed
+1checkstyle65the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars264patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck514Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs169the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit17615hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
19936
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.client.TestFromClientSide
hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.client.TestConnectionImplementation
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/artifact/out/Dockerfile
GITHUB PR#133
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e7b96488013a 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 74112e5
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/testReport/
Max. process+thread count5247 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 requested changes Apr 10, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated
@Apache-HBase

Apache-HBase commented Apr 10, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec251Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall264master passed
+1compile52master passed
+1checkstyle67master passed
+1shadedjars256branch has no errors when building our shaded downstream artifacts.
-1findbugs155hbase-server in master has 11 extant Findbugs warnings.
+1javadoc32master passed
_ Patch Compile Tests _
+1mvninstall236the patch passed
+1compile51the patch passed
+1javac52the patch passed
+1checkstyle67the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars263patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck521Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs193the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit16154hbase-server in the patch failed.
+1asflicense32The patch does not generate ASF License warnings.
18697
ReasonTests
Failed junit testshadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.client.TestSplitOrMergeStatus
hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/artifact/out/Dockerfile
GITHUB PR#133
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5b804743a53e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 494a8ef
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/artifact/out/branch-findbugs-hbase-server-warnings.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/testReport/
Max. process+thread count5057 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio
infraio requested a review from Apache9April 11, 2019 14:24
Apache9
Apache9 requested changes Apr 11, 2019
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated
@infraio
infraio requested a review from Apache9April 12, 2019 07:50
@Apache-HBase

Apache-HBase commented Apr 12, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec47Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall295master passed
+1compile63master passed
+1checkstyle68master passed
+1shadedjars264branch has no errors when building our shaded downstream artifacts.
+1findbugs194master passed
+1javadoc30master passed
_ Patch Compile Tests _
+1mvninstall241the patch passed
+1compile51the patch passed
+1javac51the patch passed
+1checkstyle64the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars250patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck517Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs184the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit17484hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
19888
ReasonTests
Failed junit testshadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
hadoop.hbase.master.TestSplitWALManager
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestAdmin1
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/artifact/out/Dockerfile
GITHUB PR#133
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c4532375a2e8 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / f227eb7
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/testReport/
Max. process+thread count5044 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-133/3/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@infraio
infraio merged commit 249ac58 into apache:masterApr 13, 2019
@infraio
infraio deleted the retry-backoff branch April 13, 2019 02:41
asfgit pushed a commit that referenced this pull request Apr 13, 2019
@infraio
Revert "Merge pull request#133from infraio/retry-backoff
e4e561b
HBASE-22193 Add backoff when region failed open too many times"
This reverts commit 249ac58, reversing
changes made to f7867c4.
@wchevreuilwchevreuil mentioned this pull request Oct 23, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@Apache9