Skip to content

HBASE-22202 Fix new findbugs issues after we upgrade hbase-thirdparty… - #139

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22202
Apr 12, 2019
Merged

HBASE-22202 Fix new findbugs issues after we upgrade hbase-thirdparty…#139
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22202

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

… dependencies

All are NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE, which is because we use the Function interface from guava and it is marked as Nullable.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec32Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall273master passed
+1compile53master passed
+1checkstyle71master passed
+1shadedjars262branch has no errors when building our shaded downstream artifacts.
-1findbugs178hbase-server in master has 11 extant Findbugs warnings.
+1javadoc35master passed
_ Patch Compile Tests _
+1mvninstall259the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle70hbase-server: The patch generated 0 new + 18 unchanged - 2 fixed = 18 total (was 20)
+1whitespace0The patch has no whitespace issues.
+1shadedjars276patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck531Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs186hbase-server generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
-1javadoc31hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
-1unit8354hbase-server in the patch failed.
+1asflicense23The patch does not generate ASF License warnings.
10762
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/Dockerfile
GITHUB PR#139
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 6636c758e725 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / fc6e3fc
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/branch-findbugs-hbase-server-warnings.html
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/testReport/
Max. process+thread count4444 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if tests pass

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec21Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall265master passed
+1compile53master passed
+1checkstyle76master passed
+1shadedjars274branch has no errors when building our shaded downstream artifacts.
-1findbugs179hbase-server in master has 11 extant Findbugs warnings.
+1javadoc36master passed
_ Patch Compile Tests _
+1mvninstall259the patch passed
+1compile55the patch passed
+1javac55the patch passed
+1checkstyle74hbase-server: The patch generated 0 new + 18 unchanged - 2 fixed = 18 total (was 20)
+1whitespace0The patch has no whitespace issues.
+1shadedjars274patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck534Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs181hbase-server generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
+1javadoc32the patch passed
_ Other Tests _
+1unit8179hbase-server in the patch passed.
+1asflicense24The patch does not generate ASF License warnings.
10590
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/artifact/out/Dockerfile
GITHUB PR#139
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f9167ffe67ed 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 2bae04f
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/artifact/out/branch-findbugs-hbase-server-warnings.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/testReport/
Max. process+thread count4867 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-139/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@saintstack