HBASE-24051 Allows indirect inheritance to CanUnbuffer by shenshengli · Pull Request #1404 · apache/hbase

shenshengli · 2020-04-01T03:40:34Z

If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer, you cannot get unbuffer

Apache-HBase · 2020-04-01T04:20:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 35s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 14s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
-1 ❌	unit	4m 32s	hbase-server in the patch failed.
		29m 56s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1404
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 53659b81fcc0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6f213e9`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/testReport/
Max. process+thread count	784 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-01T04:25:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 29s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	spotbugs	2m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 0s	the patch passed
-0 ⚠️	checkstyle	1m 6s	hbase-server: The patch generated 38 new + 7 unchanged - 0 fixed = 45 total (was 7)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 22s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 9s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		34m 45s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1404
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 7679741fa936 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6f213e9`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-01T04:26:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 27s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	5m 43s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 1s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	6m 55s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	5m 4s	hbase-server in the patch failed.
		35m 45s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1404
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 84ef7566d382 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6f213e9`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/testReport/
Max. process+thread count	675 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-04-01T04:56:06Z

- + " . So there may be a TCP socket connection "
- + "left open in CLOSE_WAIT state.", e);
- }
- return;


Why doesn't the old way work? Is it not finding the unbuffer method via reflection? Thanks.

The old method can only get those that implement Canbuffer directly.

saintstack · 2020-04-01T21:37:22Z

#1406 opened to replace this PR

shenshengli added 3 commits April 1, 2020 10:39

HBASE-24051Allows indirect inheritance to CanUnbuffer
b31c637

HBASE-24051Add UT
41f8e0d

Add agreements
64ab284

saintstack reviewed Apr 1, 2020
View reviewed changes

shenshengli closed this Apr 1, 2020

Navigation Menu

Uh oh!

HBASE-24051 Allows indirect inheritance to CanUnbuffer - #1404

HBASE-24051 Allows indirect inheritance to CanUnbuffer#1404
shenshengli wants to merge 3 commits into
apache:masterfrom
shenshengli:shenshengli-patch-n-HBASE-24051

shenshengli commented Apr 1, 2020

Uh oh!

Apache-HBase commented Apr 1, 2020

Uh oh!

Apache-HBase commented Apr 1, 2020

Uh oh!

Apache-HBase commented Apr 1, 2020

Uh oh!

saintstackApr 1, 2020

Uh oh!

shenshengliApr 1, 2020

Uh oh!

saintstack commented Apr 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

shenshengli commented Apr 1, 2020

Uh oh!

Apache-HBase commented Apr 1, 2020

Uh oh!

Apache-HBase commented Apr 1, 2020

Uh oh!

Apache-HBase commented Apr 1, 2020

Uh oh!

saintstackApr 1, 2020

Choose a reason for hiding this comment

Uh oh!

shenshengliApr 1, 2020

Choose a reason for hiding this comment

Uh oh!

saintstack commented Apr 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants