Skip to content

HBASE-24140 : Move CandidateGenerator and their implementors out of StochasticLoadBalancer - #1458

Merged
virajjasani merged 5 commits into
apache:masterfrom
virajjasani:HBASE-24140-master
Apr 12, 2020
Merged

HBASE-24140 : Move CandidateGenerator and their implementors out of StochasticLoadBalancer#1458
virajjasani merged 5 commits into
apache:masterfrom
virajjasani:HBASE-24140-master

Conversation

@virajjasani

@virajjasanivirajjasani commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

…tochasticLoadBalancer

busbey
busbey requested changes Apr 8, 2020
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/CandidateGenerator.java
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/LoadCandidateGenerator.java
Comment thread...r/src/main/java/org/apache/hadoop/hbase/master/balancer/LocalityBasedCandidateGenerator.java
Comment thread...r/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaCandidateGenerator.java
@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 26smaster passed
+1 💚checkstyle1m 7smaster passed
+1 💚spotbugs2m 1smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 54sthe patch passed
+1 💚checkstyle1m 6shbase-server: The patch generated 0 new + 28 unchanged - 5 fixed = 28 total (was 33)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 13sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 7sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
34m 21s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1458
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 9e3283e6faf7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ed83022
Max. process+thread count93 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani requested a review from busbeyApril 8, 2020 18:09
@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 21sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
-1 ❌mvninstall5m 58sroot in master failed.
+1 💚checkstyle1m 26smaster passed
+1 💚spotbugs2m 55smaster passed
_ Patch Compile Tests _
-1 ❌mvninstall5m 40sroot in the patch failed.
-0 ⚠️checkstyle1m 25shbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck2m 56sThe patch causes 16 errors with Hadoop v2.10.0.
-1 ❌hadoopcheck5m 41sThe patch causes 16 errors with Hadoop v3.1.2.
+1 💚spotbugs2m 39sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
29m 6s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1458
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux b4db15cbd02a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ac6060c
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/patch-javac-2.10.0.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
Max. process+thread count83 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 18sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌mvninstall7m 21sroot in master failed.
+1 💚compile1m 22smaster passed
-1 ❌shadedjars6m 17sbranch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc1m 1shbase-server in master failed.
_ Patch Compile Tests _
-1 ❌mvninstall6m 40sroot in the patch failed.
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
-1 ❌shadedjars5m 18spatch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit184m 55shbase-server in the patch failed.
219m 13s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ca6a423fe521 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2d78a28
Default Java2020-01-14
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/testReport/
Max. process+thread count3244 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 8, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 22sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌mvninstall5m 37sroot in master failed.
+1 💚compile1m 2smaster passed
-1 ❌shadedjars4m 52sbranch has 16 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40smaster passed
_ Patch Compile Tests _
-1 ❌mvninstall4m 49sroot in the patch failed.
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
-1 ❌shadedjars4m 41spatch has 16 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit212m 35shbase-server in the patch passed.
239m 36s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9def92518ad1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ac6060c
Default Java1.8.0_232
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/testReport/
Max. process+thread count2541 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
-1 ❌mvninstall6m 1sroot in master failed.
+1 💚checkstyle1m 18smaster passed
+1 💚spotbugs2m 12smaster passed
_ Patch Compile Tests _
-1 ❌mvninstall4m 51sroot in the patch failed.
-0 ⚠️checkstyle1m 15shbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck2m 44sThe patch causes 16 errors with Hadoop v2.10.0.
-1 ❌hadoopcheck5m 30sThe patch causes 16 errors with Hadoop v3.1.2.
+1 💚spotbugs2m 21sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
26m 47s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1458
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 10f3456f981e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / eb7df04
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/patch-javac-2.10.0.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
Max. process+thread count83 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
-1 ❌mvninstall4m 35sroot in master failed.
+1 💚compile0m 52smaster passed
-1 ❌shadedjars3m 56sbranch has 16 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36smaster passed
_ Patch Compile Tests _
-1 ❌mvninstall4m 6sroot in the patch failed.
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
-1 ❌shadedjars3m 57spatch has 16 errors when building our shaded downstream artifacts.
+1 💚javadoc0m 32sthe patch passed
_ Other Tests _
-1 ❌unit6m 0shbase-server in the patch failed.
27m 23s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f4411935d85d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / eb7df04
Default Java1.8.0_232
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/testReport/
Max. process+thread count649 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall6m 54smaster passed
+1 💚checkstyle1m 19smaster passed
+1 💚spotbugs2m 29smaster passed
_ Patch Compile Tests _
+1 💚mvninstall6m 49sthe patch passed
-0 ⚠️checkstyle1m 27shbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 42sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 23sthe patch passed
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
44m 58s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1458
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux d56bef5f3ec0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2907260
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count83 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani

virajjasani commented Apr 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@busbey Please review when you get time.
Thanks

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 58smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 15sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall5m 58sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 11spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit116m 56shbase-server in the patch passed.
144m 41s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6daa31646183 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2907260
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/testReport/
Max. process+thread count3762 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 9, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 55smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars4m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 29sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars4m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34sthe patch passed
_ Other Tests _
+1 💚unit170m 45shbase-server in the patch passed.
197m 8s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8c9bacb14abf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 2907260
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/testReport/
Max. process+thread count3127 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall7m 21smaster passed
+1 💚checkstyle1m 36smaster passed
+1 💚spotbugs2m 47smaster passed
_ Patch Compile Tests _
+1 💚mvninstall6m 36sthe patch passed
-0 ⚠️checkstyle1m 30shbase-server: The patch generated 1 new + 28 unchanged - 5 fixed = 29 total (was 33)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck14m 49sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
47m 10s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1458
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux c366631e9eac 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 14342b6
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count93 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 21smaster passed
+1 💚compile0m 55smaster passed
+1 💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36smaster passed
_ Patch Compile Tests _
+1 💚mvninstall5m 0sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit117m 14shbase-server in the patch passed.
142m 26s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bc4dff52cfb8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 14342b6
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/testReport/
Max. process+thread count3917 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall6m 6smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars5m 17sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 41shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall5m 56sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
+1 💚shadedjars5m 12spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 38shbase-server in the patch failed.
_ Other Tests _
+1 💚unit121m 35shbase-server in the patch passed.
150m 2s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1458
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 15544b4cca47 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 14342b6
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/testReport/
Max. process+thread count4210 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1458/5/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani changed the title HBASE-24140 : Move CandidateGenerator and their implementors out of S…HBASE-24140 : Move CandidateGenerator and their implementors out of StochasticLoadBalancerApr 12, 2020
@virajjasani
virajjasani merged commit b6b8c69 into apache:masterApr 12, 2020
virajjasani added a commit that referenced this pull request Apr 12, 2020
@virajjasani
HBASE-24140: Move CandidateGenerator and their implementors out of S…
45622ab
…tochasticLoadBalancer (#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
virajjasani added a commit that referenced this pull request Apr 12, 2020
@virajjasani
HBASE-24140: Move CandidateGenerator and their implementors out of S…
cd259d7
…tochasticLoadBalancer (#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasanitangtianhang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
ccd1029
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasanitangtianhang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
7b1f591
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani@thangTang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
9be00ec
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani@thangTang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
bc9c3a1
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@virajjasani@thangTang
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
24f3cd5
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@virajjasani@ddupg
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
5179717
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@virajjasanimeiyi
HBASE-24140 : Move CandidateGenerator and their implementors out of S…
ac4b84c
…tochasticLoadBalancer (apache#1458)
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HorizonNetHorizonNetHorizonNet approved these changes
@busbeybusbeyAwaiting requested review from busbey
@saintstacksaintstackAwaiting requested review from saintstack
@petersomogyipetersomogyiAwaiting requested review from petersomogyi
@anoopsjohnanoopsjohnAwaiting requested review from anoopsjohn
@Apache9Apache9Awaiting requested review from Apache9
@ramkrish86ramkrish86Awaiting requested review from ramkrish86

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@virajjasani@Apache-HBase@busbey@HorizonNet