Skip to content

HBASE-24168 Align the internal.protobuf.version in hbase-protocol-shaded with hbase-thirdparty - #1488

Merged
Apache9 merged 1 commit into
apache:branch-2.3from
ArthurSXL8:HBASE-24168-branch-2.3
Apr 13, 2020
Merged

HBASE-24168 Align the internal.protobuf.version in hbase-protocol-shaded with hbase-thirdparty#1488
Apache9 merged 1 commit into
apache:branch-2.3from
ArthurSXL8:HBASE-24168-branch-2.3

Conversation

@ArthurSXL8

@ArthurSXL8ArthurSXL8 commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

…ded with hbase-thirdparty

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.3 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
-1 ❌hadoopcheck3m 32sThe patch causes 41 errors with Hadoop v2.10.0.
-1 ❌hadoopcheck6m 52sThe patch causes 41 errors with Hadoop v3.1.2.
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
10m 37s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1488
Optional Testsdupname asflicense hadoopcheck xml
unameLinux c04b64ee8398 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / f5b3945
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-general-check/output/patch-javac-2.10.0.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
Max. process+thread count63 (vs. ulimit of 12500)
modulesC: hbase-examples hbase-protocol-shaded U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall6m 8sbranch-2.3 passed
+1 💚compile1m 3sbranch-2.3 passed
+1 💚shadedjars4m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31sbranch-2.3 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
-1 ❌mvninstall5m 36sroot in the patch failed.
-1 ❌compile0m 22shbase-examples in the patch failed.
-0 ⚠️javac0m 22shbase-examples in the patch failed.
+1 💚shadedjars4m 40spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-examples generated 40 new + 0 unchanged - 0 fixed = 40 total (was 0)
_ Other Tests _
+1 💚unit0m 45shbase-protocol-shaded in the patch passed.
-1 ❌unit0m 23shbase-examples in the patch failed.
27m 47s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1488
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1214cc40b716 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / f5b3945
Default Java1.8.0_232
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-examples.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-examples.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-examples.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-examples.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/testReport/
Max. process+thread count78 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall7m 15sbranch-2.3 passed
+1 💚compile1m 23sbranch-2.3 passed
+1 💚shadedjars5m 43sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 22shbase-examples in branch-2.3 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
-1 ❌mvninstall6m 46sroot in the patch failed.
-1 ❌compile0m 26shbase-examples in the patch failed.
-0 ⚠️javac0m 26shbase-examples in the patch failed.
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 16shbase-examples in the patch failed.
_ Other Tests _
+1 💚unit0m 52shbase-protocol-shaded in the patch passed.
-1 ❌unit0m 23shbase-examples in the patch failed.
32m 44s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1488
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 27f70490e02a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / f5b3945
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-examples.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-examples.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-examples.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/testReport/
Max. process+thread count81 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-examples U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ArthurSXL8
ArthurSXL8force-pushed the HBASE-24168-branch-2.3 branch from e634242 to b1466cfCompareApril 11, 2020 09:25
@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.3 Compile Tests _
_ Patch Compile Tests _
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 57sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
19m 45s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1488
Optional Testsdupname asflicense hadoopcheck xml
unameLinux 2dc5c3387c59 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / f5b3945
Max. process+thread count63 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded U: hbase-protocol-shaded
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+1 💚mvninstall6m 8sbranch-2.3 passed
+1 💚compile0m 41sbranch-2.3 passed
+1 💚shadedjars4m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 13sbranch-2.3 passed
_ Patch Compile Tests _
+1 💚mvninstall5m 39sthe patch passed
+1 💚compile0m 42sthe patch passed
+1 💚javac0m 42sthe patch passed
+1 💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
25m 10s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1488
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0a9b927830e6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / f5b3945
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/testReport/
Max. process+thread count63 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded U: hbase-protocol-shaded
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 11, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+1 💚mvninstall7m 9sbranch-2.3 passed
+1 💚compile0m 54sbranch-2.3 passed
+1 💚shadedjars5m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 14sbranch-2.3 passed
_ Patch Compile Tests _
+1 💚mvninstall7m 10sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars5m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 13sthe patch passed
_ Other Tests _
+1 💚unit0m 57shbase-protocol-shaded in the patch passed.
32m 33s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1488
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1d4fd883ad9f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / f5b3945
Default Java2020-01-14
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/testReport/
Max. process+thread count76 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded U: hbase-protocol-shaded
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1488/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 80011db into apache:branch-2.3Apr 13, 2020
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@ArthurSXL8Joseph295@ddupg
HBASE-24168 Align the internal.protobuf.version in hbase-protocol-sha…
2afeb8d
…ded with hbase-thirdparty (apache#1488)
Co-authored-by: Joseph295 <johnhomsea@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArthurSXL8@Apache-HBase@Apache9