Skip to content

HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek… - #1522

Merged
virajjasani merged 1 commit into
apache:masterfrom
virajjasani:HBASE-24194-master
Apr 16, 2020
Merged

HBASE-24194 : Refactor anonymous inner classes of BufferedEncodedSeek…#1522
virajjasani merged 1 commit into
apache:masterfrom
virajjasani:HBASE-24194-master

Conversation

@virajjasani

Copy link
Copy Markdown
Contributor

…er to named inner classes

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 7smaster passed
+1 💚compile0m 25smaster passed
+1 💚shadedjars5m 29sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 19shbase-common in master failed.
_ Patch Compile Tests _
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile0m 24sthe patch passed
+1 💚javac0m 24sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 17shbase-common in the patch failed.
_ Other Tests _
+1 💚unit1m 29shbase-common in the patch passed.
23m 31s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1522
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b70e066107f9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 38954ed
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/testReport/
Max. process+thread count271 (vs. ulimit of 12500)
modulesC: hbase-common U: hbase-common
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 40smaster passed
+1 💚compile0m 25smaster passed
+1 💚shadedjars5m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 15sthe patch passed
+1 💚compile0m 24sthe patch passed
+1 💚javac0m 24sthe patch passed
+1 💚shadedjars5m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21sthe patch passed
_ Other Tests _
+1 💚unit1m 44shbase-common in the patch passed.
26m 43s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1522
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 034b856621c3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 38954ed
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/testReport/
Max. process+thread count226 (vs. ulimit of 12500)
modulesC: hbase-common U: hbase-common
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 27smaster passed
+1 💚checkstyle0m 26smaster passed
+1 💚spotbugs0m 50smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 55sthe patch passed
-0 ⚠️checkstyle0m 25shbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 6sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs0m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
30m 51s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1522
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 203a8a5e4be3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 38954ed
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-common U: hbase-common
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1522/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@binlijinbinlijin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani
virajjasani merged commit 24e15c0 into apache:masterApr 16, 2020
@virajjasani
virajjasani deleted the HBASE-24194-master branch April 16, 2020 13:46
virajjasani added a commit that referenced this pull request Apr 16, 2020
…er to named inner classes (#1522)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
virajjasani added a commit that referenced this pull request Apr 16, 2020
…er to named inner classes (#1522)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
virajjasani added a commit that referenced this pull request Apr 16, 2020
…er to named inner classes (#1522)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
…er to named inner classes (apache#1522)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…er to named inner classes (apache#1522)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: binlijin <binlijin@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@virajjasani@Apache-HBase@binlijin@petersomogyi