Skip to content

HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal - #1535

Merged
saintstack merged 1 commit into
apache:branch-2.3from
jojochuang:HBASE-23833-branch-2.3
Apr 17, 2020
Merged

HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal#1535
saintstack merged 1 commit into
apache:branch-2.3from
jojochuang:HBASE-23833-branch-2.3

Conversation

@jojochuang

@jojochuangjojochuang commented Apr 16, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Cherrypick the commit to branch-2.3. The cherrypick is clean.

@jojochuang
HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase as…
4eee45f
…yncwal (apache#1301)
* Use Reflection to access shaded Hadoop protobuf classes.
(cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0)
* Update to improve the code:
1. Added license.
2. Added more comments.
3. Wrap byte array instead of copy to make a ByteString.
4. Moved all reflection instantiation to static class loading time.
* Use LiteralByteString to wrap byte array instead of copying it.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 72727ff)
(cherry picked from commit ae3de38)
@Apache-HBase

Apache-HBase commented Apr 16, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.3 Compile Tests _
+1 💚mvninstall3m 52sbranch-2.3 passed
+1 💚checkstyle1m 13sbranch-2.3 passed
+1 💚spotbugs2m 7sbranch-2.3 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 29sthe patch passed
-0 ⚠️checkstyle1m 13shbase-server: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 45sPatch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚spotbugs2m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
38m 27s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1535
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 428bc91ecd30 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / e1dcc7b
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 16, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+1 💚mvninstall3m 45sbranch-2.3 passed
+1 💚compile0m 55sbranch-2.3 passed
+1 💚shadedjars4m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sbranch-2.3 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 12sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars4m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit121m 9shbase-server in the patch passed.
143m 21s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#1535
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ebd9c2d2512f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / e1dcc7b
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/testReport/
Max. process+thread count3842 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Apr 16, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.3 Compile Tests _
+1 💚mvninstall4m 2sbranch-2.3 passed
+1 💚compile1m 3sbranch-2.3 passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in branch-2.3 failed.
_ Patch Compile Tests _
+1 💚mvninstall3m 50sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
+1 💚shadedjars5m 11spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 38shbase-server in the patch failed.
_ Other Tests _
+1 💚unit120m 22shbase-server in the patch passed.
145m 22s
SubsystemReport/Notes
DockerClient=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1535
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e8cc6519a1dd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.3 / e1dcc7b
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/testReport/
Max. process+thread count4010 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1535/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit b8b8e0a into apache:branch-2.3Apr 17, 2020
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
@jojochuang@ddupg
HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase as…
3620d44
…yncwal (apache#1301) (apache#1535)
* Use Reflection to access shaded Hadoop protobuf classes.
(cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0)
* Update to improve the code:
1. Added license.
2. Added more comments.
3. Wrap byte array instead of copy to make a ByteString.
4. Moved all reflection instantiation to static class loading time.
* Use LiteralByteString to wrap byte array instead of copying it.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 72727ff)
(cherry picked from commit ae3de38)
jojochuang added a commit to jojochuang/hbase that referenced this pull request Apr 23, 2020
@jojochuang
HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase as…
8fc1428
…yncwal (apache#1301) (apache#1535)
* Use Reflection to access shaded Hadoop protobuf classes.
(cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0)
* Update to improve the code:
1. Added license.
2. Added more comments.
3. Wrap byte array instead of copy to make a ByteString.
4. Moved all reflection instantiation to static class loading time.
* Use LiteralByteString to wrap byte array instead of copying it.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 72727ff)
(cherry picked from commit ae3de38)
(cherry picked from commit b8b8e0a)
@jojochuangjojochuang mentioned this pull request Apr 23, 2020
Merged
saintstack pushed a commit that referenced this pull request Apr 29, 2020
@jojochuang
HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase as…
6a2314d
…yncwal (#1301) (#1535) (#1567)
* Use Reflection to access shaded Hadoop protobuf classes.
(cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0)
* Update to improve the code:
1. Added license.
2. Added more comments.
3. Wrap byte array instead of copy to make a ByteString.
4. Moved all reflection instantiation to static class loading time.
* Use LiteralByteString to wrap byte array instead of copying it.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 72727ff)
(cherry picked from commit ae3de38)
(cherry picked from commit b8b8e0a)
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@jojochuang
HBASE-23833. The relocated hadoop-thirdparty protobuf breaks HBase as…
276c1d7
…yncwal (apache#1301) (apache#1535) (apache#1567)
* Use Reflection to access shaded Hadoop protobuf classes.
(cherry picked from commit a321e536989083ca3620bf2c53f12c07740bf5b0)
* Update to improve the code:
1. Added license.
2. Added more comments.
3. Wrap byte array instead of copy to make a ByteString.
4. Moved all reflection instantiation to static class loading time.
* Use LiteralByteString to wrap byte array instead of copying it.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 72727ff)
(cherry picked from commit ae3de38)
(cherry picked from commit b8b8e0a)
(cherry picked from commit 6a2314d)
Change-Id: Id87f30e022d36acbd629364e01e952954cce4460
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jojochuang@Apache-HBase@saintstack