Uh oh!
There was an error while loading. Please reload this page.
HBASE-24408 Introduce a general 'local region' to store data on master - #1753
Merged
Conversation
Apache9
commented
May 21, 2020
ContributorAuthor
The implementation is not perfect, as it initialize the store in RegionProcedureStore, and also the HFilePrinter and WALPrinter can not handle more than 1 family correctly. But anyway, it is enough for shipping with 2.3.0, later when we want to store more data in the region, we can refactor the code, maybe in HBASE-24388. |
Apache9
commented
May 21, 2020
ContributorAuthor
Another benefit for this patch is that, now HFile will be stored on the root file system instead of wal filesystem, so we can reuse the HFileCleaner instead of creating a new one by our own. And it is also a good news if later we want to implement WAL on a system other than file system. Added a UT called TestLocalRegionOnTwoFileSystems to confirm it. |
Apache-HBase
commented
May 21, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 21, 2020
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
May 21, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 22, 2020
💔 -1 overall
This message was automatically generated. |
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Some questions.
Another question is those who have deployed tests on branch-2.3 will have to shutdown these tests, remove the procedure store dir and then restart w/ a later version of 2.3 that has this in it? i.e. how to migrate existing 2.3s? A shutdown, remove, and restart seems fine since no 2.3 release as yet.
Good stuff.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| private static final String REPLAY_EDITS_DIR = "recovered.wals"; | ||
| private static final String DEAD_WAL_DIR_SUFFIX = "-dead"; |
ContributorAuthor
There was a problem hiding this comment.
The "-dead" is just like what we have done when processing dead region servers, where the suffix is '-splitting'. This is to prevent dead master to write procedure data again.
And on the 'recovered.wals' directory, it is used to hold the recovered wal files for the local region. As there is only one region, we do not need to split the wal during recovery, just move it to 'recovered.wals' directory and replay it.
I've explain this in HBASE-23326.
| private static final Logger LOG = LoggerFactory.getLogger(LocalRegion.class); | ||
| private static final String REPLAY_EDITS_DIR = "recovered.wals"; |
| .useHsync(false).ringBufferSlotCount(16).rollPeriodMs(TimeUnit.MINUTES.toMillis(15)) | ||
| .archivedWalSuffix(LocalStore.ARCHIVED_WAL_SUFFIX) | ||
| .archivedHFileSuffix(LocalStore.ARCHIVED_HFILE_SUFFIX); | ||
| REGION = LocalRegion.create(params); |
Contributor
There was a problem hiding this comment.
Are there params to set for local regions walfs and hfilefs?
ContributorAuthor
There was a problem hiding this comment.
No, there are set in Configuration.
Contributor
There was a problem hiding this comment.
Where are the keys defined?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Apache9
commented
May 22, 2020
ContributorAuthor
Leaving it there or removing it are both fine, if you want to keep the data then just follow the new naming to rename the old directory. We do not change the data format of the region. |
Apache9
commented
May 22, 2020
ContributorAuthor
Let me check the failed UTs. |
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache9force-pushed
the
HBASE-24408
branch
2 times, most recently
from
May 22, 2020 15:24
15f5fc9 to
0f5d045CompareApache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
May 22, 2020
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Nice cleanup. Thanks for prepping for furture so we can store other entity types locally -- e.g. RootTable -- if needed.
| procedureStore = new RegionProcedureStore(this, cleanerPool, | ||
| new MasterProcedureEnv.FsUtilsLeaseRecovery(this)); | ||
| procedureStore = | ||
| new RegionProcedureStore(this, localStore, new MasterProcedureEnv.FsUtilsLeaseRecovery(this)); |
Contributor
There was a problem hiding this comment.
The passing of an already initialized localregion is what is nice.
| file.getName().endsWith(LocalStore.ARCHIVED_WAL_SUFFIX); | ||
| } | ||
| @Override |
| private static final String REPLAY_EDITS_DIR = "recovered.wals"; | ||
| private static final String DEAD_WAL_DIR_SUFFIX = "-dead"; |
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Nice. This is cleaner w/ the passing in of the local region.
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 22, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 23, 2020
🎊 +1 overall
This message was automatically generated. |
asfgit pushed a commit
that referenced
this pull request
May 23, 2020
#1753) Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
May 23, 2020
#1753) Signed-off-by: stack <stack@apache.org>
| * Used for storing data at master side. The data will be stored in a {@link LocalRegion}. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public final class LocalStore { |
Member
There was a problem hiding this comment.
This class name confuses me. I see now that it uses "store" as a legacy of what was earlier called the "ProcedureStore". The confusion is this: our Regions also have an internal structure called a "Store".
Maybe o.a.h.h.master.store should now be called o.a.h.h.master.region. This class is apparently just a delegate to the region instance. Maybe we can rename LocalRegion to MasterRegion, do away with this LocalStore, replace it with a MasterRegionFactory, and let the caller invoke methods directly on the MasterRegion.
ContributorAuthor
There was a problem hiding this comment.
Sounds fine.
Let me open a new issue for this.
ContributorAuthor
There was a problem hiding this comment.
infraio pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
apache#1753) Signed-off-by: stack <stack@apache.org>
clarax pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
apache#1753) Signed-off-by: stack <stack@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.