HBASE-21406 "status 'replication'" should not show SINK if the cluste… by wchevreuil · Pull Request #1761 · apache/hbase

wchevreuil · 2020-05-22T09:44:32Z

…r does not act as sink

Apache-HBase · 2020-05-22T10:42:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	4m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s	master passed
+1 💚	checkstyle	2m 55s	master passed
+1 💚	spotbugs	8m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	2m 16s	Maven dependency ordering for patch
-1 ❌	mvninstall	2m 13s	root in the patch failed.
+1 💚	checkstyle	2m 27s	the patch passed
-0 ⚠️	rubocop	0m 12s	The patch generated 22 new + 319 unchanged - 4 fixed = 341 total (was 323)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	2m 22s	The patch causes 16 errors with Hadoop v3.1.2.
-1 ❌	hadoopcheck	4m 50s	The patch causes 16 errors with Hadoop v3.2.1.
-1 ❌	hbaseprotoc	0m 42s	hbase-server in the patch failed.
-1 ❌	spotbugs	0m 29s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	1m 1s	The patch does not generate ASF License warnings.
		47m 13s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux 8a6c378f5731 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9d9f07b`
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hbaseprotoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count	95 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-22T10:46:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	4m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 45s	master passed
+1 💚	compile	3m 37s	master passed
+1 💚	shadedjars	7m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	2m 17s	Maven dependency ordering for patch
-1 ❌	mvninstall	2m 14s	root in the patch failed.
-1 ❌	compile	0m 50s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 50s	hbase-server in the patch failed.
-1 ❌	shadedjars	5m 28s	patch has 16 errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 56s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 44s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 24s	hbase-client in the patch passed.
-1 ❌	unit	0m 47s	hbase-server in the patch failed.
-1 ❌	unit	7m 50s	hbase-shell in the patch failed.
		51m 21s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0bda33c73a30 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9d9f07b`
Default Java	1.8.0_232
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/testReport/
Max. process+thread count	1080 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-22T10:51:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	4m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 32s	master passed
+1 💚	compile	4m 6s	master passed
+1 💚	shadedjars	7m 22s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 34s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 23s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 56s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	2m 36s	Maven dependency ordering for patch
-1 ❌	mvninstall	2m 41s	root in the patch failed.
-1 ❌	compile	0m 53s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 53s	hbase-server in the patch failed.
-1 ❌	shadedjars	5m 26s	patch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 21s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 28s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 46s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 14s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 47s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 35s	hbase-client in the patch passed.
-1 ❌	unit	0m 56s	hbase-server in the patch failed.
-1 ❌	unit	7m 53s	hbase-shell in the patch failed.
		56m 16s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5583b7b439ae 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9d9f07b`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/testReport/
Max. process+thread count	1105 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

Looks good. Left a couple of nits.

virajjasani · 2020-05-22T12:03:29Z

+ assertEquals(loadSink.getTimestampStarted(), loadSink.getTimestampsOfLastAppliedOp());
+ //now insert some rows on source, so that it gets delivered to target
+ insertRowsOnSource();
+ Thread.sleep(10000);


Although 10s seems more than enough time, we can use Waiter.wait() / HBASE_TESTING_UTILITY.waitFor() with predicate to check if loadSink.getTimestampsOfLastAppliedOp()>loadSink.getTimestampStarted().

virajjasani · 2020-05-22T12:18:56Z

+ }
+
+ /**
+ * Gets the total number of OPs delivered to target by this sink.


nit: Gets the total number of OPs delivered to this sink would be better? WDYT?

Apache-HBase · 2020-05-23T14:49:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	master passed
+1 💚	checkstyle	2m 12s	master passed
+1 💚	spotbugs	6m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	checkstyle	2m 12s	the patch passed
-0 ⚠️	rubocop	0m 8s	The patch generated 22 new + 319 unchanged - 4 fixed = 341 total (was 323)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 45s	the patch passed
+1 💚	spotbugs	7m 21s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 4s	The patch does not generate ASF License warnings.
		49m 42s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux e49b853f87eb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c303f9d`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T16:46:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	3m 11s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 19s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 25s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 39s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	3m 12s	the patch passed
+1 💚	javac	3m 12s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 19s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 26s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 38s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	0m 57s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 34s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 3s	hbase-client in the patch passed.
+1 💚	unit	123m 15s	hbase-server in the patch passed.
-1 ❌	unit	7m 21s	hbase-shell in the patch failed.
		166m 41s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4893a5ee9a6b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c303f9d`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/testReport/
Max. process+thread count	4674 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T16:57:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	2m 48s	master passed
+1 💚	shadedjars	5m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	2m 44s	the patch passed
+1 💚	javac	2m 44s	the patch passed
+1 💚	shadedjars	5m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 45s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 1s	hbase-client in the patch passed.
+1 💚	unit	135m 57s	hbase-server in the patch passed.
-1 ❌	unit	7m 29s	hbase-shell in the patch failed.
		176m 56s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 20f48b3bc3e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c303f9d`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/testReport/
Max. process+thread count	4261 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T18:49:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 40s	master passed
+1 💚	checkstyle	2m 13s	master passed
+1 💚	spotbugs	6m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
-0 ⚠️	checkstyle	1m 2s	hbase-server: The patch generated 5 new + 5 unchanged - 0 fixed = 10 total (was 5)
-0 ⚠️	rubocop	0m 7s	The patch generated 22 new + 319 unchanged - 4 fixed = 341 total (was 323)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 44s	the patch passed
+1 💚	spotbugs	7m 6s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 2s	The patch does not generate ASF License warnings.
		49m 24s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux 472e8cf0155a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c303f9d`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T20:53:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	master passed
+1 💚	compile	2m 45s	master passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	2m 44s	the patch passed
+1 💚	javac	2m 44s	the patch passed
+1 💚	shadedjars	5m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 33s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 0s	hbase-client in the patch passed.
+1 💚	unit	132m 5s	hbase-server in the patch passed.
-1 ❌	unit	7m 27s	hbase-shell in the patch failed.
		173m 1s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7dd7b4211a38 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c303f9d`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/testReport/
Max. process+thread count	4155 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-23T21:52:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s	master passed
+1 💚	compile	3m 19s	master passed
+1 💚	shadedjars	6m 24s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 25s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 18s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	3m 17s	the patch passed
+1 💚	javac	3m 17s	the patch passed
+1 💚	shadedjars	6m 27s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 25s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 1s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 40s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 18s	hbase-client in the patch passed.
-1 ❌	unit	184m 53s	hbase-server in the patch failed.
-1 ❌	unit	8m 7s	hbase-shell in the patch failed.
		232m 11s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 18392ac4b7e8 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c303f9d`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/testReport/
Max. process+thread count	3016 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

Small nit, +1 otherwise

virajjasani · 2020-05-24T03:21:15Z

+ //now insert some rows on source, so that it gets delivered to target
+ insertRowsOnSource();
+ long wait = Waiter.waitFor(UTIL2.getConfiguration(),
+ 100000, new Waiter.Predicate<Exception>() {


Want to keep it 10s instead of 100s? :)

Apache-HBase · 2020-05-25T19:41:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 50s	master passed
+1 💚	checkstyle	2m 12s	master passed
+1 💚	spotbugs	6m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s	the patch passed
-0 ⚠️	checkstyle	1m 10s	hbase-server: The patch generated 5 new + 5 unchanged - 0 fixed = 10 total (was 5)
-0 ⚠️	rubocop	0m 10s	The patch generated 22 new + 319 unchanged - 4 fixed = 341 total (was 323)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 1s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 37s	the patch passed
+1 💚	spotbugs	7m 27s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		51m 21s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux 596405e0eea6 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `285e59a`
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-25T21:42:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 20s	master passed
+1 💚	compile	2m 44s	master passed
+1 💚	shadedjars	5m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	2m 45s	the patch passed
+1 💚	javac	2m 45s	the patch passed
+1 💚	shadedjars	5m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 31s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 0s	hbase-client in the patch passed.
+1 💚	unit	132m 3s	hbase-server in the patch passed.
-1 ❌	unit	7m 33s	hbase-shell in the patch failed.
		172m 41s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux da771442a324 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `285e59a`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/testReport/
Max. process+thread count	3660 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-25T22:43:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 44s	master passed
+1 💚	compile	3m 20s	master passed
+1 💚	shadedjars	6m 39s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 26s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 17s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	3m 20s	the patch passed
+1 💚	javac	3m 20s	the patch passed
+1 💚	shadedjars	6m 22s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 18s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 24s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 2s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 39s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 18s	hbase-client in the patch passed.
+1 💚	unit	185m 23s	hbase-server in the patch passed.
-1 ❌	unit	8m 8s	hbase-shell in the patch failed.
		233m 10s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 26bed1ce8c4f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `285e59a`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/testReport/
Max. process+thread count	2964 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/4/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-25T23:35:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 22s	master passed
+1 💚	checkstyle	2m 13s	master passed
+1 💚	spotbugs	6m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	checkstyle	2m 10s	the patch passed
-0 ⚠️	rubocop	0m 7s	The patch generated 22 new + 319 unchanged - 4 fixed = 341 total (was 323)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 9s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 44s	the patch passed
+1 💚	spotbugs	7m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 59s	The patch does not generate ASF License warnings.
		49m 49s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux 6ab342da92aa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `285e59a`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-26T03:14:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 35s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	2m 57s	master passed
+1 💚	shadedjars	6m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	2m 49s	the patch passed
+1 💚	javac	2m 49s	the patch passed
+1 💚	shadedjars	6m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 48s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 37s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 10s	hbase-client in the patch passed.
+1 💚	unit	221m 49s	hbase-server in the patch passed.
-1 ❌	unit	8m 45s	hbase-shell in the patch failed.
		269m 13s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 63d7f6e86ec0 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `285e59a`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/testReport/
Max. process+thread count	2723 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/5/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM. Left a minor NIT. Are test failures related?

joshelser

Just one minor feedback in the ruby code -- fine to fix on commit.

Looks good!

…failures

Apache-HBase · 2020-06-01T19:37:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 49s	master passed
+1 💚	checkstyle	2m 13s	master passed
+1 💚	spotbugs	6m 50s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 41s	the patch passed
+1 💚	checkstyle	2m 11s	the patch passed
-0 ⚠️	rubocop	0m 8s	The patch generated 22 new + 325 unchanged - 4 fixed = 347 total (was 329)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 2s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 38s	the patch passed
+1 💚	spotbugs	7m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		51m 43s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
uname	Linux 250082e1e68a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716702a`
rubocop	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-01T21:57:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 21s	master passed
+1 💚	compile	4m 13s	master passed
+1 💚	shadedjars	8m 11s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 31s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 22s	hbase-hadoop-compat in master failed.
-0 ⚠️	javadoc	0m 49s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 38s	the patch passed
+1 💚	compile	4m 4s	the patch passed
+1 💚	javac	4m 4s	the patch passed
+1 💚	shadedjars	8m 33s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 22s	hbase-hadoop-compat in the patch failed.
-0 ⚠️	javadoc	0m 31s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 47s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 10s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 40s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	136m 26s	hbase-server in the patch passed.
+1 💚	unit	8m 4s	hbase-shell in the patch passed.
		192m 19s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c3cc0b913af1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716702a`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/testReport/
Max. process+thread count	4058 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-01T22:52:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 40s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	2m 56s	master passed
+1 💚	shadedjars	6m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	2m 47s	the patch passed
+1 💚	javac	2m 47s	the patch passed
+1 💚	shadedjars	6m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 47s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	0m 36s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 13s	hbase-client in the patch passed.
+1 💚	unit	201m 9s	hbase-server in the patch passed.
+1 💚	unit	8m 18s	hbase-shell in the patch passed.
		246m 41s

Subsystem	Report/Notes
Docker	Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1761
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 28a7f6cd352c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `716702a`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/testReport/
Max. process+thread count	3485 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-shell U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1761/6/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

#1761) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (Cherry picked from commit e5345b3)

apache#1761) Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com> Signed-off by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (Cherry picked from commit e5345b3)

HBASE-21406 "status 'replication'" should not show SINK if the cluste…
54444c7
…r does not act as sink

wchevreuil requested review from HorizonNet, busbey, joshelser, petersomogyi and virajjasani May 22, 2020 09:44

virajjasani reviewed May 22, 2020
View reviewed changes

fixing build issues
28562e0

addressing Viraj suggestions.
64a3888

virajjasani approved these changes May 24, 2020
View reviewed changes

Adjusting the waiter timeout
6645ae4

Adjusting checkstyles
5b9f46c

HorizonNet approved these changes May 27, 2020
View reviewed changes

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSink.java Outdated

joshelser approved these changes May 28, 2020
View reviewed changes

Comment threadhbase-shell/src/main/ruby/hbase/admin.rb Outdated

Addressing latest comments from Josh and Jan, together with shell UT …
d19ea42
…failures

joshelser approved these changes Jun 1, 2020
View reviewed changes

wchevreuil merged commit e5345b3 into apache:masterJun 2, 2020

Uh oh!

Conversation

wchevreuil commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

Apache-HBase commented May 22, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasaniMay 22, 2020

Choose a reason for hiding this comment

Uh oh!

virajjasaniMay 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

Apache-HBase commented May 23, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasaniMay 24, 2020

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 25, 2020

Uh oh!

Apache-HBase commented May 25, 2020

Uh oh!

Apache-HBase commented May 25, 2020

Uh oh!

Apache-HBase commented May 25, 2020

Uh oh!

Apache-HBase commented May 26, 2020

Uh oh!

HorizonNet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Jun 1, 2020

Uh oh!

Apache-HBase commented Jun 1, 2020

Uh oh!

Apache-HBase commented Jun 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

virajjasaniMay 22, 2020•
edited
Loading

HorizonNet left a comment •
edited
Loading