Skip to content

HBASE-24422: Remove hbase-native-client code from the master branch - #1766

Merged
bharathv merged 1 commit into
apache:masterfrom
bharathv:HBASE-24422
May 24, 2020
Merged

HBASE-24422: Remove hbase-native-client code from the master branch#1766
bharathv merged 1 commit into
apache:masterfrom
bharathv:HBASE-24422

Conversation

@bharathv

Copy link
Copy Markdown
Contributor

Per recent discussions in the slack channel, there is not much value
in having this code in the master branch. This code has it's dedicated
git repo at https://github.com/apache/hbase-native-client.

It was already removed from branch-1 (HBASE-19419) and branch-2
(HBASE-19176)

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗shelldocs0m 1sShelldocs was not available.
+0 🆗markdownlint0m 1smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚shellcheck0m 1sThe patch generated 0 new + 1 unchanged - 40 fixed = 1 total (was 41)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
2m 7s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1766
JIRA IssueHBASE-24422
Optional Testsdupname asflicense shellcheck shelldocs cc markdownlint golang
unameLinux ac28087ef7c3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c303f9d
Max. process+thread count51 (vs. ulimit of 12500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey

Copy link
Copy Markdown
Contributor

Conversations in slack generally should not count as project discussions per the "must be on the mailing list" bit.

However, totally agree we're overdue on removing this

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall5m 1smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 49sthe patch passed
_ Other Tests _
+1 💚unit258m 4sroot in the patch passed.
270m 27s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#1766
JIRA IssueHBASE-24422
Optional Testsunit
unameLinux d729380f12af 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c303f9d
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/testReport/
Max. process+thread count5012 (vs. ulimit of 12500)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

There is not much value in having this code in the master branch.
This code has it's dedicated git repo at
https://github.com/apache/hbase-native-client.
It was already removed from branch-1 (HBASE-19419) and branch-2
(HBASE-19176)
@bharathv

Copy link
Copy Markdown
ContributorAuthor

Conversations in slack generally should not count as project discussions per the "must be on the mailing list" bit.

Fixed the commit message to remove this part.

@bharathv
bharathv merged commit 2382f90 into apache:masterMay 24, 2020
@bharathv
bharathv deleted the HBASE-24422 branch May 24, 2020 23:20
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#1766 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#1766
JIRA IssueHBASE-24422
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/2/console
versionsgit=2.17.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

2 similar comments
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#1766 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#1766
JIRA IssueHBASE-24422
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/2/console
versionsgit=2.17.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌patch0m 3s#1766 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#1766
JIRA IssueHBASE-24422
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1766/2/console
versionsgit=2.17.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bharathv@Apache-HBase@busbey@HorizonNet@virajjasani