Skip to content

HBASE-22284 optimization StringBuilder.append of AbstractMemStore.toString - #182

Merged
saintstack merged 1 commit into
apache:branch-2.1from
WenFeiYi:branch-2.1
Jun 9, 2019
Merged

HBASE-22284 optimization StringBuilder.append of AbstractMemStore.toString#182
saintstack merged 1 commit into
apache:branch-2.1from
WenFeiYi:branch-2.1

Conversation

@WenFeiYi

Copy link
Copy Markdown
Contributor

No description provided.

@WenFeiYiWenFeiYi changed the title HBASE-22284 optimization StringBuilder.appendd of AbstractMemStore.toStringHBASE-22284 optimization StringBuilder.append of AbstractMemStore.toStringApr 22, 2019
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec43Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall291branch-2.1 passed
+1compile65branch-2.1 passed
+1checkstyle84branch-2.1 passed
+1shadedjars307branch has no errors when building our shaded downstream artifacts.
+1findbugs161branch-2.1 passed
+1javadoc41branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall294the patch passed
+1compile64the patch passed
+1javac64the patch passed
+1checkstyle84the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars310patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck612Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs186the patch passed
+1javadoc39the patch passed
_ Other Tests _
-1unit13702hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
16393
ReasonTests
Failed junit testshadoop.hbase.TestMetaTableAccessor
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/1/artifact/out/Dockerfile
GITHUB PR#182
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 725c8dc3c682 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2.1 / 16cc2a3
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/1/testReport/
Max. process+thread count5037 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec44Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1mvninstall253branch-2.1 passed
+1compile52branch-2.1 passed
+1checkstyle76branch-2.1 passed
+1shadedjars242branch has no errors when building our shaded downstream artifacts.
+1findbugs137branch-2.1 passed
+1javadoc32branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall236the patch passed
+1compile51the patch passed
+1javac51the patch passed
+1checkstyle74the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars241patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck987Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1findbugs148the patch passed
+1javadoc31the patch passed
_ Other Tests _
-1unit12115hbase-server in the patch failed.
+1asflicense35The patch does not generate ASF License warnings.
15061
ReasonTests
Failed junit testshadoop.hbase.coprocessor.TestMetaTableMetrics
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/2/artifact/out/Dockerfile
GITHUB PR#182
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux f3ee20e779b3 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2.1 / b3a63fe
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/2/testReport/
Max. process+thread count5066 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-182/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 5ae8bc4 into apache:branch-2.1Jun 9, 2019
@WenFeiYi
WenFeiYi deleted the branch-2.1 branch January 3, 2020 09:02
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…tring apache#182
(cherry picked from commit b086c5d)
Change-Id: I95b50ad0a182293d3830a91c64d2e0787431460d
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 26, 2024
Co-authored-by: Richard Antal <richardantal@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WenFeiYi@Apache-HBase@saintstack