Skip to content

HBASE-22294 Removed deprecated method from WALKeyImpl - #186

Merged
HorizonNet merged 1 commit into
apache:masterfrom
anis016:HBASE-22294
Apr 24, 2019
Merged

HBASE-22294 Removed deprecated method from WALKeyImpl#186
HorizonNet merged 1 commit into
apache:masterfrom
anis016:HBASE-22294

Conversation

@anis016

Copy link
Copy Markdown
Contributor

Removed deprecated methods in ReplicationLoadSink.
Fixes: HBASE-22294

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval, pending QA bot.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec20Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall269master passed
+1compile52master passed
+1checkstyle76master passed
+1shadedjars279branch has no errors when building our shaded downstream artifacts.
+1findbugs193master passed
+1javadoc34master passed
_ Patch Compile Tests _
+1mvninstall251the patch passed
+1compile54the patch passed
+1javac54the patch passed
+1checkstyle74the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars278patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck538Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1findbugs193the patch passed
+1javadoc32the patch passed
_ Other Tests _
+1unit8604hbase-server in the patch passed.
+1asflicense25The patch does not generate ASF License warnings.
11044
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-186/1/artifact/out/Dockerfile
GITHUB PR#186
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 054187f2f0e7 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / ab3d6cf
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-186/1/testReport/
Max. process+thread count4849 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-186/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 5bc7eda into apache:masterApr 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@anis016@Apache-HBase@HorizonNet