Skip to content

HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re… - #2019

Merged
infraio merged 1 commit into
apache:HBASE-24666from
infraio:HBASE-24681
Jul 13, 2020
Merged

HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…#2019
infraio merged 1 commit into
apache:HBASE-24666from
infraio:HBASE-24681

Conversation

@infraio

@infraioinfraio commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

…plicationSourceManager

@Apache-HBase

Apache-HBase commented Jul 6, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 47sHBASE-24666 passed
+1 💚checkstyle1m 8sHBASE-24666 passed
+1 💚spotbugs1m 59sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 21sthe patch passed
-0 ⚠️checkstyle1m 2shbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 10sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 6sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
32m 24s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2019
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 91cf0d917179 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 6, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 19sHBASE-24666 passed
+1 💚compile1m 4sHBASE-24666 passed
+1 💚shadedjars5m 51sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 44shbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚mvninstall3m 59sthe patch passed
+1 💚compile1m 3sthe patch passed
+1 💚javac1m 3sthe patch passed
+1 💚shadedjars5m 44spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit136m 11shbase-server in the patch failed.
162m 18s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2019
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 24549fb1185f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/testReport/
Max. process+thread count4761 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 6, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 2sHBASE-24666 passed
+1 💚compile0m 57sHBASE-24666 passed
+1 💚shadedjars5m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 42sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars6m 1spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 36shbase-server generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28)
_ Other Tests _
-1 ❌unit205m 21shbase-server in the patch failed.
230m 25s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2019
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5464af8faf74 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Default Java1.8.0_232
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/testReport/
Max. process+thread count3916 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 34sHBASE-24666 passed
+1 💚checkstyle1m 7sHBASE-24666 passed
+1 💚spotbugs2m 2sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 21sthe patch passed
+1 💚checkstyle1m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 9sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
35m 5s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2019
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 07fea145f23d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / c294971
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 48sHBASE-24666 passed
+1 💚compile0m 55sHBASE-24666 passed
+1 💚shadedjars5m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 24sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 36shbase-server generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28)
_ Other Tests _
+1 💚unit141m 35shbase-server in the patch passed.
165m 57s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2019
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d9d40903c967 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / c294971
Default Java1.8.0_232
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/testReport/
Max. process+thread count4710 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 47sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall5m 15sHBASE-24666 passed
+1 💚compile1m 15sHBASE-24666 passed
+1 💚shadedjars6m 47sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 46shbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 55sthe patch passed
+1 💚compile1m 28sthe patch passed
+1 💚javac1m 28sthe patch passed
+1 💚shadedjars6m 58spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 45shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit149m 42shbase-server in the patch failed.
180m 36s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2019
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 39aeeeb16c39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / c294971
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/testReport/
Max. process+thread count4455 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 36sHBASE-24666 passed
+1 💚checkstyle1m 3sHBASE-24666 passed
+1 💚spotbugs2m 0sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 25sthe patch passed
+1 💚checkstyle1m 6sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 31sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 44sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
35m 29s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2019
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 6ccdd6a84494 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / c294971
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 34sHBASE-24666 passed
+1 💚compile0m 56sHBASE-24666 passed
+1 💚shadedjars5m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 29sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars5m 34spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit142m 14shbase-server in the patch passed.
166m 16s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2019
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0e1a963ab077 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / c294971
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/testReport/
Max. process+thread count4384 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 10, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 47sHBASE-24666 passed
+1 💚compile1m 10sHBASE-24666 passed
+1 💚shadedjars6m 51sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 46shbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 53sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚shadedjars6m 46spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 45shbase-server in the patch failed.
_ Other Tests _
+1 💚unit224m 27shbase-server in the patch passed.
255m 7s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2019
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 86581908c096 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / c294971
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/testReport/
Max. process+thread count2976 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2019/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Jul 10, 2020
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per HBASE-24666 design doc, ReplicationSourceManager should concern with adding wals to the ReplicationQueueStorage, so could we simply remove some of the methods related with ReplicationSources control, since ReplicationSources are now run from ReplicationServers? Apparently those methods are the only ones using this walsById cache.

@infraio

infraio commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Yes. But I plan to implement it piece by piece and make sure all ut passed, it will be easy for review. Will finish the complete "decouple" in the follow on issues. Meanwhile, I will add a implementation plan section in the design doc. Thanks.

@infraio
infraio merged commit f176191 into apache:HBASE-24666Jul 13, 2020
asfgit pushed a commit that referenced this pull request Jul 13, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
9e8c930
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Jul 21, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
fae9f0c
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Aug 10, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
9c61d14
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Aug 21, 2020
@infraio@ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
76645aa
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 7, 2020
@infraio@ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
940b769
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Sep 8, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
b659616
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Sep 8, 2020
@infraio
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
c8f24d7
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 8, 2020
@infraio@ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
189a72e
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 10, 2020
@infraio@ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
a6e8ec8
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 14, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
d90c20e
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Sep 15, 2020
@infraio@ddupg
HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…
4ec226e
…plicationSourceManager (apache#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 23, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
e2bdc6d
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 24, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
430a813
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit that referenced this pull request Sep 26, 2020
@infraioGuanghao Zhang
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
38acdaa
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 29, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
5646555
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 22, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
25764a3
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit that referenced this pull request Nov 9, 2020
@infraio
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
efbb75c
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit that referenced this pull request Feb 23, 2021
@infraiosunxin
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
b60ec36
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit that referenced this pull request Jul 9, 2021
@infraiosunxin
HBASE-24681Remove the cache walsById/walsByIdRecoveredQueues from Re…
8481d54
…plicationSourceManager (#2019)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@wchevreuil