Skip to content

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t… - #2020

Merged
infraio merged 1 commit into
apache:HBASE-24666from
infraio:HBASE-24682
Jul 8, 2020
Merged

HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…#2020
infraio merged 1 commit into
apache:HBASE-24666from
infraio:HBASE-24682

Conversation

@infraio

@infraioinfraio commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

…o ReplicationSourceManager

@Apache-HBase

Apache-HBase commented Jul 6, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 39sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 22sHBASE-24666 passed
+1 💚checkstyle1m 19sHBASE-24666 passed
+1 💚spotbugs2m 15sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 55sthe patch passed
-0 ⚠️checkstyle1m 17shbase-server: The patch generated 10 new + 4 unchanged - 0 fixed = 14 total (was 4)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 43sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
39m 6s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2020
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux e6d9d63ca70d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 6, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 18sHBASE-24666 passed
+1 💚compile1m 3sHBASE-24666 passed
+1 💚shadedjars5m 44sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 47spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit139m 31shbase-server in the patch passed.
165m 19s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2020
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f82d59bc50d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/testReport/
Max. process+thread count4408 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 6, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 41sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 20sHBASE-24666 passed
+1 💚compile1m 2sHBASE-24666 passed
+1 💚shadedjars6m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars6m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit204m 11shbase-server in the patch passed.
231m 36s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2020
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cfe499f5932b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/testReport/
Max. process+thread count3285 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil approved these changes Jul 7, 2020
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to be in ReplicationSourceManager only. Should go on master branch?

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 52sHBASE-24666 passed
+1 💚checkstyle1m 5sHBASE-24666 passed
+1 💚spotbugs2m 2sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 21sthe patch passed
+1 💚checkstyle1m 4sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 18sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 43sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
35m 19s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2020
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux f42ec51d49fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall3m 53sHBASE-24666 passed
+1 💚compile0m 56sHBASE-24666 passed
+1 💚shadedjars5m 39sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40sHBASE-24666 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 27sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚shadedjars5m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit146m 47shbase-server in the patch passed.
170m 53s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2020
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 31653c0b0a3f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/testReport/
Max. process+thread count3883 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 8, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-24666 Compile Tests _
+1 💚mvninstall4m 44sHBASE-24666 passed
+1 💚compile1m 8sHBASE-24666 passed
+1 💚shadedjars6m 25sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 43shbase-server in HBASE-24666 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile1m 8sthe patch passed
+1 💚javac1m 8sthe patch passed
+1 💚shadedjars6m 26spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit211m 31shbase-server in the patch passed.
240m 37s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2020
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ec4b4acc72db 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-24666 / fe2ae80
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/testReport/
Max. process+thread count3289 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2020/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@infraio

infraio commented Jul 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Makes sense to be in ReplicationSourceManager only. Should go on master branch?

Yes. Now only foucs on feature branch. I thought we can backport it in future.

@infraio
infraio merged commit 8587fb1 into apache:HBASE-24666Jul 8, 2020
asfgit pushed a commit that referenced this pull request Jul 8, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
c294971
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Jul 13, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
1005379
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Jul 21, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
bb9cae1
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Aug 10, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
d45171f
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Sep 8, 2020
@infraio
HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…
57bafbb
…o ReplicationSourceManager (apache#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 14, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
8e1bf74
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 23, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
f54d2ab
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 24, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
9c8d54b
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit that referenced this pull request Sep 26, 2020
@infraioGuanghao Zhang
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
1d4584f
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Sep 29, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
c315e68
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 22, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
7a41a3e
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
infraio added a commit that referenced this pull request Nov 9, 2020
@infraio
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
ee34412
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit that referenced this pull request Feb 23, 2021
@infraiosunxin
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
a62a4b1
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ddupg pushed a commit that referenced this pull request Jul 9, 2021
@infraiosunxin
HBASE-24682Refactor ReplicationSource#addHFileRefs method: move it t…
0c061bc
…o ReplicationSourceManager (#2020)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infraio@Apache-HBase@wchevreuil