Skip to content

HBASE-24404 Support flush a single column family of region - #2032

Merged
wchevreuil merged 4 commits into
apache:masterfrom
bsglz:HBASE-24404
Jul 10, 2020
Merged

HBASE-24404 Support flush a single column family of region#2032
wchevreuil merged 4 commits into
apache:masterfrom
bsglz:HBASE-24404

Conversation

@bsglz

@bsglzbsglz commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 59smaster passed
+1 💚checkstyle2m 0smaster passed
+1 💚spotbugs6m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall3m 40sroot in the patch failed.
-0 ⚠️checkstyle0m 27shbase-client: The patch generated 3 new + 107 unchanged - 0 fixed = 110 total (was 107)
-0 ⚠️rubocop0m 9sThe patch generated 1 new + 339 unchanged - 1 fixed = 340 total (was 340)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck2m 40sThe patch causes 14 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck5m 29sThe patch causes 14 errors with Hadoop v3.2.1.
+1 💚hbaseprotoc2m 17sthe patch passed
+1 💚spotbugs6m 55sthe patch passed
_ Other Tests _
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
38m 52s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2032
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
unameLinux f9027f5e5374 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Jul 7, 2020
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work.

@bsglz

bsglz commented Jul 7, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work.

Flush table was implemented by a different way that through execProcedure(use pv1), i prefer to do it in a separate jira.
BTW, compact table was implemented in client side by iterate all its regions, should flush table go same way?

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall4m 9smaster passed
+1 💚compile2m 54smaster passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 26shbase-client in master failed.
-0 ⚠️javadoc0m 39shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
-1 ❌mvninstall3m 48sroot in the patch failed.
+1 💚compile2m 50sthe patch passed
+1 💚javac2m 50sthe patch passed
+1 💚shadedjars5m 47spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 26shbase-client in the patch failed.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
_ Other Tests _
+1 💚unit0m 58shbase-protocol-shaded in the patch passed.
+1 💚unit1m 10shbase-client in the patch passed.
+1 💚unit132m 0shbase-server in the patch passed.
+1 💚unit7m 19shbase-shell in the patch passed.
173m 31s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2032
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e1e16178f6a7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/testReport/
Max. process+thread count4259 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall4m 5smaster passed
+1 💚compile2m 41smaster passed
+1 💚shadedjars6m 28sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
-1 ❌mvninstall3m 47sroot in the patch failed.
+1 💚compile2m 37sthe patch passed
+1 💚javac2m 37sthe patch passed
+1 💚shadedjars6m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit0m 51shbase-protocol-shaded in the patch passed.
+1 💚unit1m 17shbase-client in the patch passed.
+1 💚unit204m 42shbase-server in the patch passed.
+1 💚unit8m 18shbase-shell in the patch passed.
247m 53s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2032
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9ee445d882a7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
Default Java1.8.0_232
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/testReport/
Max. process+thread count3059 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 20sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 7smaster passed
+1 💚checkstyle2m 59smaster passed
+1 💚spotbugs8m 36smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 51sthe patch passed
-0 ⚠️checkstyle0m 29shbase-client: The patch generated 6 new + 107 unchanged - 0 fixed = 113 total (was 107)
-0 ⚠️rubocop0m 11sThe patch generated 1 new + 339 unchanged - 1 fixed = 340 total (was 340)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 28sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc2m 59sthe patch passed
+1 💚spotbugs9m 8sthe patch passed
_ Other Tests _
+1 💚asflicense0m 52sThe patch does not generate ASF License warnings.
58m 40s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2032
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
unameLinux e56f43de8cdc 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 59smaster passed
+1 💚compile3m 27smaster passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 26shbase-client in master failed.
-0 ⚠️javadoc0m 40shbase-server in master failed.
-0 ⚠️javadoc0m 52shbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile3m 28sthe patch passed
+1 💚javac3m 28sthe patch passed
+1 💚shadedjars5m 49spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 26shbase-client in the patch failed.
-0 ⚠️javadoc0m 41shbase-server in the patch failed.
-0 ⚠️javadoc0m 57shbase-thrift in the patch failed.
_ Other Tests _
+1 💚unit1m 0shbase-protocol-shaded in the patch passed.
+1 💚unit1m 14shbase-client in the patch passed.
+1 💚unit132m 49shbase-server in the patch passed.
+1 💚unit4m 50shbase-thrift in the patch passed.
+1 💚unit7m 23shbase-shell in the patch passed.
182m 9s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2032
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 809f02984641 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/testReport/
Max. process+thread count4496 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall3m 37smaster passed
+1 💚compile2m 58smaster passed
+1 💚shadedjars5m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 27sthe patch passed
+1 💚compile2m 56sthe patch passed
+1 💚javac2m 56sthe patch passed
+1 💚shadedjars5m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 57sthe patch passed
_ Other Tests _
+1 💚unit0m 45shbase-protocol-shaded in the patch passed.
+1 💚unit1m 7shbase-client in the patch passed.
+1 💚unit137m 7shbase-server in the patch passed.
+1 💚unit4m 29shbase-thrift in the patch passed.
+1 💚unit7m 15shbase-shell in the patch passed.
182m 39s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2032
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5d557a1b2e8a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/testReport/
Max. process+thread count4321 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 54smaster passed
+1 💚checkstyle2m 46smaster passed
+1 💚spotbugs7m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 42sthe patch passed
+1 💚checkstyle2m 43sthe patch passed
-0 ⚠️rubocop0m 11sThe patch generated 1 new + 339 unchanged - 1 fixed = 340 total (was 340)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 20sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc2m 47sthe patch passed
+1 💚spotbugs8m 38sthe patch passed
_ Other Tests _
+1 💚asflicense0m 52sThe patch does not generate ASF License warnings.
55m 47s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2032
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop
unameLinux 72273f24a1a7 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 22smaster passed
+1 💚compile2m 57smaster passed
+1 💚shadedjars5m 34sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 23sthe patch passed
+1 💚compile2m 55sthe patch passed
+1 💚javac2m 55sthe patch passed
+1 💚shadedjars5m 30spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 59sthe patch passed
_ Other Tests _
+1 💚unit0m 44shbase-protocol-shaded in the patch passed.
+1 💚unit1m 5shbase-client in the patch passed.
+1 💚unit137m 26shbase-server in the patch passed.
+1 💚unit4m 31shbase-thrift in the patch passed.
+1 💚unit7m 12shbase-shell in the patch passed.
182m 17s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2032
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 65ec6fc217b1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/testReport/
Max. process+thread count4282 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 7, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 16smaster passed
+1 💚compile3m 29smaster passed
+1 💚shadedjars6m 5sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 25shbase-client in master failed.
-0 ⚠️javadoc0m 39shbase-server in master failed.
-0 ⚠️javadoc0m 51shbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 0sthe patch passed
+1 💚compile3m 25sthe patch passed
+1 💚javac3m 26sthe patch passed
+1 💚shadedjars5m 44spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 25shbase-client in the patch failed.
-0 ⚠️javadoc0m 41shbase-server in the patch failed.
-0 ⚠️javadoc0m 49shbase-thrift in the patch failed.
_ Other Tests _
+1 💚unit0m 57shbase-protocol-shaded in the patch passed.
+1 💚unit1m 8shbase-client in the patch passed.
+1 💚unit132m 55shbase-server in the patch passed.
+1 💚unit4m 44shbase-thrift in the patch passed.
+1 💚unit7m 22shbase-shell in the patch passed.
182m 34s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2032
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9c40ff864ec4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 34e807a
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/testReport/
Max. process+thread count3926 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2032/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

wchevreuil commented Jul 8, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to keep separate work.

Flush table was implemented by a different way that through execProcedure(use pv1), i prefer to do it in a separate jira.
BTW, compact table was implemented in client side by iterate all its regions, should flush table go same way?

Indeed, it's more complex than I originally thought. Let's keep discussing it on the other jira. I think this one is good to go, after fixing the latest javadoc issues.

@bsglz

bsglz commented Jul 9, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

The javadoc issues also exist in master, is this a bug of jdk11? See https://bugs.openjdk.java.net/browse/JDK-8212233.

There is a workaround in project commons-pool, can we do as same way?
https://github.com/apache/commons-pool/blob/master/pom.xml

 <profile>
<id>java11+</id>
<activation>
<jdk>[11,)</jdk>
</activation>
<properties>
<!-- Workaround for https://bugs.openjdk.java.net/browse/JDK-8212233
which causes javadoc to fail with "javadoc: error - The code being documented uses modules
but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module." -->
<maven.javadoc.skip>true</maven.javadoc.skip>
</properties>
</profile>

Thanks. @wchevreuil

@bsglz
bsglz requested a review from wchevreuilJuly 10, 2020 02:42
@wchevreuil

wchevreuil commented Jul 10, 2020

Copy link
Copy Markdown
Contributor

The javadoc issues also exist in master, is this a bug of jdk11? See https://bugs.openjdk.java.net/browse/JDK-8212233.

There is a workaround in project commons-pool, can we do as same way?
https://github.com/apache/commons-pool/blob/master/pom.xml

 <profile>
<id>java11+</id>
<activation>
<jdk>[11,)</jdk>
</activation>
<properties>
<!-- Workaround for https://bugs.openjdk.java.net/browse/JDK-8212233
which causes javadoc to fail with "javadoc: error - The code being documented uses modules
but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module." -->
<maven.javadoc.skip>true</maven.javadoc.skip>
</properties>
</profile>

Thanks. @wchevreuil

No, let's leave as it is. Am going to merge it now.

@wchevreuil
wchevreuil merged commit 724f047 into apache:masterJul 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsglz@Apache-HBase@wchevreuil