Skip to content

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r… - #2062

Merged
huaxiangsun merged 1 commit into
apache:masterfrom
huaxiangsun:master.HBASE-24705
Jul 14, 2020
Merged

HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…#2062
huaxiangsun merged 1 commit into
apache:masterfrom
huaxiangsun:master.HBASE-24705

Conversation

@huaxiangsun

@huaxiangsunhuaxiangsun commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

…eplicas (i.e, replica regions are not created)

@Apache-HBase

Apache-HBase commented Jul 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 45smaster passed
+1 💚checkstyle1m 9smaster passed
+1 💚spotbugs1m 56smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 22sthe patch passed
-0 ⚠️checkstyle1m 7shbase-server: The patch generated 6 new + 183 unchanged - 0 fixed = 189 total (was 183)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 5sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 9sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
32m 30s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2062
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 35679cb7b3e1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3bd5421
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 13smaster passed
+1 💚compile1m 2smaster passed
+1 💚shadedjars5m 49sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 43shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 2sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 45spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit129m 42shbase-server in the patch passed.
156m 50s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3526a14bedcc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3bd5421
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/testReport/
Max. process+thread count4627 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 23smaster passed
+1 💚compile0m 57smaster passed
+1 💚shadedjars6m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚shadedjars6m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41sthe patch passed
_ Other Tests _
+1 💚unit141m 28shbase-server in the patch passed.
168m 54s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 534167cdce1b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3bd5421
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/testReport/
Max. process+thread count5095 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Jul 14, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, looks good overall.

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java Outdated
Huaxiang Sun
HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…
f106480
…eplicas (i.e, replica regions are not created)
@huaxiangsun

huaxiangsun commented Jul 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Updated based on the comments.

@Apache-HBase

Apache-HBase commented Jul 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall3m 36smaster passed
+1 💚checkstyle1m 37smaster passed
+1 💚spotbugs2m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
-0 ⚠️checkstyle1m 11shbase-server: The patch generated 5 new + 192 unchanged - 0 fixed = 197 total (was 192)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 6sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 14sthe patch passed
_ Other Tests _
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
36m 45s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2062
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux efd55e27e012 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ee226de
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Jul 14, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase

Apache-HBase commented Jul 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall4m 18smaster passed
+1 💚compile1m 38smaster passed
+1 💚shadedjars6m 4sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 29shbase-client in master failed.
-0 ⚠️javadoc0m 40shbase-server in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile1m 34sthe patch passed
+1 💚javac1m 34sthe patch passed
+1 💚shadedjars6m 4spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 28shbase-client in the patch failed.
-0 ⚠️javadoc0m 48shbase-server in the patch failed.
_ Other Tests _
+1 💚unit1m 24shbase-client in the patch passed.
+1 💚unit149m 5shbase-server in the patch passed.
180m 3s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux daae870bcec7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ee226de
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/testReport/
Max. process+thread count4226 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 14, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall3m 38smaster passed
+1 💚compile1m 23smaster passed
+1 💚shadedjars5m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile1m 21sthe patch passed
+1 💚javac1m 21sthe patch passed
+1 💚shadedjars5m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit1m 6shbase-client in the patch passed.
+1 💚unit160m 19shbase-server in the patch passed.
188m 4s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2062
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2dad1fac49ee 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / ee226de
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/testReport/
Max. process+thread count3750 (vs. ulimit of 12500)
modulesC: hbase-client hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2062/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun
huaxiangsun merged commit 1360bee into apache:masterJul 14, 2020
huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jul 15, 2020
@huaxiangsunHuaxiang Sun
HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…
f3ffed0
…eplicas (i.e, replica regions are not created) (apache#2062)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jul 15, 2020
@huaxiangsunHuaxiang Sun
HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…
179cf68
…eplicas (i.e, replica regions are not created) (apache#2062)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
This was referenced Jul 15, 2020
Merged
Merged
huaxiangsun added a commit that referenced this pull request Jul 15, 2020
@huaxiangsun
HBASE-24705MetaFixer#fixHoles() does not include the case for read r…
0e45e37
…eplicas (i.e, replica regions are not created) (#2062) (#2068)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
huaxiangsun added a commit that referenced this pull request Jul 15, 2020
@huaxiangsun
HBASE-24705MetaFixer#fixHoles() does not include the case for read r…
c73b2b9
…eplicas (i.e, replica regions are not created) (#2062) (#2067)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@huaxiangsun@clarax
HBASE-24705 MetaFixer#fixHoles() does not include the case for read r…
584eb26
…eplicas (i.e, replica regions are not created) (apache#2062) (apache#2068)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huaxiangsun@Apache-HBase@virajjasani