Skip to content

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w… - #2079

Merged
wchevreuil merged 1 commit into
apache:masterfrom
wchevreuil:HBASE-24747
Jul 17, 2020
Merged

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…#2079
wchevreuil merged 1 commit into
apache:masterfrom
wchevreuil:HBASE-24747

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

…ith an uncaught exception

virajjasani
virajjasani approved these changes Jul 17, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
try {
saslServer =
new HBaseSaslRpcServer(provider, rpcServer.saslProps, rpcServer.secretManager);
} catch (Exception e){

@virajjasanivirajjasaniJul 17, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this can be IOException? Exception is also fine though since the purpose is to log any uncaught exceptions.

@wchevreuilwchevreuilJul 17, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the goal here is to catch any uncaught exception that may be thrown by faulty custom providers.

@wchevreuil
wchevreuil merged commit bd42c75 into apache:masterJul 17, 2020
@Apache-HBase

Apache-HBase commented Jul 17, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 34sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 5smaster passed
+1 💚checkstyle1m 13smaster passed
+1 💚spotbugs2m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 47sthe patch passed
+1 💚checkstyle1m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 19sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 14sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
36m 30s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2079
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 665b2603f67a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1781185
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 25smaster passed
+1 💚compile1m 4smaster passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 42shbase-server in master failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars5m 43spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
+1 💚unit130m 56shbase-server in the patch passed.
157m 13s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2079
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 15f5f50b0eec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1781185
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/testReport/
Max. process+thread count4464 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 17, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 3smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars6m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 43sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚shadedjars6m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit203m 49shbase-server in the patch passed.
229m 58s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2079
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4a771f0178f3 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1781185
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/testReport/
Max. process+thread count3652 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil added a commit that referenced this pull request Jul 20, 2020
@wchevreuil
HBASE-24747Log an ERROR if HBaseSaslRpcServer initialisation fails w…
8c89582
…ith an uncaught exception (#2079)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit bd42c75)
wchevreuil added a commit that referenced this pull request Jul 20, 2020
@wchevreuil
HBASE-24747Log an ERROR if HBaseSaslRpcServer initialisation fails w…
e1e68a5
…ith an uncaught exception (#2079)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit bd42c75)
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@wchevreuil@clarax
HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…
7a37b77
…ith an uncaught exception (apache#2079)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit bd42c75)
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@wchevreuil
HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…
0a2c861
…ith an uncaught exception (apache#2079)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Author: Wellington Chevreuil
Reason: Supportability
Ref: CDPD-15248
Change-Id: I78a1c87bea2c6e6a1204a46e0bf6676d5b7f896e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshelserjoshelserjoshelser approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil@Apache-HBase@joshelser@virajjasani