Skip to content

HBASE-24696 Include JVM information on Web UI under "Software Attributes" - #2087

Closed
liuml07 wants to merge 3 commits into
apache:masterfrom
liuml07:HBASE-24696
Closed

HBASE-24696 Include JVM information on Web UI under "Software Attributes"#2087
liuml07 wants to merge 3 commits into
apache:masterfrom
liuml07:HBASE-24696

Conversation

@liuml07

@liuml07liuml07 commented Jul 18, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@Apache-HBase

Apache-HBase commented Jul 18, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall4m 52smaster passed
+1 💚checkstyle2m 25smaster passed
+1 💚spotbugs5m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 34sthe patch passed
+1 💚checkstyle2m 38sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 16sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs5m 48sthe patch passed
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
54m 35s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2087
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux b164c8422e17 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b02a26
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Jul 18, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, looks good otherwise.

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmVersion.java Outdated
* Return the current JVM version information.
*/
public static String getVersion() {
return System.getProperty("java.vm.vendor", "UsNKNOWN_VM_VENDOR") + ' ' +

@virajjasanivirajjasaniJul 18, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo UNKNOWN_VM_VENDOR ?

@Apache-HBase

Apache-HBase commented Jul 18, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall4m 16smaster passed
+1 💚compile2m 15smaster passed
+1 💚shadedjars5m 56sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 22shbase-rest in master failed.
-0 ⚠️javadoc0m 40shbase-server in master failed.
-0 ⚠️javadoc0m 52shbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 8sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚shadedjars6m 14spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 52shbase-server in the patch failed.
-0 ⚠️javadoc1m 8shbase-thrift in the patch failed.
-0 ⚠️javadoc0m 24shbase-rest in the patch failed.
_ Other Tests _
-1 ❌unit148m 8shbase-server in the patch failed.
+1 💚unit5m 5shbase-thrift in the patch passed.
+1 💚unit3m 27shbase-rest in the patch passed.
189m 27s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux dba1d203d7b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b02a26
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/testReport/
Max. process+thread count4094 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 18, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 43smaster passed
+1 💚compile1m 55smaster passed
+1 💚shadedjars5m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars5m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 26sthe patch passed
_ Other Tests _
-1 ❌unit160m 14shbase-server in the patch failed.
+1 💚unit4m 59shbase-thrift in the patch passed.
+1 💚unit3m 22shbase-rest in the patch passed.
197m 12s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9d7a0ba5c276 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b02a26
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/testReport/
Max. process+thread count4095 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 18, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall4m 7smaster passed
+1 💚checkstyle2m 12smaster passed
+1 💚spotbugs4m 23smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 56sthe patch passed
+1 💚checkstyle2m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 42sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs5m 54sthe patch passed
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
47m 16s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2087
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 5d092eac02bd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b02a26
Max. process+thread count85 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 18, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 57smaster passed
+1 💚compile2m 6smaster passed
+1 💚shadedjars5m 44sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in master failed.
-0 ⚠️javadoc0m 49shbase-thrift in master failed.
-0 ⚠️javadoc0m 21shbase-rest in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 0sthe patch passed
+1 💚compile2m 9sthe patch passed
+1 💚javac2m 9sthe patch passed
+1 💚shadedjars5m 45spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 39shbase-server in the patch failed.
-0 ⚠️javadoc0m 49shbase-thrift in the patch failed.
-0 ⚠️javadoc0m 20shbase-rest in the patch failed.
_ Other Tests _
+1 💚unit128m 50shbase-server in the patch passed.
+1 💚unit4m 48shbase-thrift in the patch passed.
+1 💚unit2m 51shbase-rest in the patch passed.
167m 11s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2b0ae9f0451c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b02a26
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/testReport/
Max. process+thread count4537 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 18, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 7smaster passed
+1 💚compile2m 0smaster passed
+1 💚shadedjars6m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 56sthe patch passed
+1 💚compile2m 2sthe patch passed
+1 💚javac2m 2sthe patch passed
+1 💚shadedjars6m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29sthe patch passed
_ Other Tests _
+1 💚unit204m 4shbase-server in the patch passed.
+1 💚unit5m 34shbase-thrift in the patch passed.
+1 💚unit3m 55shbase-rest in the patch passed.
245m 23s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4aba753ef16a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b02a26
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/testReport/
Max. process+thread count3551 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Jul 19, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

ndimiduk
ndimiduk reviewed Jul 20, 2020
View reviewed changes
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmVersion.java
/**
* Return the current JVM version information.
*/
public static String getVersion() {

@ndimidukndimidukJul 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the javadoc in the class header, this is a repurposing of the existing class. I think it's fine to put this method into this class, as the name and location of the class seem like a reasonable place to find this information. Can you update the javadoc on the class header according to the expanded scope of the class?

Otherwise, +1.

@Apache-HBase

Apache-HBase commented Jul 20, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for branch
+1 💚mvninstall3m 53smaster passed
+1 💚checkstyle2m 7smaster passed
+1 💚spotbugs4m 4smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚checkstyle2m 8sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 9sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs4m 38sthe patch passed
_ Other Tests _
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
43m 17s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2087
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 981fdf8221c2 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a857c6d
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 21, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile2m 7smaster passed
+1 💚shadedjars5m 47sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 23shbase-rest in master failed.
-0 ⚠️javadoc0m 40shbase-server in master failed.
-0 ⚠️javadoc0m 52shbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 2sthe patch passed
+1 💚compile2m 7sthe patch passed
+1 💚javac2m 7sthe patch passed
+1 💚shadedjars5m 43spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 41shbase-server in the patch failed.
-0 ⚠️javadoc0m 51shbase-thrift in the patch failed.
-0 ⚠️javadoc0m 20shbase-rest in the patch failed.
_ Other Tests _
+1 💚unit130m 31shbase-server in the patch passed.
+1 💚unit4m 7shbase-thrift in the patch passed.
+1 💚unit3m 14shbase-rest in the patch passed.
169m 24s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9451d1ee7f3b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a857c6d
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/testReport/
Max. process+thread count4325 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 21, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 31sMaven dependency ordering for branch
+1 💚mvninstall4m 30smaster passed
+1 💚compile2m 17smaster passed
+1 💚shadedjars7m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 45smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 23sthe patch passed
+1 💚compile2m 7sthe patch passed
+1 💚javac2m 7sthe patch passed
+1 💚shadedjars6m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 40sthe patch passed
_ Other Tests _
-1 ❌unit147m 56shbase-server in the patch failed.
+1 💚unit5m 2shbase-thrift in the patch passed.
+1 💚unit3m 23shbase-rest in the patch passed.
191m 18s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6f3ed1733217 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a857c6d
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/testReport/
Max. process+thread count4712 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 21, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚checkstyle2m 10smaster passed
+1 💚spotbugs4m 48smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 10sthe patch passed
+1 💚checkstyle2m 15sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 45sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs5m 4sthe patch passed
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
47m 14s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2087
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux f487303a18ba 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 430602a
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 21, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile2m 15smaster passed
+1 💚shadedjars5m 48sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 44shbase-server in master failed.
-0 ⚠️javadoc0m 53shbase-thrift in master failed.
-0 ⚠️javadoc0m 20shbase-rest in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 16sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚shadedjars6m 19spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 51shbase-server in the patch failed.
-0 ⚠️javadoc1m 11shbase-thrift in the patch failed.
-0 ⚠️javadoc0m 23shbase-rest in the patch failed.
_ Other Tests _
+1 💚unit148m 59shbase-server in the patch passed.
+1 💚unit5m 5shbase-thrift in the patch passed.
+1 💚unit3m 12shbase-rest in the patch passed.
190m 1s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux db94ff80c926 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 430602a
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/testReport/
Max. process+thread count3882 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 21, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 29smaster passed
+1 💚compile1m 52smaster passed
+1 💚shadedjars5m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 36sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 26sthe patch passed
_ Other Tests _
+1 💚unit159m 33shbase-server in the patch passed.
+1 💚unit5m 7shbase-thrift in the patch passed.
+1 💚unit3m 27shbase-rest in the patch passed.
196m 26s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2087
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ce1cb607bfd9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 430602a
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/testReport/
Max. process+thread count4106 (vs. ulimit of 12500)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2087/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani pushed a commit that referenced this pull request Jul 21, 2020
@liuml07@virajjasani
HBASE-24696Include JVM information on Web UI under "Software Attribu…
3c91c33
…tes"
Closes#2087
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
virajjasani pushed a commit that referenced this pull request Jul 21, 2020
@liuml07@virajjasani
HBASE-24696Include JVM information on Web UI under "Software Attribu…
965a4a0
…tes"
Closes#2087
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@liuml07liuml07 mentioned this pull request Jul 21, 2020
Closed
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@liuml07@clarax
HBASE-24696 Include JVM information on Web UI under "Software Attribu…
7e36eea
…tes"
Closesapache#2087
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndimidukndimidukndimiduk left review comments
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liuml07@Apache-HBase@ndimiduk@virajjasani