Uh oh!
There was an error while loading. Please reload this page.
HBASE-24740 Enable journal logging for HBase snapshot operation - #2104
Merged
Conversation
Apache-HBase
commented
Jul 20, 2020
🎊 +1 overall
This message was automatically generated. |
sguggilam
commented
Jul 20, 2020
ContributorAuthor
@bharathv Please review and merge |
bharathv
approved these changes
Jul 20, 2020
bharathv
left a comment
Contributor
There was a problem hiding this comment.
A few nits, but lgtm, can commit once fixed. @sguggilam Can you please confirm that you did a quick sanity check on the journal logging? (given there are no tests).
| false); | ||
| } else { | ||
| LOG.debug("Convert to Single Snapshot Manifest"); | ||
| LOG.debug("Convert to Single Snapshot Manifest for " + this.desc.getName()); |
| if (master.getTableStateManager().isTableState(snapshotTable, | ||
| TableState.State.ENABLED)) { | ||
| LOG.debug("Table enabled, starting distributed snapshot."); | ||
| LOG.debug("Table enabled, starting distributed snapshots for {}", |
Contributor
There was a problem hiding this comment.
nit: This still requires the isDebugEnabled() guard because ClientSnapshotDescriptionUtils.toString(..) is not a trivial call.
| else if (master.getTableStateManager().isTableState(snapshotTable, | ||
| TableState.State.DISABLED)) { | ||
| LOG.debug("Table is disabled, running snapshot entirely on master."); | ||
| LOG.debug("Table is disabled, running snapshot entirely on master for {}", |
sguggilam
commented
Jul 21, 2020
ContributorAuthor
Yes @bharathv , tested out the journal log entry and below is the snippet Table snapshot journal : |
bharathv
approved these changes
Jul 21, 2020
bharathv
left a comment
Contributor
There was a problem hiding this comment.
Perfect, thanks. Will merge it once the precommit is green.
Apache-HBase
commented
Jul 21, 2020
💔 -1 overall
This message was automatically generated. |
bharathv pushed a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: Bharath Vissapragada <bharathv@apache.org> (cherry picked from commit 430602a)
bharathv pushed a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: Bharath Vissapragada <bharathv@apache.org> (cherry picked from commit 430602a)
bharathv pushed a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: Bharath Vissapragada <bharathv@apache.org> (cherry picked from commit 430602a)
Apache-HBase
commented
Jul 21, 2020
💔 -1 overall
This message was automatically generated. |
wchevreuil pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.