Skip to content

HBASE-24767 Change default to false for HBASE-15519 per-user metrics - #2132

Merged
saintstack merged 1 commit into
apache:branch-2from
saintstack:HBASE-15519
Aug 3, 2020
Merged

HBASE-24767 Change default to false for HBASE-15519 per-user metrics#2132
saintstack merged 1 commit into
apache:branch-2from
saintstack:HBASE-15519

Conversation

@saintstack

@saintstacksaintstack commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Set hbase.regionserver.user.metrics.enabled default to false; i.e. off.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 15sbranch-2 passed
+1 💚checkstyle1m 17sbranch-2 passed
+1 💚spotbugs2m 16sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 50sthe patch passed
+1 💚checkstyle1m 11sthe patch passed
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚hadoopcheck13m 50sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 18sThe patch does not generate ASF License warnings.
39m 58s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2132
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 1cc7a9178422 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 27sbranch-2 passed
+1 💚compile1m 7sbranch-2 passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 41shbase-server in branch-2 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars7m 5spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 50shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit145m 13shbase-server in the patch failed.
173m 31s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 31acd52d0b43 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/testReport/
Max. process+thread count3573 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 46sbranch-2 passed
+1 💚compile0m 53sbranch-2 passed
+1 💚shadedjars4m 57sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 20sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34sthe patch passed
_ Other Tests _
-1 ❌unit153m 53shbase-server in the patch failed.
177m 4s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8913a5dab25d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/testReport/
Max. process+thread count3296 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet approved these changes Jul 24, 2020
View reviewed changes

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we do the same for the master for now?

@HorizonNet

HorizonNet commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

@saintstack Test failures were related? Seems that the results are not available anymore.

virajjasani
virajjasani approved these changes Jul 24, 2020
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread...e-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserAggregateFactory.java

public static final String METRIC_USER_ENABLED_CONF = "hbase.regionserver.user.metrics.enabled";
public static final boolean DEFAULT_METRIC_USER_ENABLED_CONF = true;
public static final boolean DEFAULT_METRIC_USER_ENABLED_CONF = false;

@virajjasanivirajjasaniJul 24, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have many default constants for multiple configs defined in core code, seems like we are not utilizing hbase-default.xml.
@saintstack it's not related to this PR, but should we have a general guideline to keep config's default values only in hbase-default.xml and not in code?

@saintstacksaintstackJul 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds find if the original config is in hbase-default; this one is not.

We don't have all configs in hbase-default. Too many. Operator would get lost. The boundary between listing in hbase-default or not is not specified unfortunately. A task to do.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 28sbranch-2 passed
+1 💚checkstyle1m 6sbranch-2 passed
+1 💚spotbugs2m 4sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 26sthe patch passed
+1 💚checkstyle1m 7sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 50sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 40sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
36m 38s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2132
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 323de096782a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack

saintstack commented Jul 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews @virajjasani and @HorizonNet (Jan, I push against branch-2 because I know its stable... will forward port to master). Thanks to which ever of you reran the build for me.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 9sbranch-2 passed
+1 💚compile1m 4sbranch-2 passed
+1 💚shadedjars5m 51sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 43shbase-server in branch-2 failed.
_ Patch Compile Tests _
+1 💚mvninstall3m 55sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
+1 💚shadedjars5m 47spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 40shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit125m 56shbase-server in the patch failed.
151m 38s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ecc584630e64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/testReport/
Max. process+thread count4330 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 41sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 52sbranch-2 passed
+1 💚compile1m 20sbranch-2 passed
+1 💚shadedjars6m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 42sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
+1 💚shadedjars5m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
-1 ❌unit211m 33shbase-server in the patch failed.
239m 32s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 24d4f6e63d80 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Default Java1.8.0_232
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/testReport/
Max. process+thread count2519 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 28, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 39sbranch-2 passed
+1 💚checkstyle1m 9sbranch-2 passed
+1 💚spotbugs1m 57sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 9sthe patch passed
+1 💚checkstyle1m 6sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck11m 25sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 6sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
32m 35s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2132
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 220e9fde93b2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 2720a9d
Max. process+thread count94 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/2/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
HBASE-24767 Change default to false for HBASE-15519 per-user metrics …
5e275bb
…Set hbase.regionserver.user.metrics.enabled default to false; i.e. off.
@Apache-HBase

Apache-HBase commented Jul 28, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec32m 21sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall5m 39sbranch-2 passed
+1 💚checkstyle1m 36sbranch-2 passed
+1 💚spotbugs2m 53sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall5m 21sthe patch passed
+1 💚checkstyle1m 39sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 36sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 0sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
80m 52s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2132
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux a129cbf3193a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 2720a9d
Max. process+thread count85 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/3/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 28, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec18m 58sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall5m 13sbranch-2 passed
+1 💚compile1m 16sbranch-2 passed
+1 💚shadedjars7m 35sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 51shbase-server in branch-2 failed.
_ Patch Compile Tests _
+1 💚mvninstall4m 30sthe patch passed
+1 💚compile1m 14sthe patch passed
+1 💚javac1m 14sthe patch passed
+1 💚shadedjars7m 24spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 46shbase-server in the patch failed.
_ Other Tests _
-1 ❌unit8m 15shbase-server in the patch failed.
56m 43s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2132
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 25f520fc6ec6 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ded070
Default Java2020-01-14
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/testReport/
Max. process+thread count1007 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 28, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec49m 56sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 34sbranch-2 passed
+1 💚checkstyle1m 18sbranch-2 passed
+1 💚spotbugs2m 26sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 52sthe patch passed
+1 💚checkstyle1m 17sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck14m 7sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 45sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
90m 28s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2132
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 5ee8ab68599c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ded070
Max. process+thread count95 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/4/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 29, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 18sbranch-2 passed
+1 💚checkstyle1m 20sbranch-2 passed
+1 💚spotbugs2m 29sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 15sthe patch passed
+1 💚checkstyle1m 29sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 18sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 44sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
41m 58s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2132
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 91a08afd4d33 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bba70f0
Max. process+thread count95 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2132/6/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 86d2e37 into apache:branch-2Aug 3, 2020
saintstack added a commit that referenced this pull request Aug 3, 2020
@saintstack
HBASE-24767Change default to false forHBASE-15519per-user metrics …
18d190a
…Set hbase.regionserver.user.metrics.enabled default to false; i.e. off. (#2132)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
saintstack added a commit that referenced this pull request Aug 3, 2020
@saintstack
HBASE-24767Change default to false forHBASE-15519per-user metrics …
21a0b8e
…Set hbase.regionserver.user.metrics.enabled default to false; i.e. off. (#2132)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@saintstack@clarax
HBASE-24767 Change default to false for HBASE-15519 per-user metrics …
b6904f5
…Set hbase.regionserver.user.metrics.enabled default to false; i.e. off. (apache#2132)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HorizonNetHorizonNetHorizonNet approved these changes
@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saintstack@Apache-HBase@HorizonNet@virajjasani