Skip to content

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold - #2136

Merged
virajjasani merged 1 commit into
apache:branch-2from
virajjasani:HBASE-24757-branch-2
Jul 24, 2020
Merged

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold#2136
virajjasani merged 1 commit into
apache:branch-2from
virajjasani:HBASE-24757-branch-2

Conversation

@virajjasani

@virajjasanivirajjasani commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Closes#2127

Signed-off-by: stack stack@apache.org

@virajjasani
HBASE-24757 : ReplicationSink should limit row count in batch mutatio…
be1570a
…n based on hbase.rpc.rows.warning.threshold
Closesapache#2127
Signed-off-by: stack <stack@apache.org>
@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 51sbranch-2 passed
+1 💚checkstyle2m 7sbranch-2 passed
+1 💚spotbugs3m 27sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 17sthe patch passed
+1 💚checkstyle0m 30sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 27shbase-server: The patch generated 0 new + 109 unchanged - 4 fixed = 109 total (was 113)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 30sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs3m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
48m 3s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2136
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 1fc9b14e2907 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Max. process+thread count84 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 27sbranch-2 passed
+1 💚compile1m 17sbranch-2 passed
+1 💚shadedjars5m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 17sthe patch passed
+1 💚compile1m 17sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 56sthe patch passed
_ Other Tests _
+1 💚unit1m 23shbase-common in the patch passed.
+1 💚unit138m 7shbase-server in the patch passed.
164m 10s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2136
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 072fb5f063b1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Default Java1.8.0_232
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/testReport/
Max. process+thread count3964 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 48sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 39sbranch-2 passed
+1 💚compile1m 35sbranch-2 passed
+1 💚shadedjars7m 0sbranch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 20shbase-common in branch-2 failed.
-0 ⚠️javadoc0m 45shbase-server in branch-2 failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 36sthe patch passed
+1 💚compile1m 40sthe patch passed
+1 💚javac1m 40sthe patch passed
+1 💚shadedjars6m 44spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-common in the patch failed.
-0 ⚠️javadoc0m 48shbase-server in the patch failed.
_ Other Tests _
+1 💚unit2m 18shbase-common in the patch passed.
+1 💚unit213m 22shbase-server in the patch passed.
249m 26s
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2136
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3023c2cf86d5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 70ab0dc
Default Java2020-01-14
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/testReport/
Max. process+thread count2572 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2136/1/console
versionsgit=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit 6cb51cc into apache:branch-2Jul 24, 2020
@virajjasani
virajjasani deleted the HBASE-24757-branch-2 branch July 27, 2020 19:41
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@virajjasani@clarax
HBASE-24757 : ReplicationSink should limit row count in batch mutatio…
f32ac40
…n based on hbase.rpc.rows.warning.threshold (apache#2136)
Closesapache#2127
Signed-off-by: stack <stack@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@virajjasani@Apache-HBase