Skip to content

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold - #2139

Merged
virajjasani merged 2 commits into
apache:branch-2.2from
virajjasani:HBASE-24757-branch-2.2
Jul 27, 2020
Merged

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold#2139
virajjasani merged 2 commits into
apache:branch-2.2from
virajjasani:HBASE-24757-branch-2.2

Conversation

@virajjasani

@virajjasanivirajjasani commented Jul 24, 2020

Copy link
Copy Markdown
Contributor

Closes#2127

Signed-off-by: stack stack@apache.org

@virajjasani
HBASE-24757 : ReplicationSink should limit row count in batch mutatio…
d601aee
…n based on hbase.rpc.rows.warning.threshold
Closesapache#2127
Signed-off-by: stack <stack@apache.org>
@Apache-HBase

Apache-HBase commented Jul 24, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall6m 43sbranch-2.2 passed
+1 💚compile1m 38sbranch-2.2 passed
+1 💚checkstyle2m 18sbranch-2.2 passed
+1 💚shadedjars5m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sbranch-2.2 passed
+0 🆗spotbugs4m 20sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 21sbranch-2.2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall6m 16sthe patch passed
+1 💚compile1m 23sthe patch passed
+1 💚javac1m 23sthe patch passed
-1 ❌checkstyle1m 24shbase-server: The patch generated 2 new + 116 unchanged - 4 fixed = 118 total (was 120)
+1 💚whitespace0m 1sThe patch has no whitespace issues.
+1 💚shadedjars4m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck26m 17sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚javadoc0m 57sthe patch passed
+1 💚findbugs4m 20sthe patch passed
_ Other Tests _
+1 💚unit3m 8shbase-common in the patch passed.
-1 ❌unit179m 10shbase-server in the patch failed.
+1 💚asflicense1m 2sThe patch does not generate ASF License warnings.
259m 13s
ReasonTests
Failed junit testshadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/artifact/out/Dockerfile
GITHUB PR#2139
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux fc53b5f6065c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2139/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 8dec49a
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/testReport/
Max. process+thread count4335 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 33sbranch-2.2 passed
+1 💚compile1m 24sbranch-2.2 passed
+1 💚checkstyle2m 0sbranch-2.2 passed
+1 💚shadedjars4m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58sbranch-2.2 passed
+0 🆗spotbugs3m 32sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 21sbranch-2.2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 16sthe patch passed
+1 💚compile1m 24sthe patch passed
+1 💚javac1m 24sthe patch passed
+1 💚checkstyle0m 27sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 32shbase-server: The patch generated 0 new + 116 unchanged - 4 fixed = 116 total (was 120)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck28m 3sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚javadoc0m 56sthe patch passed
+1 💚findbugs4m 39sthe patch passed
_ Other Tests _
+1 💚unit2m 59shbase-common in the patch passed.
-1 ❌unit289m 50shbase-server in the patch failed.
+1 💚asflicense0m 52sThe patch does not generate ASF License warnings.
370m 39s
ReasonTests
Failed junit testshadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/artifact/out/Dockerfile
GITHUB PR#2139
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 25cc8217dcc1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2139/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 8dec49a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/testReport/
Max. process+thread count4940 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 27, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ branch-2.2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall5m 32sbranch-2.2 passed
+1 💚compile1m 20sbranch-2.2 passed
+1 💚checkstyle2m 3sbranch-2.2 passed
+1 💚shadedjars4m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sbranch-2.2 passed
+0 🆗spotbugs3m 31sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 19sbranch-2.2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall5m 10sthe patch passed
+1 💚compile1m 20sthe patch passed
+1 💚javac1m 20sthe patch passed
+1 💚checkstyle0m 26sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 33shbase-server: The patch generated 0 new + 116 unchanged - 4 fixed = 116 total (was 120)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars4m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck28m 5sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚javadoc0m 57sthe patch passed
+1 💚findbugs4m 31sthe patch passed
_ Other Tests _
+1 💚unit3m 0shbase-common in the patch passed.
-1 ❌unit295m 27shbase-server in the patch failed.
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
372m 50s
ReasonTests
Failed junit testshadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.client.TestAdmin1
hadoop.hbase.master.TestAssignmentManagerMetrics
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/artifact/out/Dockerfile
GITHUB PR#2139
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 291e511ef7b5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2139/out/precommit/personality/provided.sh
git revisionbranch-2.2 / 8dec49a
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/testReport/
Max. process+thread count5035 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit 603d2b6 into apache:branch-2.2Jul 27, 2020
@virajjasani
virajjasani deleted the HBASE-24757-branch-2.2 branch July 27, 2020 19:41
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@virajjasani@busbey
HBASE-24757 : ReplicationSink should limit row count in batch mutatio…
7c1bfe9
…n based on hbase.rpc.rows.warning.threshold (apache#2139)
Closesapache#2127
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 603d2b6)
Change-Id: I27416e5ee65bc2cbcb776e7f83487cb2c06e147a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@virajjasani@Apache-HBase