HBASE-22072 High read/write intensive regions may cause long crash by ramkrish86 · Pull Request #214 · apache/hbase

ramkrish86 · 2019-05-03T11:30:45Z

Allows either updateReaders() or close() to happen at the same time. The JIRA reporter has tested the fix provided.

recovery

Apache-HBase · 2019-05-03T14:28:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	21	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	236	master passed
+1	compile	53	master passed
+1	checkstyle	68	master passed
+1	shadedjars	263	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	215	master passed
+1	javadoc	32	master passed
		_ Patch Compile Tests _
+1	mvninstall	232	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
-1	checkstyle	68	hbase-server: The patch generated 1 new + 33 unchanged - 0 fixed = 34 total (was 33)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	262	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	486	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	228	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
+1	unit	8187	hbase-server in the patch passed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		10604

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/1/artifact/out/Dockerfile
GITHUB PR	#214
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2b57849c3013 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0c0d595`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/1/testReport/
Max. process+thread count	4993 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

carp84 · 2019-05-04T15:38:22Z

Please check and fix the checkstyle issue as reported.

The change itself looks good but I need some time to read and fully understand the issue and solution as discussed in HBASE-22072. Will be back once done. Thanks.

anoopsjohn

Pls address the volatile comment and then we are good to go.. I think this will solve many strange issues that we were seeing with the new way of delayed compacted files cleanup. Good one.

standlone class

ramkrish86 · 2019-05-06T12:05:01Z

Made the 'closing' variable to volatile. fixed checkstyle issue and moved the test to a new class.

Apache-HBase · 2019-05-06T14:58:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	21	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	241	master passed
+1	compile	52	master passed
+1	checkstyle	68	master passed
+1	shadedjars	263	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	180	master passed
+1	javadoc	30	master passed
		_ Patch Compile Tests _
+1	mvninstall	236	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	67	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	254	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	492	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	183	the patch passed
+1	javadoc	30	the patch passed
		_ Other Tests _
+1	unit	8170	hbase-server in the patch passed.
+1	asflicense	23	The patch does not generate ASF License warnings.
		10442

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/2/artifact/out/Dockerfile
GITHUB PR	#214
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux acf73fbc5e02 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `45bcb4f`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/2/testReport/
Max. process+thread count	4983 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-214/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

ramkrish86 · 2019-05-07T04:42:44Z

Seems all good now in terms of QA.

anoopsjohn

+1

) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class

…pache#214) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class

…pache#214) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class (cherry picked from commit 8d56693) Change-Id: I3bd6e4f030458516aebe3c7adb96712cbef16b20

HBASE-22072 High read/write intensive regions may cause long crash
5ee18cc
recovery

ramkrish86 self-assigned this May 3, 2019

ramkrish86 requested review from Apache9, carp84, openinx and saintstack May 3, 2019 11:32

Apache9 requested changes May 3, 2019
View reviewed changes

Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java Outdated

anoopsjohn reviewed May 6, 2019
View reviewed changes

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java

anoopsjohn requested changes May 6, 2019
View reviewed changes

Make the 'closing' variable as volatile and move the test case to
851cd9a
standlone class

anoopsjohn approved these changes May 8, 2019
View reviewed changes

ramkrish86 merged commit 46fe983 into apache:masterMay 8, 2019

Navigation Menu

Uh oh!

HBASE-22072 High read/write intensive regions may cause long crash - #214

HBASE-22072 High read/write intensive regions may cause long crash#214
ramkrish86 merged 2 commits into
apache:masterfrom
ramkrish86:mymaster

ramkrish86 commented May 3, 2019

Uh oh!

Apache-HBase commented May 3, 2019

Uh oh!

Uh oh!

carp84 commented May 4, 2019

Uh oh!

Uh oh!

anoopsjohn left a comment

Uh oh!

ramkrish86 commented May 6, 2019

Uh oh!

Apache-HBase commented May 6, 2019

Uh oh!

ramkrish86 commented May 7, 2019

Uh oh!

anoopsjohn left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ramkrish86 commented May 3, 2019

Uh oh!

Apache-HBase commented May 3, 2019

Uh oh!

Uh oh!

carp84 commented May 4, 2019

Uh oh!

Uh oh!

anoopsjohn left a comment

Choose a reason for hiding this comment

Uh oh!

ramkrish86 commented May 6, 2019

Uh oh!

Apache-HBase commented May 6, 2019

Uh oh!

ramkrish86 commented May 7, 2019

Uh oh!

anoopsjohn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants