Skip to content

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold - #2146

Merged
virajjasani merged 2 commits into
apache:branch-1from
virajjasani:HBASE-24757-branch-1
Jul 27, 2020
Merged

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold#2146
virajjasani merged 2 commits into
apache:branch-1from
virajjasani:HBASE-24757-branch-1

Conversation

@virajjasani

Copy link
Copy Markdown
Contributor

Closes#2127

Signed-off-by: stack stack@apache.org

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec12m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 23sMaven dependency ordering for branch
+1 💚mvninstall8m 17sbranch-1 passed
+1 💚compile1m 0sbranch-1 passed with JDK v1.8.0_262
+1 💚compile1m 9sbranch-1 passed with JDK v1.7.0_272
+1 💚checkstyle2m 24sbranch-1 passed
+1 💚shadedjars3m 19sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sbranch-1 passed with JDK v1.8.0_262
+1 💚javadoc1m 4sbranch-1 passed with JDK v1.7.0_272
+0 🆗spotbugs2m 52sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 12sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall2m 7sthe patch passed
+1 💚compile0m 59sthe patch passed with JDK v1.8.0_262
+1 💚javac0m 59sthe patch passed
+1 💚compile1m 9sthe patch passed with JDK v1.7.0_272
+1 💚javac1m 9sthe patch passed
-1 ❌checkstyle1m 49shbase-server: The patch generated 1 new + 194 unchanged - 2 fixed = 195 total (was 196)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars3m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck5m 1sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 50sthe patch passed with JDK v1.8.0_262
+1 💚javadoc1m 4sthe patch passed with JDK v1.7.0_272
+1 💚findbugs4m 26sthe patch passed
_ Other Tests _
+1 💚unit2m 40shbase-common in the patch passed.
-1 ❌unit161m 15shbase-server in the patch failed.
+1 💚asflicense0m 45sThe patch does not generate ASF License warnings.
227m 26s
ReasonTests
Failed junit testshadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.client.TestClientScannerRPCTimeout
SubsystemReport/Notes
DockerClient=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/1/artifact/out/Dockerfile
GITHUB PR#2146
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 52b86cecf32f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2146/out/precommit/personality/provided.sh
git revisionbranch-1 / 527e4a6
Default Java1.7.0_272
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/1/testReport/
Max. process+thread count3903 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
+0 🆗mvndep2m 26sMaven dependency ordering for branch
+1 💚mvninstall9m 4sbranch-1 passed
+1 💚compile0m 59sbranch-1 passed with JDK v1.8.0_262
+1 💚compile1m 9sbranch-1 passed with JDK v1.7.0_272
+1 💚checkstyle2m 12sbranch-1 passed
+1 💚shadedjars3m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sbranch-1 passed with JDK v1.8.0_262
+1 💚javadoc1m 3sbranch-1 passed with JDK v1.7.0_272
+0 🆗spotbugs2m 42sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs4m 0sbranch-1 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall1m 56sthe patch passed
+1 💚compile1m 1sthe patch passed with JDK v1.8.0_262
+1 💚javac1m 1sthe patch passed
+1 💚compile1m 11sthe patch passed with JDK v1.7.0_272
+1 💚javac1m 11sthe patch passed
+1 💚checkstyle0m 27sThe patch passed checkstyle in hbase-common
+1 💚checkstyle1m 43shbase-server: The patch generated 0 new + 194 unchanged - 2 fixed = 194 total (was 196)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚shadedjars2m 50spatch has no errors when building our shaded downstream artifacts.
+1 💚hadoopcheck4m 46sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚javadoc0m 48sthe patch passed with JDK v1.8.0_262
+1 💚javadoc1m 6sthe patch passed with JDK v1.7.0_272
+1 💚findbugs4m 8sthe patch passed
_ Other Tests _
+1 💚unit2m 42shbase-common in the patch passed.
+1 💚unit127m 32shbase-server in the patch passed.
+1 💚asflicense0m 59sThe patch does not generate ASF License warnings.
186m 58s
SubsystemReport/Notes
DockerClient=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/2/artifact/out/Dockerfile
GITHUB PR#2146
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 1632b296df86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2146/out/precommit/personality/provided.sh
git revisionbranch-1 / 527e4a6
Default Java1.7.0_272
Multi-JDK versions/usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/2/testReport/
Max. process+thread count4224 (vs. ulimit of 10000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2146/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered byApache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit dd4417a into apache:branch-1Jul 27, 2020
@virajjasani
virajjasani deleted the HBASE-24757-branch-1 branch July 27, 2020 19:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@virajjasani@Apache-HBase