Uh oh!
There was an error while loading. Please reload this page.
HBASE-24817 Allow configuring WALEntry filters on ReplicationSource - #2198
Merged
Conversation
Apache-HBase
commented
Aug 4, 2020
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 5, 2020
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Aug 5, 2020
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Few minor nits, +1 otherwise
| * the entry to be skipped for replication. | ||
| */ | ||
| public Entry filter(Entry entry); | ||
| Entry filter(Entry entry); |
Contributor
There was a problem hiding this comment.
For system tables we return null Entry. Good to consider return type Optional<Entry> here?
Maybe as follow up task?
ContributorAuthor
There was a problem hiding this comment.
This is how it works now.... no Optional. Will leave it in this patch. Thanks.
| // Test non-system WAL edit. | ||
| WAL.Entry e = new WAL.Entry(new WALKeyImpl(HConstants.EMPTY_BYTE_ARRAY, | ||
| TableName.valueOf("test"), -1), new WALEdit()); | ||
| assertTrue(wef.filter(e) == e); |
Contributor
There was a problem hiding this comment.
nit: just in case if you like assertSame(e, wef.filter(e))
| @Override public void init(Context context) throws IOException { | ||
| this.ctx = context; | ||
| return; |
| if (queueSize > this.logQueueWarnThreshold) { | ||
| LOG.warn("{} WAL group {} queue size: {} exceeds value of " | ||
| + "replication.source.log.queue.warn: {}", logPeerId(), | ||
| + "replication.source.wal.queue.warn: {}", logPeerId(), |
Contributor
There was a problem hiding this comment.
Are we changing this config name also in this patch?
ContributorAuthor
There was a problem hiding this comment.
Good catch. Thanks. Let me restore.
Allow specifying base WALEntry filter on construction of ReplicationSource. Add means of being able to filter WALs by name. hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java Add constructor that allows passing a predicate for filtering *in* WALs and a list of filters for filtering *out* WALEntries. The latter was hardcoded to filter out system-table WALEntries. The former did not exist but we'll need it if Replication takes in more than just the default Provider.
saintstack
commented
Aug 5, 2020
ContributorAuthor
The failures seem unrelated (too many and the few I checked pass locally) |
Apache-HBase
commented
Aug 5, 2020
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
approved these changes
Aug 6, 2020
saintstack added a commit
that referenced
this pull request
Aug 6, 2020
…2198) Allow specifying base WALEntry filter on construction of ReplicationSource. Add means of being able to filter WALs by name. hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java Add constructor that allows passing a predicate for filtering *in* WALs and a list of filters for filtering *out* WALEntries. The latter was hardcoded to filter out system-table WALEntries. The former did not exist but we'll need it if Replication takes in more than just the default Provider. Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…pache#2198) Allow specifying base WALEntry filter on construction of ReplicationSource. Add means of being able to filter WALs by name. hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java Add constructor that allows passing a predicate for filtering *in* WALs and a list of filters for filtering *out* WALEntries. The latter was hardcoded to filter out system-table WALEntries. The former did not exist but we'll need it if Replication takes in more than just the default Provider. Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying base WALEntry filter on construction of
ReplicationSource. Add means of being able to filter WALs by name.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
Add constructor that allows passing a predicate for filtering in WALs
and a list of filters for filtering out WALEntries. The latter was
hardcoded to filter out system-table WALEntries. The former did not
exist but we'll need it if Replication takes in more than just the
default Provider.