Skip to content

HBASE-22358 Change rubocop configuration for method length - #227

Merged
HorizonNet merged 1 commit into
apache:masterfrom
murtazahassan123:HBASE-22358
May 9, 2019
Merged

HBASE-22358 Change rubocop configuration for method length#227
HorizonNet merged 1 commit into
apache:masterfrom
murtazahassan123:HBASE-22358

Conversation

@murtazahassan123

Copy link
Copy Markdown
Contributor

Changed configuration and analyzed the code and the change in configuration works.

@HorizonNetHorizonNet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending QA.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec57Docker mode activated.
_ Prechecks _
0yamllint0yamllint was not available.
+1@author0The patch does not contain any @author tags.
-0test4tests1The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall408master passed
+1javadoc49master passed
_ Patch Compile Tests _
+1mvninstall412the patch passed
+1whitespace0The patch has no whitespace issues.
+1javadoc40the patch passed
_ Other Tests _
+1unit486hbase-shell in the patch passed.
+1asflicense11The patch does not generate ASF License warnings.
2075
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-227/1/artifact/out/Dockerfile
GITHUB PR#227
Optional Testsdupname asflicense javac javadoc unit yamllint
unameLinux d6a6abbd4f30 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 46fe983
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-227/1/testReport/
Max. process+thread count2611 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-227/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
HorizonNet merged commit 600dfae into apache:masterMay 9, 2019
@HorizonNet

Copy link
Copy Markdown
Contributor

Merged to master. Thanks @SyedMurtazaHassan!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@murtazahassan123@Apache-HBase@HorizonNet