Skip to content

HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr… - #229

Merged
z-york merged 1 commit into
apache:branch-1from
z-york:testrevert
May 10, 2019
Merged

HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr…#229
z-york merged 1 commit into
apache:branch-1from
z-york:testrevert

Conversation

@z-york

Copy link
Copy Markdown
Contributor

…operly"

This reverts commit e8e4bea.

@z-york

Copy link
Copy Markdown
ContributorAuthor

Note this will actually cause the new test added in HBASE-21070 in TestSnapshotFileCache to fail until HBASE-22190 is backported (I'm opening a different PR for that). I originally missed that it wasn't backported to branch-1, then when I realized it wasn't, I was confused why the test I added was passing which led me to this.

@z-york

Copy link
Copy Markdown
ContributorAuthor

#230 should be merged first since it will cause test failures otherwise (as mentioned previously)

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec85Docker mode activated.
_ Prechecks _
0findbugs5Findbugs executables are not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+1mvninstall241branch-1 passed
+1compile48branch-1 passed with JDK v1.8.0_212
+1compile44branch-1 passed with JDK v1.7.0_222
+1checkstyle88branch-1 passed
+1shadedjars221branch has no errors when building our shaded downstream artifacts.
+1javadoc47branch-1 passed with JDK v1.8.0_212
+1javadoc45branch-1 passed with JDK v1.7.0_222
_ Patch Compile Tests _
+1mvninstall109the patch passed
+1compile40the patch passed with JDK v1.8.0_212
+1javac40the patch passed
+1compile44the patch passed with JDK v1.7.0_222
+1javac44the patch passed
-1checkstyle82hbase-server: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)
+1whitespace0The patch has no whitespace issues.
+1shadedjars167patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck98Patch does not cause any errors with Hadoop 2.7.4.
+1javadoc29the patch passed with JDK v1.8.0_212
+1javadoc38the patch passed with JDK v1.7.0_222
_ Other Tests _
-1unit7184hbase-server in the patch failed.
+1asflicense25The patch does not generate ASF License warnings.
8746
ReasonTests
Failed junit testshadoop.hbase.master.snapshot.TestSnapshotFileCache
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-229/1/artifact/out/Dockerfile
GITHUB PR#229
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4a8c9b6ca0cd 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-1 / 56548fc
mavenversion: Apache Maven 3.0.5
Default Java1.7.0_222
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-229/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-229/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-229/1/testReport/
Max. process+thread count3672 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-229/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apurtellapurtell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Also approved #230

@z-york

Copy link
Copy Markdown
ContributorAuthor

Reran TestSnapshotFileCache after #230 and confirmed it passes now. Fixed checkstyle.

@z-york
z-york merged commit a66fafb into apache:branch-1May 10, 2019
@z-york
z-york deleted the testrevert branch May 10, 2019 00:19
asfgit pushed a commit that referenced this pull request May 10, 2019
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch9#229 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#229
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-229/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@z-york@Apache-HBase@apurtell