Skip to content

HBASE-22473 Split TestSCP - #253

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22473
May 27, 2019
Merged

HBASE-22473 Split TestSCP#253
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22473

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Override
protected void setupConf(Configuration conf) {
super.setupConf(conf);
conf.setBoolean(HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK, false);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Looks like this wasn't tested before.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no new code here, the only problem is that the test method for killing rs carrying meta is time consuming, so I split them into individual test classes so we do not timeout...

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec40Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 11 new or modified test files.
_ master Compile Tests _
+1mvninstall270master passed
+1compile50master passed
+1checkstyle73master passed
+1shadedjars265branch has no errors when building our shaded downstream artifacts.
+1findbugs166master passed
+1javadoc33master passed
_ Patch Compile Tests _
+1mvninstall246the patch passed
+1compile51the patch passed
+1javac51the patch passed
+1checkstyle72the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars265patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1005Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs168the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit14210hbase-server in the patch failed.
+1asflicense39The patch does not generate ASF License warnings.
17332
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/artifact/out/Dockerfile
GITHUB PR#253
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 92f2e0cee2ac 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 27c02a0
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/testReport/
Max. process+thread count4735 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-253/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 998b841 into apache:masterMay 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@petersomogyi