Skip to content

[HBASE-22476] FSDataInputStream is not closed. - #263

Merged
saintstack merged 2 commits into
apache:masterfrom
q977734161:master
May 30, 2019
Merged

[HBASE-22476] FSDataInputStream is not closed.#263
saintstack merged 2 commits into
apache:masterfrom
q977734161:master

Conversation

@q977734161

@q977734161q977734161 commented May 29, 2019

Copy link
Copy Markdown
Contributor

HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.

李小保
[HBASE-22476] HBase-backup module's class "org.apache.hadoop.hbase.ba…
8840dcd
…ckup.impl.BackupManifest" FSDataInputStream is not close.
@Apache-HBase

Apache-HBase commented May 29, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec28Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall298master passed
+1compile25master passed
+1checkstyle16master passed
+1shadedjars301branch has no errors when building our shaded downstream artifacts.
+1findbugs44master passed
+1javadoc17master passed
_ Patch Compile Tests _
+1mvninstall259the patch passed
+1compile23the patch passed
+1javac23the patch passed
+1checkstyle13the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars283patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1031Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs46the patch passed
+1javadoc15the patch passed
_ Other Tests _
+1unit740hbase-backup in the patch passed.
+1asflicense13The patch does not generate ASF License warnings.
3480
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/artifact/out/Dockerfile
GITHUB PR#263
JIRA IssueHBASE-22476
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 8ec507d3bd24 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 858d30d
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/testReport/
Max. process+thread count4642 (vs. ulimit of 10000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 requested changes May 30, 2019
View reviewed changes
Comment threadhbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java Outdated
long len = subFile.getLen();
byte[] pbBytes = new byte[(int) len];
in.readFully(pbBytes);
in.close();

@Apache9Apache9May 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use the try-with-resources grammar?

@q977734161q977734161May 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh,yes, using the try-with-resources grammar is better. Thanks for reviewing the code.

李小保
[HBASE-22476] HBase-backup module's class "org.apache.hadoop.hbase.ba…
d6f1447
…ckup.impl.BackupManifest" FSDataInputStream is not close.
@Apache-HBase

Apache-HBase commented May 30, 2019

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec190Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1mvninstall273master passed
+1compile22master passed
+1checkstyle16master passed
+1shadedjars261branch has no errors when building our shaded downstream artifacts.
+1findbugs37master passed
+1javadoc16master passed
_ Patch Compile Tests _
+1mvninstall257the patch passed
+1compile25the patch passed
+1javac25the patch passed
+1checkstyle14the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars282patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1046Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1findbugs48the patch passed
+1javadoc17the patch passed
_ Other Tests _
+1unit1297hbase-backup in the patch passed.
+1asflicense12The patch does not generate ASF License warnings.
4142
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/2/artifact/out/Dockerfile
GITHUB PR#263
JIRA IssueHBASE-22476
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 74847f4f4503 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / 1be93fc
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/2/testReport/
Max. process+thread count4643 (vs. ulimit of 10000)
modulesC: hbase-backup U: hbase-backup
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
saintstack merged commit 2823090 into apache:masterMay 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@q977734161@Apache-HBase@Apache9@saintstack