Skip to content

HBASE-22508 Address findbugs/spotbugs complaints (branch-1.3) - #275

Closed
apurtell wants to merge 1 commit into
apache:branch-1.3from
apurtell:HBASE-22508-branch-1.3
Closed

HBASE-22508 Address findbugs/spotbugs complaints (branch-1.3)#275
apurtell wants to merge 1 commit into
apache:branch-1.3from
apurtell:HBASE-22508-branch-1.3

Conversation

@apurtell

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
0reexec1094Docker mode activated.
_ Prechecks _
0findbugs1Findbugs executables are not available.
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
-0test4tests0The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
0mvndep49Maven dependency ordering for branch
+1mvninstall104branch-1.3 passed
+1compile48branch-1.3 passed with JDK v1.8.0_212
+1compile54branch-1.3 passed with JDK v1.7.0_222
+1checkstyle93branch-1.3 passed
+1shadedjars141branch has no errors when building our shaded downstream artifacts.
+1javadoc37branch-1.3 passed with JDK v1.8.0_212
+1javadoc55branch-1.3 passed with JDK v1.7.0_222
_ Patch Compile Tests _
0mvndep12Maven dependency ordering for patch
+1mvninstall100the patch passed
+1compile48the patch passed with JDK v1.8.0_212
+1javac48the patch passed
+1compile55the patch passed with JDK v1.7.0_222
+1javac55the patch passed
+1checkstyle12The patch passed checkstyle in hbase-hadoop2-compat
+1checkstyle78hbase-server: The patch generated 0 new + 420 unchanged - 3 fixed = 420 total (was 423)
+1whitespace0The patch has no whitespace issues.
+1shadedjars139patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck416Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1javadoc38the patch passed with JDK v1.8.0_212
+1javadoc52the patch passed with JDK v1.7.0_222
_ Other Tests _
+1unit29hbase-hadoop2-compat in the patch passed.
+1unit7711hbase-server in the patch passed.
+1asflicense42The patch does not generate ASF License warnings.
10491
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-275/1/artifact/out/Dockerfile
GITHUB PR#275
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux cafc39d84bff 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-1.3 / 911f98c
mavenversion: Apache Maven 3.0.5
Default Java1.7.0_222
Multi-JDK versions/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-275/1/testReport/
Max. process+thread count3838 (vs. ulimit of 10000)
modulesC: hbase-hadoop2-compat hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-275/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apurtell

Copy link
Copy Markdown
ContributorAuthor

Precommit looks good. I'm going to merge this so I can get out the RC. Will wait a few hours if @busbey has any comments

@busbeybusbey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me. I've just been waiting for a chance to run findbugs locally since the QA Bot for PRs doesn't have the stuff it needs for findbugs.

presuming you've already done that I'm good.

@apurtell

Copy link
Copy Markdown
ContributorAuthor

Yes, I used eclipse to run findbugs on the modified compilation units.

asfgit pushed a commit that referenced this pull request Jun 1, 2019
Closes#275
Signed-off-by: Sean Busbey <busbey@apache.org>
@apurtellapurtell closed this Jun 1, 2019
@apurtell
apurtell deleted the HBASE-22508-branch-1.3 branch June 1, 2019 00:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@apurtell@Apache-HBase@busbey