Skip to content

HBASE-25454 Add trace support for connection registry - #2828

Merged
Apache9 merged 1 commit into
apache:HBASE-22120from
Apache9:HBASE-25454
Jan 1, 2021
Merged

HBASE-25454 Add trace support for connection registry#2828
Apache9 merged 1 commit into
apache:HBASE-22120from
Apache9:HBASE-25454

Conversation

@Apache9

@Apache9Apache9 commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Dec 30, 2020
@Apache-HBase

Apache-HBase commented Dec 30, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-22120 Compile Tests _
+1 💚mvninstall3m 50sHBASE-22120 passed
+1 💚compile0m 26sHBASE-22120 passed
+1 💚shadedjars7m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sHBASE-22120 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 35sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars7m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit1m 5shbase-client in the patch passed.
26m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2828
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8d7707adecd9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-22120 / cf3afec
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/testReport/
Max. process+thread count344 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 30, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-22120 Compile Tests _
+1 💚mvninstall4m 21sHBASE-22120 passed
+1 💚compile0m 28sHBASE-22120 passed
+1 💚shadedjars7m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sHBASE-22120 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 4sthe patch passed
+1 💚compile0m 29sthe patch passed
+1 💚javac0m 29sthe patch passed
+1 💚shadedjars7m 4spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 26sthe patch passed
_ Other Tests _
+1 💚unit1m 14shbase-client in the patch passed.
27m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2828
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c88a9fd25ef7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-22120 / cf3afec
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/testReport/
Max. process+thread count287 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 30, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-22120 Compile Tests _
+1 💚mvninstall3m 51sHBASE-22120 passed
+1 💚checkstyle0m 28sHBASE-22120 passed
-1 ❌spotbugs1m 3shbase-client in HBASE-22120 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall3m 39sthe patch passed
-0 ⚠️checkstyle0m 26shbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 40sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs1m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
37m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2828
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 2cb248c3609b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-22120 / cf3afec
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count94 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Dec 31, 2020
View reviewed changes

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Fix the star import on commit.

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java Outdated
package org.apache.hadoop.hbase.client;

import static org.apache.hadoop.hbase.HConstants.MASTER_ADDRS_KEY;
import static org.apache.hadoop.hbase.trace.TraceUtil.*;

@saintstacksaintstackDec 31, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star import.

@Apache-HBase

Apache-HBase commented Dec 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-22120 Compile Tests _
+1 💚mvninstall3m 58sHBASE-22120 passed
+1 💚compile0m 25sHBASE-22120 passed
+1 💚shadedjars7m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sHBASE-22120 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 36sthe patch passed
+1 💚compile0m 27sthe patch passed
+1 💚javac0m 27sthe patch passed
+1 💚shadedjars7m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit1m 5shbase-client in the patch passed.
26m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2828
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 5d0b87a7a03c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-22120 / 8be92b5
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/testReport/
Max. process+thread count339 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 31, 2020

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-22120 Compile Tests _
+1 💚mvninstall4m 24sHBASE-22120 passed
+1 💚compile0m 30sHBASE-22120 passed
+1 💚shadedjars7m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28sHBASE-22120 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile0m 29sthe patch passed
+1 💚javac0m 29sthe patch passed
+1 💚shadedjars7m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
+1 💚unit1m 8shbase-client in the patch passed.
27m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2828
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f79664ba1481 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-22120 / 8be92b5
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/testReport/
Max. process+thread count280 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 31, 2020

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-22120 Compile Tests _
+1 💚mvninstall3m 40sHBASE-22120 passed
+1 💚checkstyle0m 26sHBASE-22120 passed
-1 ❌spotbugs0m 58shbase-client in HBASE-22120 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall3m 26sthe patch passed
+1 💚checkstyle0m 27sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck17m 24sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs1m 9sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
35m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2828
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 4d62be50f7fb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-22120 / 8be92b5
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html
Max. process+thread count94 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2828/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 0ae082b into apache:HBASE-22120Jan 1, 2021
Apache9 added a commit that referenced this pull request Jan 1, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
10c4212
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 5, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
fd463d8
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 7, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
974d86c
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Jan 8, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
122e76b
Signed-off-by: stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Jan 8, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
da95974
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 11, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
a785a1c
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 12, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
4aacac7
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 13, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
7e3e4ad
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 18, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
765a30f
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 21, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
161aab3
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 23, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
4dbc169
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 28, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
a6a6943
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Jan 28, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
9a08087
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Feb 18, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
89efd0e
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Feb 21, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
59682e9
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Feb 25, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
c10c210
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Feb 27, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
217f1ed
Signed-off-by: stack <stack@apache.org>
@searlapatisearlapati mentioned this pull request Feb 27, 2021
Merged
Apache9 added a commit that referenced this pull request Mar 2, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
da4b212
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Mar 8, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
2c5367e
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Mar 10, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
6268a32
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Mar 24, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
7f9a606
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Mar 28, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
1dcad8a
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 2, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
e8cfdd9
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 3, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
5a29b00
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 8, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
c65345b
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 9, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
05863d6
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 15, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
5b7654b
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 24, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
8704b90
Signed-off-by: stack <stack@apache.org>
Apache9 added a commit that referenced this pull request Apr 25, 2021
@Apache9
HBASE-25454Add trace support for connection registry (#2828)
dcb78bd
Signed-off-by: stack <stack@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstacksaintstacksaintstack approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@saintstack