Skip to content

HBASE-24813 ReplicationSource should clear buffer usage on Replicatio… - #2849

Merged
wchevreuil merged 1 commit into
apache:branch-2from
wchevreuil:HBASE-24813-branch-2-reopened
Jan 12, 2021
Merged

HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…#2849
wchevreuil merged 1 commit into
apache:branch-2from
wchevreuil:HBASE-24813-branch-2-reopened

Conversation

@wchevreuil

Copy link
Copy Markdown
Contributor

This a backport for PR #2546 merged into master. The cherry-pick into branch-2 required some conflicts resolution.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 10sbranch-2 passed
+1 💚checkstyle1m 29sbranch-2 passed
+1 💚spotbugs2m 44sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 23sthe patch passed
-0 ⚠️checkstyle1m 27shbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs2m 47sthe patch passed
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
43m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2849
Optional Testsdupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
unameLinux 3e177a1c62b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cec9f18
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count95 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 22sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 29sbranch-2 passed
+1 💚compile1m 10sbranch-2 passed
+1 💚shadedjars7m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 26sthe patch passed
+1 💚compile1m 16sthe patch passed
+1 💚javac1m 16sthe patch passed
+1 💚shadedjars7m 24spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit138m 37shbase-server in the patch passed.
169m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e385bb1f7404 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cec9f18
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/testReport/
Max. process+thread count4373 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 40sbranch-2 passed
+1 💚compile1m 18sbranch-2 passed
+1 💚shadedjars7m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 22sthe patch passed
+1 💚compile1m 11sthe patch passed
+1 💚javac1m 11sthe patch passed
+1 💚shadedjars7m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 47sthe patch passed
_ Other Tests _
+1 💚unit209m 25shbase-server in the patch passed.
241m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#2849
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1536ea91ae89 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / cec9f18
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/testReport/
Max. process+thread count2887 (vs. ulimit of 12500)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2849/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Running tests locally to make sure we don't have a similar problem to last time :)

@joshelser

Copy link
Copy Markdown
Member

Running tests locally to make sure we don't have a similar problem to last time :)

Not observing any run-away logging for replication tests in hbase-server. 👍🏼

@ankitsinghalankitsinghal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wchevreuil
wchevreuil merged commit fdae12d into apache:branch-2Jan 12, 2021
wchevreuil added a commit that referenced this pull request Jan 12, 2021
#2546) (#2849)
Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
wchevreuil added a commit that referenced this pull request Jan 12, 2021
#2546) (#2849)
Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit fdae12d)
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
apache#2546) (apache#2849)
Signed-off-by: Ankit Singhal <ankit@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
(cherry picked from commit fdae12d)
(cherry picked from commit 3242c8a)
Change-Id: I8552da6cb7b37271204e255a6ca96a8af544da48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil@Apache-HBase@joshelser@ankitsinghal