Skip to content

HBASE-22551 TestMasterOperationsForRegionReplicas is flakey - #295

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22551
Jun 9, 2019
Merged

HBASE-22551 TestMasterOperationsForRegionReplicas is flakey#295
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-22551

Conversation

@Apache9

@Apache9Apache9 commented Jun 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

petersomogyi
petersomogyi approved these changes Jun 9, 2019
View reviewed changes
Comment thread...rver/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java

@Test @Ignore("Enable when we have support for alter_table- HBASE-10361")
@Test
@Ignore("Enable when we have support for alter_table- HBASE-10361")

@petersomogyipetersomogyiJun 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but HBASE-10361 has merged ages ago. I will open a JIRA to remove @ignore.

@Apache9Apache9Jun 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me include this in the new patch, just a one line change.

@Apache9Apache9Jun 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the test fails locally for me... Then let's use a new issue to address it...

@petersomogyipetersomogyiJun 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also fails for me and the try block catches the underlying exception from ADMIN.enableTable(tableName);. Better to work on this on a new issue.

@Apache-HBase

Apache-HBase commented Jun 9, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec39Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall264master passed
+1compile53master passed
+1checkstyle75master passed
+1shadedjars279branch has no errors when building our shaded downstream artifacts.
+1findbugs207master passed
+1javadoc33master passed
_ Patch Compile Tests _
+1mvninstall257the patch passed
+1compile55the patch passed
+1javac55the patch passed
-1checkstyle74hbase-server: The patch generated 1 new + 2 unchanged - 3 fixed = 3 total (was 5)
+1whitespace0The patch has no whitespace issues.
+1shadedjars279patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck786Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs220the patch passed
+1javadoc32the patch passed
_ Other Tests _
-1unit13583hbase-server in the patch failed.
+1asflicense26The patch does not generate ASF License warnings.
16600
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/1/artifact/out/Dockerfile
GITHUB PR#295
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5e2b4ed98d33 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / b32e716
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/1/artifact/out/diff-checkstyle-hbase-server.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/1/testReport/
Max. process+thread count4473 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Jun 9, 2019
View reviewed changes
Comment thread...rver/src/test/java/org/apache/hadoop/hbase/master/TestMasterOperationsForRegionReplicas.java
if (ADMIN != null) ADMIN.close();
if (CONNECTION != null && !CONNECTION.isClosed()) CONNECTION.close();
Closeables.close(ADMIN, true);
Closeables.close(CONNECTION, true);

@saintstacksaintstackJun 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice utility...

@Apache-HBase

Apache-HBase commented Jun 9, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec38Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1mvninstall255master passed
+1compile56master passed
+1checkstyle76master passed
+1shadedjars279branch has no errors when building our shaded downstream artifacts.
+1findbugs223master passed
+1javadoc34master passed
_ Patch Compile Tests _
+1mvninstall260the patch passed
+1compile59the patch passed
+1javac59the patch passed
+1checkstyle72hbase-server: The patch generated 0 new + 2 unchanged - 3 fixed = 2 total (was 5)
+1whitespace0The patch has no whitespace issues.
+1shadedjars280patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck791Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1findbugs187the patch passed
+1javadoc33the patch passed
_ Other Tests _
-1unit15186hbase-server in the patch failed.
+1asflicense31The patch does not generate ASF License warnings.
18201
ReasonTests
Failed junit testshadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/2/artifact/out/Dockerfile
GITHUB PR#295
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 90581ffa9676 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionmaster / aab70b5
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/2/testReport/
Max. process+thread count4572 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-295/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 8db9c84 into apache:masterJun 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes
@saintstacksaintstacksaintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@saintstack@petersomogyi