HBASE-25750 Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX) by apurtell · Pull Request #3136 · apache/hbase

apurtell · 2021-04-08T20:50:50Z

Apache Phoenix has had an unrecognized dependency on RpcControllerFactory and HBaseRpcController. These interfaces are used to override setPriority for appropriate dispatch of requests for Phoenix system or index tables to separate pools. This is a reasonable use of these interfaces but the audience annotations were never updated to reflect this usage. Also seems reasonable to do so as there has been no issue here for four years. (Phoenix commit was made in 2017.)

gjacoby126 · 2021-04-08T20:56:57Z

 * Used by client and server ipc'ing.
 */
-@InterfaceAudience.Private
+@InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC, HBaseInterfaceAudience.PHOENIX})


@apurtell - we may want to also add HBaseInterfaceAudience.REPLICATION to the LimitedPrivate annotation. @bharathv and I recently tried to make a custom replication sink implementing the replication API (which I assume counts as Public?), but found we had to downcast RpcController to HBaseRpcController to get at the actual replicated Cells.

@gjacoby126 Updated

Apache-HBase · 2021-04-08T21:19:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 56s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	shadedjars	7m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	7m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 13s	hbase-client in the patch passed.
		27m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3136
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1bf97fae2fd7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f9819f3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/testReport/
Max. process+thread count	342 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-08T21:20:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 31s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	shadedjars	7m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	7m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 17s	hbase-client in the patch passed.
		29m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3136
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 20b4732ffd1f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f9819f3`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/testReport/
Max. process+thread count	305 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-08T21:52:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 15s	master passed
+1 💚	compile	1m 18s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	spotbugs	1m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 38s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	checkstyle	0m 44s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	28m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	1m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		60m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3136
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 57246c8fde03 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f9819f3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…Private to LimitedPrivate(COPROC,PHOENIX)

bharathv

Lgtm

Apache-HBase · 2021-04-08T23:15:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 6s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	7m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	7m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 16s	hbase-client in the patch passed.
		28m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3136
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 233c6b1a8cb8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f9819f3`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/testReport/
Max. process+thread count	300 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-08T23:15:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	7m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	7m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 15s	hbase-client in the patch passed.
		28m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3136
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bf93dd20753e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f9819f3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/testReport/
Max. process+thread count	346 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-04-08T23:29:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 20s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotbugs	1m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 44s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	1m 12s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		42m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3136
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux c051e17b8f01 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f9819f3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3136/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org>

…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java

…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org>

virajjasani

Belated +1

apurtell requested a review from virajjasani April 8, 2021 20:50

gjacoby126 reviewed Apr 8, 2021
View reviewed changes

HBASE-25750 Upgrade RpcControllerFactory and HBaseRpcController from …
ab75c9e
…Private to LimitedPrivate(COPROC,PHOENIX)

apurtell force-pushed the HBASE-25750 branch from 20fdda4 to ab75c9eCompare April 8, 2021 22:45

bharathv approved these changes Apr 8, 2021
View reviewed changes

apurtell merged commit 8ba9034 into apache:masterApr 9, 2021

apurtell deleted the HBASE-25750 branch April 9, 2021 00:52

asfgit pushed a commit that referenced this pull request Apr 9, 2021
HBASE-25750Upgrade RpcControllerFactory and HBaseRpcController from …
3f1269e
…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org>

asfgit pushed a commit that referenced this pull request Apr 9, 2021
HBASE-25750Upgrade RpcControllerFactory and HBaseRpcController from …
98cf9d3
…Private to LimitedPrivate(COPROC,PHOENIX) (#3136) Signed-off-by: Bharath Vissapragada <bharathv@apache.org>

virajjasani reviewed Apr 9, 2021
View reviewed changes

Navigation Menu

Uh oh!

HBASE-25750 Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX) - #3136

HBASE-25750 Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX)#3136
apurtell merged 1 commit into
apache:masterfrom
apurtell:HBASE-25750

apurtell commented Apr 8, 2021

Uh oh!

gjacoby126Apr 8, 2021

Uh oh!

apurtellApr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

bharathv left a comment

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

virajjasani left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

apurtell commented Apr 8, 2021

Uh oh!

gjacoby126Apr 8, 2021

Choose a reason for hiding this comment

Uh oh!

apurtellApr 8, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

bharathv left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

Apache-HBase commented Apr 8, 2021

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants