Uh oh!
There was an error while loading. Please reload this page.
HBASE-25864 Use shaded javax.ws.rs package classes - #3243
Closed
ndimiduk wants to merge 2 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
busbey
commented
May 10, 2021
Contributor
to save other folks a click, the failures in the CI bot are due to the SNAPSHOT dependency on hbase-thirdparty needed to test this out locally. |
apurtell
requested changes
May 10, 2021
| <dependency> | ||
| <groupId>org.apache.hbase</groupId> | ||
| <artifactId>hbase-protocol-shaded</artifactId> | ||
| <type>jar</type> |
Contributor
There was a problem hiding this comment.
This was just redundant, right?
MemberAuthor
There was a problem hiding this comment.
Yes, this was redundant.
From Maven Coordinates,
When no packaging is declared, Maven assumes the packaging is the default: jar.
| */ | ||
| package org.apache.hadoop.hbase.rest.model; | ||
| import com.fasterxml.jackson.annotation.JsonInclude; |
Contributor
There was a problem hiding this comment.
Should be org.apache.hbase.thirdparty.com.fasterxml.jackson...
MemberAuthor
There was a problem hiding this comment.
Nope, because I don't relocate Jackson, just the jackson-jaxrs-json-provider and things related specifically to jaxrs. The other PR uses an includes list, not excludes, and only relocates the package prefix com.fasterxml.jackson.jaxrs. Transitive dependencies of the two artifacts it relocates are preserved.
| import static org.junit.Assert.assertEquals; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; |
Contributor
There was a problem hiding this comment.
We aren't shading jackson-databind? Shouldn't we, if we are shading other jackson packages? jackson.databind has been a source of several CVEs so is definitely something we want to control and keep an eye on.
MemberAuthor
There was a problem hiding this comment.
See above -- it seems we do not currently shade jackson-databind and the patch as posted does not do so either.
ndimiduk
commented
May 11, 2021
MemberAuthor
@apurtell how would you like this change to proceed? Would you prefer that we also shade all of jackson within the
Dependency list from the dependency-reduced-pom.xml |
ndimiduk
commented
May 11, 2021
MemberAuthor
We might also introduce a new shaded jar that is jackson-core, jackson-databind, and jackson-jaxb-annotations. We would then make use of those symbols from the shaded-jackson-jaxrs-json-provider jar, as well as any mentions within hbase-core. |
ndimiduk
commented
May 13, 2021
MemberAuthor
I don't think there's a need to shade jackson here because it is only used by hbase-rest, which is not a module that should land in a downstreamer's classpath. Further, we're making use of jackson via transitive dependency on I would be in support of a plan to deprecate |
ndimiduk
marked this pull request as ready for review
May 18, 2021 23:36
ndimidukforce-pushed
the
25864-shaded-javax.ws.rs
branch
from
August 25, 2021 22:32
f3bea51 to
f9767f5CompareApache-HBase
commented
Aug 25, 2021
Apache-HBase
commented
Aug 25, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 25, 2021
💔 -1 overall
This message was automatically generated. |
apurtell
approved these changes
Sep 3, 2021
ndimidukforce-pushed
the
25864-shaded-javax.ws.rs
branch
from
November 30, 2021 15:20
f9767f5 to
83df996Comparendimiduk
commented
Nov 30, 2021
MemberAuthor
Rebased onto master. |
ndimidukforce-pushed
the
25864-shaded-javax.ws.rs
branch
from
November 30, 2021 15:39
83df996 to
f3889b4CompareApache-HBase
commented
Nov 30, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 30, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 30, 2021
💔 -1 overall
This message was automatically generated. |
ndimiduk
commented
Dec 3, 2021
MemberAuthor
Adapt to the changes provided by apache/hbase-thirdparty#51 Signed-off-by: Andrew Purtell <apurtell@apache.org>
ndimidukforce-pushed
the
25864-shaded-javax.ws.rs
branch
from
December 9, 2021 19:23
f3889b4 to
2fcfd80CompareApache-HBase
commented
Dec 9, 2021
💔 -1 overall
This message was automatically generated. |
apurtell
self-requested a review
December 9, 2021 22:08
Apache-HBase
commented
Dec 10, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 10, 2021
💔 -1 overall
This message was automatically generated. |
ndimiduk
commented
Jan 11, 2022
MemberAuthor
This is superseded by HBASE-26523. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to the changes provided by apache/hbase-thirdparty#51