HBASE-22616 responseTooXXX logging for Multi should characterize the component ops by apurtell · Pull Request #329 · apache/hbase

apurtell · 2019-06-21T21:38:15Z

Multi RPC can be a mix of gets and mutations. The responseTooXXX logging for Multi ops should characterize the operations within the request so we have some clue about whether read or write dispatch was involved.

…component ops

Apache-HBase · 2019-06-22T00:57:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	25	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	248	master passed
+1	compile	50	master passed
+1	checkstyle	64	master passed
+1	shadedjars	249	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	209	master passed
+1	javadoc	33	master passed
		_ Patch Compile Tests _
+1	mvninstall	231	the patch passed
+1	compile	49	the patch passed
+1	javac	49	the patch passed
+1	checkstyle	63	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	247	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	705	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	233	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
+1	unit	9116	hbase-server in the patch passed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		11887

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/1/artifact/out/Dockerfile
GITHUB PR	#329
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b483751bfa24 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `6d08ffc`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/1/testReport/
Max. process+thread count	4635 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-22T00:57:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	23	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	230	master passed
+1	compile	50	master passed
+1	checkstyle	66	master passed
+1	shadedjars	249	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	214	master passed
+1	javadoc	32	master passed
		_ Patch Compile Tests _
+1	mvninstall	231	the patch passed
+1	compile	50	the patch passed
+1	javac	50	the patch passed
+1	checkstyle	63	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	251	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	689	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	223	the patch passed
+1	javadoc	30	the patch passed
		_ Other Tests _
+1	unit	9111	hbase-server in the patch passed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		11848

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/2/artifact/out/Dockerfile
GITHUB PR	#329
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7723fcd7548b 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `6d08ffc`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/2/testReport/
Max. process+thread count	4771 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-329/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd

+1

the-sakthi

+1

…component ops (#329) Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Michael Stack <stack@apache.org>

…component ops (apache#329) Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Michael Stack <stack@apache.org>

…component ops (apache#329) Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Michael Stack <stack@apache.org> (cherry picked from commit 8b22700) Change-Id: I5128202557dd618be2c9d8c7e5bb27f53ce09d62

apurtell changed the title ~~HBASE-22616 responseTooSlow logging for Multi should characterize the component ops~~HBASE-22616 responseTooXXX logging for Multi should characterize the component opsJun 21, 2019

apurtell force-pushed the HBASE-22616 branch from 50c9d36 to 4226ae1Compare June 21, 2019 21:39

HBASE-22616 responseTooXXX logging for Multi should characterize the …
4226ae1
…component ops

Reidddddd approved these changes Jun 22, 2019
View reviewed changes

the-sakthi approved these changes Jun 24, 2019
View reviewed changes

apurtell merged commit 15ac781 into apache:masterJun 25, 2019

apurtell deleted the HBASE-22616 branch June 25, 2019 01:03

asfgit pushed a commit that referenced this pull request Jun 25, 2019
HBASE-22616responseTooXXX logging for Multi should characterize the …
581198e
…component ops (#329) Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Michael Stack <stack@apache.org>

asfgit pushed a commit that referenced this pull request Jun 25, 2019
HBASE-22616responseTooXXX logging for Multi should characterize the …
a1aab95
…component ops (#329) Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Michael Stack <stack@apache.org>

asfgit pushed a commit that referenced this pull request Jun 25, 2019
HBASE-22616responseTooXXX logging for Multi should characterize the …
8b22700
…component ops (#329) Signed-off-by: Reid Chan <reidchan@apache.org> Signed-off-by: Michael Stack <stack@apache.org>

Navigation Menu

Uh oh!

HBASE-22616 responseTooXXX logging for Multi should characterize the component ops - #329

HBASE-22616 responseTooXXX logging for Multi should characterize the component ops#329
apurtell merged 1 commit into
apache:masterfrom
apurtell:HBASE-22616

apurtell commented Jun 21, 2019

Uh oh!

Apache-HBase commented Jun 22, 2019

Uh oh!

Apache-HBase commented Jun 22, 2019

Uh oh!

Reidddddd left a comment

Uh oh!

the-sakthi left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

apurtell commented Jun 21, 2019

Uh oh!

Apache-HBase commented Jun 22, 2019

Uh oh!

Apache-HBase commented Jun 22, 2019

Uh oh!

Reidddddd left a comment

Choose a reason for hiding this comment

Uh oh!

the-sakthi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants