Skip to content

HBASE-22645: Backport HBASE-19893-restore_snapshot is broken in maste… - #349

Closed
the-sakthi wants to merge 1 commit into
apache:branch-2.1from
the-sakthi:hbase-22645
Closed

HBASE-22645: Backport HBASE-19893-restore_snapshot is broken in maste…#349
the-sakthi wants to merge 1 commit into
apache:branch-2.1from
the-sakthi:hbase-22645

Conversation

@the-sakthi

Copy link
Copy Markdown
Member

…r branch when region splits

@the-sakthi

Copy link
Copy Markdown
MemberAuthor

@Apache9 This change reverts some parts of the addendum that was added to fix UT failures after HBASE-21310 & HBASE-21311.

Also, @brfrn169 can I get your review here!

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec172Docker mode activated.
_ Prechecks _
+1hbaseanti0Patch does not have any anti-patterns.
+1@author0The patch does not contain any @author tags.
+1test4tests0The patch appears to include 4 new or modified test files.
_ branch-2.1 Compile Tests _
+1mvninstall304branch-2.1 passed
+1compile66branch-2.1 passed
+1checkstyle93branch-2.1 passed
+1shadedjars304branch has no errors when building our shaded downstream artifacts.
+1findbugs169branch-2.1 passed
+1javadoc40branch-2.1 passed
_ Patch Compile Tests _
+1mvninstall294the patch passed
+1compile68the patch passed
+1javac68the patch passed
+1checkstyle95the patch passed
+1whitespace0The patch has no whitespace issues.
+1shadedjars302patch has no errors when building our shaded downstream artifacts.
+1hadoopcheck1199Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1findbugs171the patch passed
+1javadoc40the patch passed
_ Other Tests _
-1unit13750hbase-server in the patch failed.
+1asflicense30The patch does not generate ASF License warnings.
17473
SubsystemReport/Notes
DockerClient=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/artifact/out/Dockerfile
GITHUB PR#349
JIRA IssueHBASE-22645
Optional Testsdupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux af09c57dc0f3 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/testptch/patchprocess/precommit/personality/provided.sh
git revisionbranch-2.1 / 963cb45
mavenversion: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java1.8.0_181
findbugsv3.1.11
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count4846 (vs. ulimit of 10000)
modulesC: hbase-server U: hbase-server
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169

Copy link
Copy Markdown
Member

+1 LGTM. And it looks like the failed tests in the last QA is unrelated to the patch.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
0reexec0Docker mode activated.
-1patch7#349 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
SubsystemReport/Notes
GITHUB PR#349
JIRA IssueHBASE-22645
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/2/console
Powered byApache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi

Copy link
Copy Markdown
MemberAuthor

The patch went in already in JIRA. Closing this PR

@the-sakthi
the-sakthi deleted the hbase-22645 branch July 12, 2019 21:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@the-sakthi@Apache-HBase@brfrn169