Skip to content

HBASE-26146: Add support for HBASE_HBCK_OPTS - #3534

Merged
saintstack merged 1 commit into
apache:branch-2from
bbeaudreault:hbck_opts
Jul 27, 2021
Merged

HBASE-26146: Add support for HBASE_HBCK_OPTS#3534
saintstack merged 1 commit into
apache:branch-2from
bbeaudreault:hbck_opts

Conversation

@bbeaudreault

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/HBASE-26146

This adds a new env var to the hbase bin, HBASE_HBCK_OPTS. As with other per-command opts, this will get added to HBASE_OPTS last so it will take precedence over previous values.

In order to maintain backwards compatibility with https://issues.apache.org/jira/browse/HBASE-15145, a default value for HBASE_HBCK_OPTS is pulled from AUTH_AS_SERVER_OPTS.

I've tested this on our internal installation of hbase 1 and 2, with HBASE_HBCK_OPTS set and not set. Let me know if there are other tests I should be adding or running as well. I don't see any tests added in the similar patch provided for HBASE-15145.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 9sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3534/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3534
JIRA IssueHBASE-26146
Optional Tests
unameLinux a1ea4a3c51b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / dd22fec
Max. process+thread count46 (vs. ulimit of 12500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3534/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
_ Patch Compile Tests _
+1 💚shellcheck0m 1sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
3m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3534/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3534
JIRA IssueHBASE-26146
Optional Testsdupname asflicense shellcheck shelldocs
unameLinux c194ee5f4bf7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / dd22fec
Max. process+thread count47 (vs. ulimit of 12500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3534/2/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3534/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3534
JIRA IssueHBASE-26146
Optional Tests
unameLinux 9391528bea2b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / dd22fec
Max. process+thread count45 (vs. ulimit of 12500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3534/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saintstack
saintstack merged commit d470b25 into apache:branch-2Jul 27, 2021
saintstack pushed a commit that referenced this pull request Jul 27, 2021
Signed-off-by: stack <stack@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@saintstack