HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util

[petersomogyi]

No description provided.

[Apache9]

For branch-2 only?

[petersomogyi]

For branch-2 only?

Yes. TestShadedHBaseTestingUtility passes on master and branch-2.3. Only fails on branch-2 and branch-2.4.

[apurtell]

Should be fine to add the exclusions to all branches, or not, I have no strong opinion either way. Better to be consistent across all POMs in all branches if possible.

[petersomogyi]

Should be fine to add the exclusions to all branches, or not, I have no strong opinion either way. Better to be consistent across all POMs in all branches if possible.

This pom.xml is already different on the branches. The hadoop-mapreduce-client-app dependency does not require any exclusions on master branch while the shading rule also differs on branch-2.3. Based on this I'd prefer to commit this to branch-2 and branch-2.4 only.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 9s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	5m 39s	branch-2 passed
+1 💚	compile	0m 22s	branch-2 passed
+1 💚	shadedjars	7m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 23s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	8m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 24s	hbase-shaded-testing-util in the patch passed.
		33m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3547
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8bfafa4dc796 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / aa3b07f
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/testReport/
Max. process+thread count	66 (vs. ulimit of 12500)
modules	C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	5m 23s	branch-2 passed
+1 💚	compile	0m 27s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 55s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	18m 16s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
		_ Other Tests _
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		43m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3547
Optional Tests	dupname asflicense javac hadoopcheck xml compile
uname	Linux bd9472167d69 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / aa3b07f
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	69 (vs. ulimit of 12500)
modules	C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	5m 57s	branch-2 passed
+1 💚	compile	0m 30s	branch-2 passed
+1 💚	shadedjars	9m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 29s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	9m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-shaded-testing-util in the patch passed.
		36m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3547
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f19ca6d03ba7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / aa3b07f
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/testReport/
Max. process+thread count	85 (vs. ulimit of 12500)
modules	C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.