Skip to content

HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned - #3565

Closed
bbeaudreault wants to merge 2 commits into
apache:masterfrom
bbeaudreault:max_get_size_master
Closed

HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned#3565
bbeaudreault wants to merge 2 commits into
apache:masterfrom
bbeaudreault:max_get_size_master

Conversation

@bbeaudreault

Copy link
Copy Markdown
Contributor

This is a version of #3532 which applies against master branch. When I created the previous PR I didn't realize the convention of doing master first. That PR did not cleanly apply to master due to changes in hbase-protocol vs hbase-protocol-shaded and minor differences in HRegion.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 14smaster passed
+1 💚compile2m 18smaster passed
+1 💚shadedjars9m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
-1 ❌mvninstall2m 6sroot in the patch failed.
-1 ❌compile0m 49shbase-server in the patch failed.
-0 ⚠️javac0m 49shbase-server in the patch failed.
-1 ❌shadedjars6m 52spatch has 14 errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sthe patch passed
_ Other Tests _
+1 💚unit0m 49shbase-protocol-shaded in the patch passed.
+1 💚unit1m 29shbase-client in the patch passed.
-1 ❌unit0m 47shbase-server in the patch failed.
35m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 00d4ba7301e8 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / da950b9
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/testReport/
Max. process+thread count225 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 3smaster passed
+1 💚compile2m 53smaster passed
+1 💚shadedjars9m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
-1 ❌mvninstall2m 32sroot in the patch failed.
-1 ❌compile0m 57shbase-server in the patch failed.
-0 ⚠️javac0m 57shbase-server in the patch failed.
-1 ❌shadedjars7m 3spatch has 14 errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19sthe patch passed
_ Other Tests _
+1 💚unit1m 4shbase-protocol-shaded in the patch passed.
+1 💚unit1m 40shbase-client in the patch passed.
-1 ❌unit0m 58shbase-server in the patch failed.
38m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b217827c2c58 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / da950b9
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/testReport/
Max. process+thread count212 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 16sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 17smaster passed
+1 💚compile5m 44smaster passed
+1 💚checkstyle1m 56smaster passed
+1 💚spotbugs7m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall2m 3sroot in the patch failed.
-1 ❌compile1m 57shbase-server in the patch failed.
-0 ⚠️cc1m 57shbase-server in the patch failed.
-0 ⚠️javac1m 57shbase-server in the patch failed.
-0 ⚠️checkstyle1m 11shbase-server: The patch generated 6 new + 230 unchanged - 0 fixed = 236 total (was 230)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
-1 ❌hadoopcheck2m 17sThe patch causes 14 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck4m 41sThe patch causes 14 errors with Hadoop v3.2.1.
-1 ❌hadoopcheck7m 3sThe patch causes 14 errors with Hadoop v3.3.0.
-1 ❌hbaseprotoc0m 35shbase-server in the patch failed.
-1 ❌spotbugs0m 31shbase-server in the patch failed.
_ Other Tests _
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
47m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 9893e06c4b5a 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / da950b9
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cchttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 11sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 38smaster passed
+1 💚compile6m 6smaster passed
+1 💚checkstyle1m 54smaster passed
+1 💚spotbugs7m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 25sthe patch passed
+1 💚compile5m 59sthe patch passed
+1 💚cc5m 59sthe patch passed
-0 ⚠️javac0m 57shbase-client generated 1 new + 121 unchanged - 1 fixed = 122 total (was 122)
-0 ⚠️javac3m 28shbase-server generated 2 new + 191 unchanged - 2 fixed = 193 total (was 193)
-0 ⚠️checkstyle1m 14shbase-server: The patch generated 3 new + 230 unchanged - 0 fixed = 233 total (was 230)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck23m 51sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚hbaseprotoc2m 19sthe patch passed
+1 💚spotbugs9m 33sthe patch passed
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
82m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 54ca1b8867c1 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall4m 45smaster passed
+1 💚compile2m 56smaster passed
+1 💚shadedjars9m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile2m 53sthe patch passed
+1 💚javac2m 53sthe patch passed
+1 💚shadedjars9m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit1m 3shbase-protocol-shaded in the patch passed.
+1 💚unit1m 37shbase-client in the patch passed.
-1 ❌unit204m 42shbase-server in the patch failed.
247m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 182e5cdbc46c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/testReport/
Max. process+thread count3613 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 7sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 35smaster passed
+1 💚compile2m 30smaster passed
+1 💚shadedjars9m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 25sthe patch passed
+1 💚compile2m 29sthe patch passed
+1 💚javac2m 29sthe patch passed
+1 💚shadedjars9m 25spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14sthe patch passed
_ Other Tests _
+1 💚unit0m 51shbase-protocol-shaded in the patch passed.
+1 💚unit1m 30shbase-client in the patch passed.
-1 ❌unit219m 52shbase-server in the patch failed.
262m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1bc8326361e6 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/testReport/
Max. process+thread count3015 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 7smaster passed
+1 💚compile5m 45smaster passed
+1 💚checkstyle1m 54smaster passed
+1 💚spotbugs7m 19smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 0sthe patch passed
+1 💚compile5m 45sthe patch passed
+1 💚cc5m 45sthe patch passed
+1 💚javac5m 45sthe patch passed
-0 ⚠️checkstyle1m 14shbase-server: The patch generated 3 new + 230 unchanged - 0 fixed = 233 total (was 230)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 21sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚hbaseprotoc2m 4sthe patch passed
+1 💚spotbugs8m 0sthe patch passed
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
72m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux f5d6a458b2c3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 59sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 5smaster passed
+1 💚compile2m 50smaster passed
+1 💚shadedjars9m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 45sthe patch passed
+1 💚compile2m 50sthe patch passed
+1 💚javac2m 50sthe patch passed
+1 💚shadedjars9m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20sthe patch passed
_ Other Tests _
+1 💚unit1m 2shbase-protocol-shaded in the patch passed.
+1 💚unit1m 38shbase-client in the patch passed.
-1 ❌unit203m 43shbase-server in the patch failed.
246m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 040555e5ffcc 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/testReport/
Max. process+thread count3463 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 29sMaven dependency ordering for branch
+1 💚mvninstall4m 7smaster passed
+1 💚compile2m 18smaster passed
+1 💚shadedjars9m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 8sthe patch passed
+1 💚compile2m 16sthe patch passed
+1 💚javac2m 16sthe patch passed
+1 💚shadedjars9m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 11sthe patch passed
_ Other Tests _
+1 💚unit0m 47shbase-protocol-shaded in the patch passed.
+1 💚unit1m 28shbase-client in the patch passed.
-1 ❌unit217m 9shbase-server in the patch failed.
256m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux adc1867d94c3 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/testReport/
Max. process+thread count3183 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 20smaster passed
+1 💚compile5m 56smaster passed
+1 💚checkstyle1m 53smaster passed
+1 💚spotbugs7m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 8sthe patch passed
+1 💚compile5m 58sthe patch passed
+1 💚cc5m 58sthe patch passed
+1 💚javac5m 58sthe patch passed
-0 ⚠️checkstyle1m 15shbase-server: The patch generated 3 new + 230 unchanged - 0 fixed = 233 total (was 230)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 58sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚hbaseprotoc2m 7sthe patch passed
+1 💚spotbugs7m 56sthe patch passed
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
74m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 1eb07f8d96ff 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 50smaster passed
+1 💚compile2m 11smaster passed
+1 💚shadedjars8m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 17smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile2m 14sthe patch passed
+1 💚javac2m 14sthe patch passed
+1 💚shadedjars8m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 13sthe patch passed
_ Other Tests _
+1 💚unit0m 47shbase-protocol-shaded in the patch passed.
+1 💚unit1m 15shbase-client in the patch passed.
-1 ❌unit151m 2shbase-server in the patch failed.
187m 51s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 29172abf9d7a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/testReport/
Max. process+thread count4078 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 58smaster passed
+1 💚compile2m 50smaster passed
+1 💚shadedjars8m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile2m 52sthe patch passed
+1 💚javac2m 52sthe patch passed
+1 💚shadedjars9m 4spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19sthe patch passed
_ Other Tests _
+1 💚unit1m 2shbase-protocol-shaded in the patch passed.
+1 💚unit1m 37shbase-client in the patch passed.
-1 ❌unit205m 52shbase-server in the patch failed.
248m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 51f89de49551 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c9383f2
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/testReport/
Max. process+thread count3299 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack

Copy link
Copy Markdown
Contributor

Want to make this same as the branch-2 pushed PR @bbeaudreault and then I'll commit (I couldn't forward port the branch-2 PR w/o conflict.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

@saintstack I updated the PR to include the change from branch-2. Also see #3576, with an addendum for branch-2

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall5m 12smaster passed
+1 💚compile2m 43smaster passed
+1 💚shadedjars8m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 24smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 15sthe patch passed
+1 💚compile2m 42sthe patch passed
+1 💚javac2m 42sthe patch passed
+1 💚shadedjars8m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22sthe patch passed
_ Other Tests _
+1 💚unit0m 59shbase-protocol-shaded in the patch passed.
+1 💚unit1m 25shbase-client in the patch passed.
-1 ❌unit11m 40shbase-server in the patch failed.
51m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9023486b4691 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/testReport/
Max. process+thread count1475 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 9sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall4m 14smaster passed
+1 💚compile2m 16smaster passed
+1 💚shadedjars9m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile2m 17sthe patch passed
+1 💚javac2m 17sthe patch passed
+1 💚shadedjars9m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sthe patch passed
_ Other Tests _
+1 💚unit0m 48shbase-protocol-shaded in the patch passed.
+1 💚unit1m 28shbase-client in the patch passed.
-1 ❌unit16m 28shbase-server in the patch failed.
57m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9eeec456c6da 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/testReport/
Max. process+thread count954 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile5m 46smaster passed
+1 💚checkstyle1m 53smaster passed
+1 💚spotbugs7m 19smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile5m 46sthe patch passed
+1 💚cc5m 46sthe patch passed
+1 💚javac5m 46sthe patch passed
-0 ⚠️checkstyle1m 13shbase-server: The patch generated 2 new + 230 unchanged - 0 fixed = 232 total (was 230)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 10sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚hbaseprotoc2m 4sthe patch passed
+1 💚spotbugs8m 3sthe patch passed
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
77m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 9e80e51544a0 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 22sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall4m 4smaster passed
+1 💚compile5m 42smaster passed
+1 💚checkstyle1m 53smaster passed
+1 💚spotbugs7m 22smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile5m 46sthe patch passed
+1 💚cc5m 46sthe patch passed
+1 💚javac5m 46sthe patch passed
-0 ⚠️checkstyle1m 13shbase-server: The patch generated 2 new + 231 unchanged - 0 fixed = 233 total (was 231)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 12sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚hbaseprotoc2m 3sthe patch passed
+1 💚spotbugs8m 7sthe patch passed
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
72m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux e683d7cd3d8f 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/6/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 18smaster passed
+1 💚compile2m 20smaster passed
+1 💚shadedjars9m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 21sthe patch passed
+1 💚compile2m 24sthe patch passed
+1 💚javac2m 24sthe patch passed
+1 💚shadedjars9m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sthe patch passed
_ Other Tests _
+1 💚unit0m 48shbase-protocol-shaded in the patch passed.
+1 💚unit1m 31shbase-client in the patch passed.
+1 💚unit225m 2shbase-server in the patch passed.
265m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2f86b87ab383 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/6/testReport/
Max. process+thread count2916 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 21sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 20smaster passed
+1 💚compile5m 43smaster passed
+1 💚checkstyle1m 55smaster passed
+1 💚spotbugs7m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 4sthe patch passed
+1 💚compile5m 44sthe patch passed
+1 💚cc5m 44sthe patch passed
+1 💚javac5m 44sthe patch passed
-0 ⚠️checkstyle1m 14shbase-server: The patch generated 2 new + 231 unchanged - 0 fixed = 233 total (was 231)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 31sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚hbaseprotoc2m 3sthe patch passed
+1 💚spotbugs7m 56sthe patch passed
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
73m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3565
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 4bef142bf32d 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 55smaster passed
+1 💚compile2m 15smaster passed
+1 💚shadedjars8m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 43sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚shadedjars8m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sthe patch passed
_ Other Tests _
+1 💚unit0m 48shbase-protocol-shaded in the patch passed.
+1 💚unit1m 16shbase-client in the patch passed.
+1 💚unit146m 31shbase-server in the patch passed.
183m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e35a2b31decb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/testReport/
Max. process+thread count3848 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 59smaster passed
+1 💚compile2m 51smaster passed
+1 💚shadedjars9m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 20smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile2m 55sthe patch passed
+1 💚javac2m 55sthe patch passed
+1 💚shadedjars9m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19sthe patch passed
_ Other Tests _
+1 💚unit1m 2shbase-protocol-shaded in the patch passed.
+1 💚unit1m 38shbase-client in the patch passed.
+1 💚unit197m 24shbase-server in the patch passed.
245m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3565
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 225bb8d110c3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e8a269
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/testReport/
Max. process+thread count2620 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3565/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstacksaintstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be doing the suggestion I made of not making a scanner context unless 'needed' (But you found out that we make a scanner context always so my suggestion was of no use). This PR needs updating @bbeaudreault ? Thanks.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Hey @saintstack, sorry I've been distracted by internal stuff the last few work days. But will be getting back to this this week. Yes, this PR needs to be updated based on our convo in the other PR.

@anoopsjohn

Copy link
Copy Markdown
Contributor

Do we really need to add such complexity to Gets?
Get is anyways a special Scan only at server end. Now that we have
scan.withStopRow( byte[] key, boolean inclusive)
Also the openScan can open a scanner session at server and also create results and close and then return (all in one RPC like Get).
Scan next will have both size based and time based checks possible to return partial results.
So when a usage needs to get very large rows, instead of Get, user can use Scan only with all these relevant stuff set on Scan? Just raising for a second thinking.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Thank you for your comment Anoop. The problem we face is that we have hundreds of engineers using hbase in innumerable ways, on multi-tenant clusters. People shift teams, leave, get hired, etc. When you set out to read a row from hbase, you don't always know how large that row will be.

Yes I agree with you, if someone knew they were going to fetch a large row, they should do a Scan. But given the above, people often don't. This new feature acts as a guardrail against causing RegionServer pain in those cases.

The way we've used this feature is we have our own TableFactory that everyone must use to get tables. The returned Table objects are wrapped. When a Get is submitted, the wrapper uses this to limit the max result size. When data is returned, we inspect the Result and throw an exception if it's a partial result.

At that point the user can rewrite their query to use a Scan or add a filter, etc. We also have an escape hatch for urgent issues to allow them to go through, but that is audited.

That said, I just noticed hbase.table.max.rowsize. Surprisingly that was added shortly after our original patch of this and we haven't noticed it since. The default value looks too large, but given we've already been enforcing this I think we might be able to move to that instead.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Given the above and the fact that changes are needed here anyway, I'm going to close this for now while we investigate setting hbase.table.max.rowsize instead. If it doesn't pan out I'll open a new PR with the fixes mentioned.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bbeaudreault@Apache-HBase@saintstack@anoopsjohn