Uh oh!
There was an error while loading. Please reload this page.
HBASE-26284 Add HBase Thrift API to get all table names along with wh… - #3693
Conversation
…ether it is enabled or not
nkalmar
left a comment
There was a problem hiding this comment.
LGTM, original issue is hue dropping too many request because it goes through tables one by one to see if they are enabled or not. This could help this issue by having only 1 thrift api call instead of 1+number of user tables.
Apache-HBase
commented
Sep 21, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 21, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 21, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 22, 2021
💔 -1 overall
This message was automatically generated. |
wchevreuil
left a comment
There was a problem hiding this comment.
The logic looks good to me, just a small nit comment inline. But it seems there are some undesired files probably committed by mistake in this PR:
- test.txt
- There's a bunch of files auto generated by the thrift compiler, can we also remove those from this PR?
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Sep 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 22, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 27, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 27, 2021
💔 -1 overall
This message was automatically generated. |
wchevreuil
commented
Sep 27, 2021
Can we also remove the below generated class from the PR?
|
Apache-HBase
commented
Sep 28, 2021
Apache-HBase
commented
Sep 28, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 28, 2021
💔 -1 overall
This message was automatically generated. |
nkalmar
commented
Oct 4, 2021
Saw previous commits having thrift modification included the generated classes as well. This way we won't have the new API in sync with the committed generated code. (Although why have generated code in the first place - I guess we don't want to force everyone to install Thrift?). |
Apache-HBase
commented
Oct 4, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 4, 2021
💔 -1 overall
This message was automatically generated. |
wchevreuil
commented
Oct 5, 2021
I believe you're right, @nkalmar , and removing those generated classes is what causing the build failures now. @horvathdora , would you mind put those back, so that the build passes? Sorry for having confused you. |
Apache-HBase
commented
Oct 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 5, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 5, 2021
💔 -1 overall
This message was automatically generated. |
wchevreuil
commented
Oct 11, 2021
recheck |
wchevreuil
commented
Oct 11, 2021
Looks fine for me, all UTs and shaded module builds are passing for me locally. |
wchevreuil
commented
Oct 11, 2021
rebuild |
apache#3693) Signed-off-by: Norbert Kalmar <nkalmar@cloudera.com> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apache#3693) (apache#3745) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6d0777a)
…ether it is enabled or not