Skip to content

HBASE-26284 Add HBase Thrift API to get all table names along with wh… - #3693

Merged
wchevreuil merged 5 commits into
apache:masterfrom
horvathdora:master
Oct 11, 2021
Merged

HBASE-26284 Add HBase Thrift API to get all table names along with wh…#3693
wchevreuil merged 5 commits into
apache:masterfrom
horvathdora:master

Conversation

@horvathdora

Copy link
Copy Markdown
Contributor

…ether it is enabled or not

@nkalmarnkalmar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, original issue is hue dropping too many request because it goes through tables one by one to see if they are enabled or not. This could help this issue by having only 1 thrift api call instead of 1+number of user tables.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall4m 15smaster passed
+1 💚compile8m 52smaster passed
+1 💚checkstyle2m 19smaster passed
+1 💚spotbugs13m 8smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile8m 51sthe patch passed
+1 💚javac8m 51sthe patch passed
-0 ⚠️checkstyle2m 17sroot: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
+1 💚hadoopcheck24m 10sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs14m 25sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 37sThe patch generated 1 ASF License warnings.
94m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux b01171777665 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4614c7b
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 22smaster passed
+1 💚compile3m 1smaster passed
+1 💚shadedjars8m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 54smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 13sthe patch passed
+1 💚compile2m 59sthe patch passed
+1 💚javac2m 59sthe patch passed
-1 ❌shadedjars0m 12spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 57sthe patch passed
_ Other Tests _
+1 💚unit183m 40sroot in the patch passed.
219m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 743b0e069a3f 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4614c7b
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/testReport/
Max. process+thread count6332 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 54smaster passed
+1 💚compile2m 38smaster passed
+1 💚shadedjars8m 15sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 38sthe patch passed
+1 💚compile2m 38sthe patch passed
+1 💚javac2m 38sthe patch passed
-1 ❌shadedjars0m 11spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc2m 59sthe patch passed
_ Other Tests _
-1 ❌unit370m 6sroot in the patch failed.
401m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a80e5492d662 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4614c7b
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/testReport/
Max. process+thread count5278 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall5m 34smaster passed
+1 💚compile11m 28smaster passed
+1 💚checkstyle2m 46smaster passed
+1 💚spotbugs14m 17smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 9sthe patch passed
+1 💚compile8m 51sthe patch passed
+1 💚javac8m 51sthe patch passed
-0 ⚠️checkstyle2m 16sroot: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
+1 💚hadoopcheck20m 13sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs13m 54sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 36sThe patch generated 1 ASF License warnings.
95m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 14c63fca34d6 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e6508f6
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, just a small nit comment inline. But it seems there are some undesired files probably committed by mistake in this PR:

  1. test.txt
  2. There's a bunch of files auto generated by the thrift compiler, can we also remove those from this PR?

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 24sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 2smaster passed
+1 💚compile3m 21smaster passed
+1 💚shadedjars9m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile3m 25sthe patch passed
+1 💚javac3m 25sthe patch passed
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc4m 28sthe patch passed
_ Other Tests _
+1 💚unit262m 54sroot in the patch passed.
303m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3b3955553670 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e6508f6
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/testReport/
Max. process+thread count4299 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 3sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 4smaster passed
+1 💚compile2m 52smaster passed
+1 💚shadedjars9m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 6smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 4sthe patch passed
+1 💚compile2m 52sthe patch passed
+1 💚javac2m 52sthe patch passed
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 5sthe patch passed
_ Other Tests _
-1 ❌unit366m 26sroot in the patch failed.
405m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 635fa87b548c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e6508f6
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/testReport/
Max. process+thread count3392 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile8m 55smaster passed
+1 💚checkstyle2m 17smaster passed
+1 💚spotbugs13m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile8m 49sthe patch passed
+1 💚javac8m 49sthe patch passed
-0 ⚠️checkstyle2m 18sroot: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
+1 💚hadoopcheck20m 17sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs13m 53sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 34sThe patch generated 1 ASF License warnings.
89m 16s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 2d69674ad3d9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 2smaster passed
+1 💚compile3m 22smaster passed
+1 💚shadedjars9m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall4m 52sthe patch passed
+1 💚compile3m 24sthe patch passed
+1 💚javac3m 24sthe patch passed
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc4m 31sthe patch passed
_ Other Tests _
+1 💚unit260m 29sroot in the patch passed.
299m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 47f4e76605f9 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/testReport/
Max. process+thread count4230 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 54smaster passed
+1 💚compile2m 38smaster passed
+1 💚shadedjars8m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 38sthe patch passed
+1 💚compile2m 37sthe patch passed
+1 💚javac2m 37sthe patch passed
-1 ❌shadedjars0m 12spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc2m 59sthe patch passed
_ Other Tests _
-1 ❌unit333m 38sroot in the patch failed.
364m 33s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 06c31958366e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/testReport/
Max. process+thread count4473 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 9smaster passed
+1 💚compile10m 9smaster passed
+1 💚checkstyle2m 33smaster passed
+1 💚spotbugs15m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 22sthe patch passed
+1 💚compile11m 29sthe patch passed
+1 💚javac11m 29sroot generated 0 new + 1633 unchanged - 1 fixed = 1633 total (was 1634)
-0 ⚠️checkstyle2m 51sroot: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
+1 💚hadoopcheck27m 20sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs18m 18sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 44sThe patch generated 1 ASF License warnings.
113m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 834a0ef5d133 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count127 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 3smaster passed
+1 💚compile3m 28smaster passed
+1 💚shadedjars9m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile3m 21sthe patch passed
+1 💚javac3m 21sthe patch passed
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc4m 29sthe patch passed
_ Other Tests _
+1 💚unit263m 24sroot in the patch passed.
302m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2f39934fb2f8 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/testReport/
Max. process+thread count4533 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile2m 50smaster passed
+1 💚shadedjars9m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 8sthe patch passed
+1 💚compile2m 56sthe patch passed
+1 💚javac2m 56sthe patch passed
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 3sthe patch passed
_ Other Tests _
+1 💚unit434m 16sroot in the patch passed.
468m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9e3cae47b628 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/testReport/
Max. process+thread count4039 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

Copy link
Copy Markdown
Contributor

Can we also remove the below generated class from the PR?

hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall4m 12smaster passed
+1 💚compile8m 49smaster passed
+1 💚checkstyle2m 16smaster passed
+1 💚spotbugs13m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall3m 50sroot in the patch failed.
-1 ❌compile7m 10sroot in the patch failed.
-0 ⚠️javac7m 10sroot in the patch failed.
-0 ⚠️checkstyle2m 16sroot: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
-1 ❌hadoopcheck2m 56sThe patch causes 14 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck5m 55sThe patch causes 14 errors with Hadoop v3.2.1.
-1 ❌hadoopcheck8m 55sThe patch causes 14 errors with Hadoop v3.3.0.
-1 ❌spotbugs0m 22shbase-thrift in the patch failed.
-1 ❌spotbugs0m 22shbase-examples in the patch failed.
-1 ❌spotbugs8m 40sroot in the patch failed.
_ Other Tests _
-1 ❌asflicense0m 32sThe patch generated 1 ASF License warnings.
64m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux ed4d9ea67a70 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-compile-root.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/whitespace-tabs.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-examples.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-spotbugs-root.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 1smaster passed
+1 💚compile3m 24smaster passed
+1 💚shadedjars9m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall4m 27sroot in the patch failed.
-1 ❌compile2m 45sroot in the patch failed.
-0 ⚠️javac2m 45sroot in the patch failed.
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc4m 30sthe patch passed
_ Other Tests _
-1 ❌unit259m 52sroot in the patch failed.
297m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d5c1aa674911 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/testReport/
Max. process+thread count4211 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 20smaster passed
+1 💚compile2m 50smaster passed
+1 💚shadedjars8m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 6smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall3m 49sroot in the patch failed.
-1 ❌compile2m 11sroot in the patch failed.
-0 ⚠️javac2m 11sroot in the patch failed.
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 6sthe patch passed
_ Other Tests _
-1 ❌unit429m 16sroot in the patch failed.
461m 59s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b67770246371 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cbebf85
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/testReport/
Max. process+thread count4023 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@nkalmar

Copy link
Copy Markdown
Contributor

Saw previous commits having thrift modification included the generated classes as well. This way we won't have the new API in sync with the committed generated code. (Although why have generated code in the first place - I guess we don't want to force everyone to install Thrift?).
Anyway, generated code removed, PTAL @wchevreuil

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall4m 10smaster passed
+1 💚compile8m 52smaster passed
+1 💚checkstyle2m 18smaster passed
+1 💚spotbugs13m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall3m 50sroot in the patch failed.
-1 ❌compile7m 6sroot in the patch failed.
-0 ⚠️javac7m 6sroot in the patch failed.
-0 ⚠️checkstyle2m 18sroot: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
-1 ❌hadoopcheck2m 58sThe patch causes 14 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck5m 59sThe patch causes 14 errors with Hadoop v3.2.1.
-1 ❌hadoopcheck9m 4sThe patch causes 14 errors with Hadoop v3.3.0.
-1 ❌spotbugs0m 22shbase-thrift in the patch failed.
-1 ❌spotbugs0m 23shbase-examples in the patch failed.
-1 ❌spotbugs8m 38sroot in the patch failed.
_ Other Tests _
-1 ❌asflicense0m 32sThe patch generated 1 ASF License warnings.
64m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux e57a15b85017 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f65b769
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-compile-root.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/whitespace-tabs.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-examples.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-spotbugs-root.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 18smaster passed
+1 💚compile3m 33smaster passed
+1 💚shadedjars9m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 30smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall4m 30sroot in the patch failed.
-1 ❌compile2m 47sroot in the patch failed.
-0 ⚠️javac2m 47sroot in the patch failed.
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc4m 24sthe patch passed
_ Other Tests _
-1 ❌unit261m 3sroot in the patch failed.
299m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 99a446cdae92 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f65b769
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/testReport/
Max. process+thread count4139 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

Copy link
Copy Markdown
Contributor

Saw previous commits having thrift modification included the generated classes as well. This way we won't have the new API in sync with the committed generated code. (Although why have generated code in the first place - I guess we don't want to force everyone to install Thrift?). Anyway, generated code removed, PTAL @wchevreuil

I believe you're right, @nkalmar , and removing those generated classes is what causing the build failures now. @horvathdora , would you mind put those back, so that the build passes? Sorry for having confused you.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall4m 7smaster passed
+1 💚compile8m 46smaster passed
+1 💚checkstyle2m 16smaster passed
+1 💚spotbugs13m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile8m 51sthe patch passed
+1 💚javac8m 51sroot generated 0 new + 1633 unchanged - 1 fixed = 1633 total (was 1634)
-0 ⚠️checkstyle2m 22sroot: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️whitespace0m 0sThe patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️whitespace0m 0sThe patch 153 line(s) with tabs.
+1 💚hadoopcheck20m 11sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs13m 52sthe patch passed
_ Other Tests _
-1 ❌asflicense0m 34sThe patch generated 1 ASF License warnings.
89m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3693
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 631f3f83ac72 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f65b769
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/whitespace-eol.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count126 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 47sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall5m 49smaster passed
+1 💚compile3m 57smaster passed
+1 💚shadedjars9m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 39smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 59sthe patch passed
+1 💚compile3m 26sthe patch passed
+1 💚javac3m 26sthe patch passed
-1 ❌shadedjars0m 10spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc4m 30sthe patch passed
_ Other Tests _
+1 💚unit262m 12sroot in the patch passed.
304m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7a824cbfd4ee 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f65b769
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/testReport/
Max. process+thread count4231 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 56smaster passed
+1 💚compile2m 38smaster passed
+1 💚shadedjars8m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 43sthe patch passed
+1 💚compile2m 34sthe patch passed
+1 💚javac2m 34sthe patch passed
-1 ❌shadedjars0m 11spatch has 7 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 2sthe patch passed
_ Other Tests _
-1 ❌unit359m 26sroot in the patch failed.
391m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3693
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 92bcd812b04c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f65b769
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/testReport/
Max. process+thread count5596 (vs. ulimit of 30000)
modulesC: hbase-thrift hbase-examples . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil

Copy link
Copy Markdown
Contributor

recheck

@wchevreuil

Copy link
Copy Markdown
Contributor

Looks fine for me, all UTs and shaded module builds are passing for me locally.

@wchevreuil

Copy link
Copy Markdown
Contributor

rebuild

@wchevreuil
wchevreuil merged commit ce44e16 into apache:masterOct 11, 2021
horvathdora added a commit to horvathdora/hbase that referenced this pull request Oct 12, 2021
apache#3693)
Signed-off-by: Norbert Kalmar <nkalmar@cloudera.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Oct 18, 2021
#3693) (#3745)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Oct 18, 2021
#3693) (#3745)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 6d0777a)
wchevreuil pushed a commit that referenced this pull request Oct 18, 2021
#3693) (#3745)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 6d0777a)
wchevreuil pushed a commit that referenced this pull request Oct 28, 2021
#3693) (#3745)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
apache#3693) (apache#3745)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 6d0777a)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@horvathdora@Apache-HBase@wchevreuil@nkalmar