Skip to content

HBASE-26512 Make timestamp format configurable in HBase shell scan ou… - #3894

Closed
stoty wants to merge 1 commit into
apache:masterfrom
stoty:HBASE-26512
Closed

HBASE-26512 Make timestamp format configurable in HBase shell scan ou…#3894
stoty wants to merge 1 commit into
apache:masterfrom
stoty:HBASE-26512

Conversation

@stoty

Copy link
Copy Markdown
Contributor

…tput

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile0m 51smaster passed
+1 💚shadedjars10m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 28sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚shadedjars8m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit1m 53shbase-common in the patch passed.
+1 💚unit7m 3shbase-shell in the patch passed.
42m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3894
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d2866511069f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f108997
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/testReport/
Max. process+thread count2334 (vs. ulimit of 30000)
modulesC: hbase-common hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall5m 24smaster passed
+1 💚compile0m 51smaster passed
+1 💚shadedjars9m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall5m 45sthe patch passed
+1 💚compile0m 59sthe patch passed
+1 💚javac0m 59sthe patch passed
+1 💚shadedjars9m 36spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit2m 19shbase-common in the patch passed.
+1 💚unit8m 7shbase-shell in the patch passed.
46m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3894
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4c7cc7119115 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f108997
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/testReport/
Max. process+thread count1670 (vs. ulimit of 30000)
modulesC: hbase-common hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall5m 17smaster passed
+1 💚compile1m 32smaster passed
+1 💚checkstyle0m 43smaster passed
+1 💚spotbugs1m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 2sthe patch passed
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
+1 💚checkstyle0m 45sthe patch passed
-0 ⚠️rubocop0m 7sThe patch generated 6 new + 130 unchanged - 2 fixed = 136 total (was 132)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck24m 53sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs1m 11sthe patch passed
_ Other Tests _
+1 💚asflicense0m 27sThe patch does not generate ASF License warnings.
54m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3894
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
unameLinux 83aa4cfb83bc 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f108997
Default JavaAdoptOpenJDK-1.8.0_282-b08
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelser

Copy link
Copy Markdown
Member

Also, fyi @cuibo01 since you had made the change in #2351

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and to the point. Defaults to the human-readable timestamp. Looks great to me.

Will give Stack, Bo, and others a chance to comment since coming off a holiday week.

@joshelser

Copy link
Copy Markdown
Member

Just ran this in pseudo-local mode and it looks good to me. Pushing.

@joshelser

Copy link
Copy Markdown
Member

Merged this into master, branch-2, and branch-2.4

@tomerr90

Copy link
Copy Markdown

Apologies if thats not the place for that, been trying to set it for a specific session of hbase shell (using HBASE_OPTS, and some other methods) and couldnt get it to work, where am I supposed to set it?

@petersomogyi

Copy link
Copy Markdown
Contributor

@tomerr90 Try staring the HBase shell with the -Dconfig=value parameter instead.

hbase shell -Dhbase.shell.timestamp.format.epoch=true

@tomerr90

Copy link
Copy Markdown

I can swear I tried it and it didnt, but works now...
Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@stoty@Apache-HBase@joshelser@tomerr90@petersomogyi