Uh oh!
There was an error while loading. Please reload this page.
HBASE-26616 Refactor code related to ZooKeeper authentication - #3973
Conversation
This comment has been minimized.
This comment has been minimized.
Apache9
left a comment
There was a problem hiding this comment.
So is this related to how we want to implement tracing?
ndimiduk
commented
Dec 23, 2021
No sir. I have taken some time aside this week to learn a tool called Structure101, hoping that I can use it to find parts of our code that are unnecessarily complex, and untangle them. These two ZooKeeper -related refactors (and others, presuming i spend more time on it tomorrow) are not related to tracing, but to general improvement of the health and well-being of our source code. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
af857d1 to
ea97e1eCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache-HBase
commented
Jan 6, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 6, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 6, 2022
💔 -1 overall
This message was automatically generated. |
ndimiduk
commented
Jan 7, 2022
ErrorProne parsing is still broken -- those javac failures are in files I did not touch.
|
Apache9
commented
Jan 7, 2022
The error prone output is not very stable, so typically warnings should be fine, but if it fails the compilation then we still need to take care of it. |
…#3973) This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…#3973) This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…#3973) This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…#3973) This refactor reduces the size and scope of the `ZKUtil` class. The core of this refactor is moving the `login*` methods from `ZKUtil` into their own class, `ZKAuthentication`. The class `JaasConfiguration` is also moved along with them. Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 87e0554) Change-Id: I611fc4a3bcbcd31049449eb352550e6c5364b86c
This refactor reduces the size and scope of the
ZKUtilclass. The core of this refactor ismoving the
login*methods fromZKUtilinto their own class,ZKAuthentication. The classJaasConfigurationis also moved along with them.