Skip to content

HBASE-26590 Hbase-client Meta lookup performance regression between h… - #4008

Merged
huaxiangsun merged 1 commit into
apache:branch-2from
huaxiangsun:branch-2.HBASE-26590
Jan 6, 2022
Merged

HBASE-26590 Hbase-client Meta lookup performance regression between h…#4008
huaxiangsun merged 1 commit into
apache:branch-2from
huaxiangsun:branch-2.HBASE-26590

Conversation

@huaxiangsun

@huaxiangsunhuaxiangsun commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

…base-1 and hbase-2

Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.

Huaxiang Sun
HBASE-26590 Hbase-client Meta lookup performance regression between h…
1427687
…base-1 and hbase-2
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
@Apache-HBase

Apache-HBase commented Jan 5, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 37sbranch-2 passed
+1 💚compile0m 33sbranch-2 passed
+1 💚shadedjars7m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 14sthe patch passed
+1 💚compile0m 33sthe patch passed
+1 💚javac0m 33sthe patch passed
+1 💚shadedjars7m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 30sthe patch passed
_ Other Tests _
+1 💚unit2m 45shbase-client in the patch passed.
30m 27s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4008
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6beb72b659dd 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 755b3b4
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/testReport/
Max. process+thread count301 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 5, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 52sbranch-2 passed
+1 💚compile1m 8sbranch-2 passed
+1 💚checkstyle0m 35sbranch-2 passed
+1 💚spotbugs1m 13sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 30sthe patch passed
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚checkstyle0m 33sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 42sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs1m 24sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
34m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4008
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux bdff5387af3d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 755b3b4
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 5, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 9sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 27sbranch-2 passed
+1 💚compile0m 29sbranch-2 passed
+1 💚shadedjars7m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 8sthe patch passed
+1 💚compile0m 30sthe patch passed
+1 💚javac0m 30sthe patch passed
+1 💚shadedjars7m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit2m 57shbase-client in the patch passed.
36m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4008
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3db483033594 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 755b3b4
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/testReport/
Max. process+thread count234 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun

huaxiangsun commented Jan 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks Duo for the review. I restarted pr-merge check to get a successful run.

@Apache-HBase

Apache-HBase commented Jan 6, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 30sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 20sbranch-2 passed
+1 💚compile0m 29sbranch-2 passed
+1 💚shadedjars7m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 27sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 59sthe patch passed
+1 💚compile0m 28sthe patch passed
+1 💚javac0m 28sthe patch passed
+1 💚shadedjars7m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25sthe patch passed
_ Other Tests _
+1 💚unit3m 9shbase-client in the patch passed.
31m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4008
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 14384a5fb66e 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 7db2777
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/testReport/
Max. process+thread count228 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 6, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 32sbranch-2 passed
+1 💚compile1m 9sbranch-2 passed
+1 💚checkstyle0m 33sbranch-2 passed
+1 💚spotbugs1m 12sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 36sthe patch passed
+1 💚compile1m 8sthe patch passed
+1 💚javac1m 8sthe patch passed
+1 💚checkstyle0m 34sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 48sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs1m 28sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
34m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4008
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 7c8ab41c1871 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 7db2777
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 6, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 40sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall5m 27sbranch-2 passed
+1 💚compile0m 36sbranch-2 passed
+1 💚shadedjars8m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall5m 3sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚shadedjars8m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 31sthe patch passed
_ Other Tests _
+1 💚unit3m 12shbase-client in the patch passed.
35m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4008
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3c0edbb0e550 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 7db2777
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/testReport/
Max. process+thread count215 (vs. ulimit of 12500)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4008/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun
huaxiangsun merged commit c897ce9 into apache:branch-2Jan 6, 2022
huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jan 6, 2022
@huaxiangsunHuaxiang Sun
HBASE-26590 Hbase-client Meta lookup performance regression between h…
15f606e
…base-1 and hbase-2 (apache#4008)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jan 6, 2022
@huaxiangsunHuaxiang Sun
HBASE-26590 Hbase-client Meta lookup performance regression between h…
3ac558e
…base-1 and hbase-2 (apache#4008)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jan 6, 2022
@huaxiangsunHuaxiang Sun
HBASE-26590 Hbase-client Meta lookup performance regression between h…
d5152b5
…base-1 and hbase-2 (apache#4008)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
This was referenced Jan 6, 2022
Merged
Merged
Merged
huaxiangsun added a commit that referenced this pull request Jan 6, 2022
@huaxiangsun
HBASE-26590Hbase-client Meta lookup performance regression betweenh…
a6b0e2d
…base-1 and hbase-2 (#4008) (#4011)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
huaxiangsun added a commit that referenced this pull request Jan 6, 2022
@huaxiangsun
HBASE-26590Hbase-client Meta lookup performance regression betweenh…
f3639bc
…base-1 and hbase-2 (#4008) (#4012)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
huaxiangsun added a commit that referenced this pull request Jan 6, 2022
@huaxiangsun
HBASE-26590Hbase-client Meta lookup performance regression betweenh…
7fcbf62
…base-1 and hbase-2 (#4008) (#4013)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 12, 2022
@huaxiangsun@bbeaudreault
HubSpot Backport: HBASE-26590 Hbase-client Meta lookup performance re…
bd85929
…gression between hbase-1 and hbase-2 (apache#4008)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@huaxiangsun@petersomogyi
HBASE-26590 Hbase-client Meta lookup performance regression between h…
934a819
…base-1 and hbase-2 (apache#4008) (apache#4012)
Change scan caching back to 1 to avoid extra work at Region Server side. For most cases, the extra 4 results
fetched are wasted at the client side.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit f3639bc)
Change-Id: I8077d6133318b66728f8111d9a07290ed943c0bd
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huaxiangsun@Apache-HBase@Apache9