Skip to content

HBASE-26520 Remove use of db.hbase.namespance tracing attribute - #4015

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:26520-tracing-remove-db.hbase.namespace-attribute
Jan 11, 2022
Merged

HBASE-26520 Remove use of db.hbase.namespance tracing attribute#4015
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:26520-tracing-remove-db.hbase.namespace-attribute

Conversation

@ndimiduk

@ndimidukndimiduk commented Jan 6, 2022

Copy link
Copy Markdown
Member

The HBase-specific attribute db.hbase.namespace has been deprecated in favor of the generic
db.name. See also open-telemetry/opentelemetry-specification#1760

@ndimiduk
HBASE-26520 Remove use of db.hbase.namespance tracing attribute
fbbc55a
The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
@ndimiduk
ndimiduk requested review from Apache9 and taklwuJanuary 6, 2022 22:36
@Apache-HBase

Apache-HBase commented Jan 6, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 26smaster passed
+1 💚compile0m 50smaster passed
+1 💚shadedjars9m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 18sthe patch passed
+1 💚compile0m 52sthe patch passed
+1 💚javac0m 52sthe patch passed
+1 💚shadedjars9m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sthe patch passed
_ Other Tests _
+1 💚unit2m 5shbase-common in the patch passed.
+1 💚unit1m 40shbase-client in the patch passed.
37m 14s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4015
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b07f19570d6f 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7972b2e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/testReport/
Max. process+thread count227 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 6, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall6m 31smaster passed
+1 💚compile1m 9smaster passed
+1 💚shadedjars10m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall6m 2sthe patch passed
+1 💚compile1m 7sthe patch passed
+1 💚javac1m 7sthe patch passed
+1 💚shadedjars10m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit2m 33shbase-common in the patch passed.
+1 💚unit1m 59shbase-client in the patch passed.
46m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4015
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ed7e17637cfe 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7972b2e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/testReport/
Max. process+thread count211 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jan 6, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 28smaster passed
+1 💚compile1m 44smaster passed
+1 💚checkstyle0m 53smaster passed
+1 💚spotbugs1m 49smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 20sthe patch passed
+1 💚compile1m 44sthe patch passed
+1 💚javac1m 44sthe patch passed
+1 💚checkstyle0m 52sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 34sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs2m 10sthe patch passed
_ Other Tests _
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
51m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4015
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 8430db17e729 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7972b2e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 9f47ab5 into apache:masterJan 11, 2022
@ndimiduk
ndimiduk deleted the 26520-tracing-remove-db.hbase.namespace-attribute branch January 11, 2022 01:02
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 18, 2022
@ndimiduk
HBASE-26520 Remove use ofdb.hbase.namespancetracing attribute (ap…
d39dabb
…ache#4015)
The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 18, 2022
@ndimiduk
HBASE-26520 Remove use ofdb.hbase.namespancetracing attribute (ap…
90872c8
…ache#4015)
The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
ndimiduk added a commit that referenced this pull request Jan 19, 2022
@ndimiduk
HBASE-26520Remove use ofdb.hbase.namespancetracing attribute (#4015
c2b4ccd
)
The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 19, 2022
@ndimiduk
HBASE-26520 Remove use ofdb.hbase.namespancetracing attribute (ap…
391f77e
…ache#4015)
The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
ndimiduk added a commit that referenced this pull request Jan 24, 2022
@ndimiduk
HBASE-26520Remove use ofdb.hbase.namespancetracing attribute (#4015
6d739de
)
The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwutaklwutaklwu approved these changes
@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndimiduk@Apache-HBase@taklwu@Apache9