Uh oh!
There was an error while loading. Please reload this page.
HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… - #4078
Closed
huaxiangsun wants to merge 1 commit into
Closed
HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…#4078huaxiangsun wants to merge 1 commit into
huaxiangsun wants to merge 1 commit into
Conversation
huaxiangsun
commented
Jan 28, 2022
ContributorAuthor
Hi @Apache9, please review backport as there are some difference between master and branch-2, thanks. |
Apache-HBase
commented
Jan 29, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 29, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 29, 2022
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
Jan 30, 2022
Apache9
left a comment
Contributor
There was a problem hiding this comment.
Sorry I do not think this is ready to go, also for the master PR. Haven't realized we have added a rpc call in the getMetaScan method. We should try to find another better way to do this.
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import static org.apache.hadoop.hbase.client.RegionLocator.LOCATOR_META_REPLICAS_MODE; |
| if (conn != null) { | ||
| try { | ||
| try (Table metaTable = getMetaHTable(conn)) { | ||
| numOfReplicas = metaTable.getDescriptor().getRegionReplication(); |
Contributor
There was a problem hiding this comment.
Ah, this is a bit painful... We used to expect getMetaScan to only contain memory operations but here we will have network io... And everytime we call this method it will generate a rpc calll...
Looking at the code above, in the async code we also have this and we even introduce a blocking rpc call. I haven't realized this when reviewing the PR for master, but obviously it is incorrect, we should not do blocking call in the async code. We should try to find a better way...
ContributorAuthor
There was a problem hiding this comment.
Nice find! Let me back out the master changes.
ContributorAuthor
There was a problem hiding this comment.
I reverted the commit to the master. You are right, the network call is bad. How about changing getMetaScan from a static method to a non-static one, so it can use a cached meta Replica count? Need to handle the case that meta replica count is changed dynamically.
…etAllRegionLocations() Signed-off-by: Duo Zhang <zhangduo@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…etAllRegionLocations()
Signed-off-by: Duo Zhang zhangduo@apache.org