Skip to content

HBASE-26622 Update error-prone to 2.10 - #4133

Merged
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:26622-upgrade-errorprone-2.10
Mar 2, 2022
Merged

HBASE-26622 Update error-prone to 2.10#4133
ndimiduk merged 1 commit into
apache:masterfrom
ndimiduk:26622-upgrade-errorprone-2.10

Conversation

@ndimiduk

@ndimidukndimiduk commented Feb 24, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Picks up on @madrob 's #3979 , applies the changes I outlined. Specifically:

  • Upgrades us to the last version of Error Prone that retains support for JDK8 compiler (happens to be the latest release, at this time)
  • Keeps the errorprone profile attached to JDK8 compiler profile
  • Minor changes regarding java docs and unit test warnings
  • Swap the KeyValue#clone method to use Arrays.copyOf as Mike suggested in the other PR.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
Apache9
Apache9 reviewed Feb 25, 2022
View reviewed changes
Comment threadhbase-endpoint/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
* @param P PB message that is used to transport initializer specific bytes
* @param Q PB message that is used to transport Cell (<T>) instance
* @param R PB message that is used to transport Promoted (<S>) instance
* @param <T> Cell value data type

@Apache9Apache9Feb 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change introduce javadoc warning or checkstyle warning?

@ndimidukndimidukFeb 28, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, checking the precommit output, I see no new javadoc or checkstyle warnings originating from this file.

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java Outdated
Comment thread...-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMergesSplitsAddToTracker.java Outdated
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 26622-upgrade-errorprone-2.10 branch from a4ca004 to a165f03CompareFebruary 28, 2022 10:25
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk
ndimidukforce-pushed the 26622-upgrade-errorprone-2.10 branch from a165f03 to 81f38a7CompareMarch 1, 2022 13:47
@Apache-HBase

Apache-HBase commented Mar 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall2m 38smaster passed
+1 💚compile5m 49smaster passed
+1 💚checkstyle1m 9smaster passed
+1 💚spotbugs10m 47smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile6m 15sthe patch passed
-0 ⚠️javac6m 15sroot generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)
+1 💚checkstyle1m 10sroot: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 22sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs11m 38sthe patch passed
_ Other Tests _
+1 💚asflicense1m 13sThe patch does not generate ASF License warnings.
63m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4133
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 6d6b19e9ee6e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e85bf41
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall3m 26smaster passed
+1 💚compile2m 10smaster passed
+1 💚shadedjars4m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile1m 48sthe patch passed
+1 💚javac1m 48sthe patch passed
+1 💚shadedjars3m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 19sthe patch passed
_ Other Tests _
+1 💚unit405m 28sroot in the patch passed.
435m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4133
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ac920f911ce4 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e85bf41
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/testReport/
Max. process+thread count2445 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile1m 46smaster passed
+1 💚shadedjars4m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 9smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile1m 57sthe patch passed
+1 💚javac1m 57sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 38sthe patch passed
_ Other Tests _
+1 💚unit625m 43sroot in the patch passed.
656m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4133
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b624280b7345 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e85bf41
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/testReport/
Max. process+thread count2414 (vs. ulimit of 30000)
modulesC: hbase-build-configuration hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@madrob@ndimiduk
HBASE-26622 Update error-prone to 2.10
a552add
Author: Mike Drob <mdrob@apache.org>
Co-authored-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
@ndimiduk
ndimidukforce-pushed the 26622-upgrade-errorprone-2.10 branch from 81f38a7 to a552addCompareMarch 2, 2022 14:58
@ndimiduk
ndimiduk merged commit 06f06cb into apache:masterMar 2, 2022
@ndimiduk
ndimiduk deleted the 26622-upgrade-errorprone-2.10 branch March 2, 2022 15:07
@ndimidukndimiduk mentioned this pull request Mar 2, 2022
Closed
@Apache-HBase

Apache-HBase commented Mar 2, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall2m 25smaster passed
+1 💚compile5m 25smaster passed
+1 💚checkstyle1m 8smaster passed
+1 💚spotbugs10m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile6m 8sthe patch passed
-0 ⚠️javac6m 8sroot generated 119 new + 1353 unchanged - 272 fixed = 1472 total (was 1625)
+1 💚checkstyle1m 5sroot: The patch generated 0 new + 80 unchanged - 5 fixed = 80 total (was 85)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 0sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 17sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚spotbugs11m 33sthe patch passed
_ Other Tests _
+1 💚asflicense0m 51sThe patch does not generate ASF License warnings.
60m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4133
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
unameLinux 2a954ae14eee 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 87f8d9a
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 2, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for branch
+1 💚mvninstall3m 12smaster passed
+1 💚compile1m 57smaster passed
+1 💚shadedjars4m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile1m 56sthe patch passed
+1 💚javac1m 56sthe patch passed
+1 💚shadedjars4m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 21sthe patch passed
_ Other Tests _
-1 ❌unit347m 19sroot in the patch failed.
376m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4133
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ad9728fda56d 5.4.0-1047-aws #49~18.04.1-Ubuntu SMP Wed Apr 28 23:08:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 87f8d9a
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/
Max. process+thread count1551 (vs. ulimit of 30000)
modulesC: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Mar 2, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall2m 21smaster passed
+1 💚compile1m 39smaster passed
+1 💚shadedjars3m 43sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 53smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 21sthe patch passed
+1 💚compile1m 40sthe patch passed
+1 💚javac1m 40sthe patch passed
+1 💚shadedjars3m 45spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 53sthe patch passed
_ Other Tests _
-1 ❌unit471m 32sroot in the patch failed.
496m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4133
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2240dd146828 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 87f8d9a
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/testReport/
Max. process+thread count1664 (vs. ulimit of 30000)
modulesC: hbase-common hbase-asyncfs hbase-server hbase-mapreduce hbase-thrift hbase-endpoint . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4133/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 left review comments
@apurtellapurtellapurtell approved these changes
@madrobmadrobmadrob approved these changes
@busbeybusbeyAwaiting requested review from busbey
@joshelserjoshelserAwaiting requested review from joshelser
@jojochuangjojochuangAwaiting requested review from jojochuang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ndimiduk@Apache-HBase@apurtell@madrob@Apache9